CoCalc -- github

GitHub Repository: freebsd/freebsd-src
Path: blob/main/contrib/bc/project/github_prs.json
³⁹⁴⁸² views
1
[
2
  {
3
    "additions": 8,
4
    "assignees": [],
5
    "author": {
6
      "id": "MDQ6VXNlcjM5MjUwOQ==",
7
      "is_bot": false,
8
      "login": "bolknote",
9
      "name": "Evgeny Stepanischev"
10
    },
11
    "autoMergeRequest": null,
12
    "baseRefName": "master",
13
    "baseRefOid": "9f34d2427d3f13c8e95b8485f5a6041789ffe400",
14
    "body": "Code:\r\n`define a(*t[], t[]) {}`\r\n\r\nExpected result:\r\nParse error: function parameter or auto \"t[]\" already exists\r\n\r\nActual result:\r\nParses successfully (incorrect)\r\n\r\nThe interpreter now correctly rejects functions with duplicate parameter names, even when one is a reference array (*t[]).",
15
    "changedFiles": 3,
16
    "closed": true,
17
    "closedAt": "2025-03-25T04:55:24Z",
18
    "comments": [
19
      {
20
        "id": "IC_kwDOCL0xJc6j52QL",
21
        "author": {
22
          "login": "gavinhoward"
23
        },
24
        "authorAssociation": "OWNER",
25
        "body": "Oh, and another thing you could get credit for: if you create `tests/bc/errors/39.txt` and put your reproducer into it, I would accept that too.",
26
        "createdAt": "2025-03-25T02:01:13Z",
27
        "includesCreatedEdit": false,
28
        "isMinimized": false,
29
        "minimizedReason": "",
30
        "reactionGroups": [],
31
        "url": "https://github.com/gavinhoward/bc/pull/89#issuecomment-2749850635",
32
        "viewerDidAuthor": true
33
      },
34
      {
35
        "id": "IC_kwDOCL0xJc6j6h5M",
36
        "author": {
37
          "login": "bolknote"
38
        },
39
        "authorAssociation": "CONTRIBUTOR",
40
        "body": "Yes, no problem! I hope I’ve managed to cover everything needed. If something isn’t quite right, please let me know!",
41
        "createdAt": "2025-03-25T04:16:09Z",
42
        "includesCreatedEdit": false,
43
        "isMinimized": false,
44
        "minimizedReason": "",
45
        "reactionGroups": [],
46
        "url": "https://github.com/gavinhoward/bc/pull/89#issuecomment-2750029388",
47
        "viewerDidAuthor": false
48
      },
49
      {
50
        "id": "IC_kwDOCL0xJc6j6uej",
51
        "author": {
52
          "login": "gavinhoward"
53
        },
54
        "authorAssociation": "OWNER",
55
        "body": "Looks good!",
56
        "createdAt": "2025-03-25T04:55:31Z",
57
        "includesCreatedEdit": false,
58
        "isMinimized": false,
59
        "minimizedReason": "",
60
        "reactionGroups": [],
61
        "url": "https://github.com/gavinhoward/bc/pull/89#issuecomment-2750080931",
62
        "viewerDidAuthor": true
63
      }
64
    ],
65
    "commits": [
66
      {
67
        "authoredDate": "2025-03-24T22:31:38Z",
68
        "authors": [
69
          {
70
            "email": "[email protected]",
71
            "id": "MDQ6VXNlcjM5MjUwOQ==",
72
            "login": "bolknote",
73
            "name": "Evgeny Stepanischev"
74
          }
75
        ],
76
        "committedDate": "2025-03-24T22:31:38Z",
77
        "messageBody": "",
78
        "messageHeadline": "Fix duplicate param check for ref arrays",
79
        "oid": "97756f3dc17b74c2a9c31488e8680a03f2f016eb"
80
      },
81
      {
82
        "authoredDate": "2025-03-25T04:07:25Z",
83
        "authors": [
84
          {
85
            "email": "[email protected]",
86
            "id": "MDQ6VXNlcjM5MjUwOQ==",
87
            "login": "bolknote",
88
            "name": "Evgeny Stepanischev"
89
          }
90
        ],
91
        "committedDate": "2025-03-25T04:07:25Z",
92
        "messageBody": "",
93
        "messageHeadline": "Fix coding style",
94
        "oid": "facbd16ceecdd72015abe21f6f4fe4d686b8e66b"
95
      },
96
      {
97
        "authoredDate": "2025-03-25T04:10:52Z",
98
        "authors": [
99
          {
100
            "email": "[email protected]",
101
            "id": "MDQ6VXNlcjM5MjUwOQ==",
102
            "login": "bolknote",
103
            "name": "Evgeny Stepanischev"
104
          }
105
        ],
106
        "committedDate": "2025-03-25T04:10:52Z",
107
        "messageBody": "This test ensures the interpreter correctly rejects functions with\nduplicate parameter names, even when one is a reference array (*t[]).",
108
        "messageHeadline": "Add test for duplicate ref array parameters",
109
        "oid": "a10b2fd6a2b77325dc981a8ce296d1c22c47ba0a"
110
      }
111
    ],
112
    "createdAt": "2025-03-24T22:35:24Z",
113
    "deletions": 2,
114
    "files": [
115
      {
116
        "path": "include/lang.h",
117
        "additions": 4,
118
        "deletions": 0
119
      },
120
      {
121
        "path": "src/lang.c",
122
        "additions": 3,
123
        "deletions": 2
124
      },
125
      {
126
        "path": "tests/bc/errors/39.txt",
127
        "additions": 1,
128
        "deletions": 0
129
      }
130
    ],
131
    "fullDatabaseId": "2414968976",
132
    "headRefName": "master",
133
    "headRefOid": "a10b2fd6a2b77325dc981a8ce296d1c22c47ba0a",
134
    "headRepository": {
135
      "id": "R_kgDOOARsdw",
136
      "name": "bc"
137
    },
138
    "headRepositoryOwner": {
139
      "id": "MDQ6VXNlcjM5MjUwOQ==",
140
      "name": "Evgeny Stepanischev",
141
      "login": "bolknote"
142
    },
143
    "id": "PR_kwDOCL0xJc6P8YCQ",
144
    "isCrossRepository": true,
145
    "isDraft": false,
146
    "labels": [],
147
    "latestReviews": [
148
      {
149
        "id": "",
150
        "author": {
151
          "login": "gavinhoward"
152
        },
153
        "authorAssociation": "OWNER",
154
        "body": "I'll be upfront: I have accepted this because it passes the tests, and yes, it is a bug.\r\n\r\nHowever, if you run `./scripts/format.sh` on the repo before I do that, I won't have to adjust the style, which would hide your contribution for the `if` statement in `src/lang.c`.\r\n\r\nIf you could do that, I'd appreciate it, and you would get to keep your credit. If not, no problem; just tell me.",
155
        "submittedAt": "2025-03-25T01:55:21Z",
156
        "includesCreatedEdit": false,
157
        "reactionGroups": [],
158
        "state": "CHANGES_REQUESTED",
159
        "commit": {
160
          "oid": ""
161
        }
162
      }
163
    ],
164
    "maintainerCanModify": false,
165
    "mergeCommit": {
166
      "oid": "0013dbee105fad63633ffe11240b18deb3d4bf9e"
167
    },
168
    "mergeStateStatus": "UNKNOWN",
169
    "mergeable": "UNKNOWN",
170
    "mergedAt": "2025-03-25T04:55:24Z",
171
    "mergedBy": {
172
      "id": "MDQ6VXNlcjMxNzI2ODc=",
173
      "is_bot": false,
174
      "login": "gavinhoward",
175
      "name": "Gavin D. Howard"
176
    },
177
    "milestone": null,
178
    "number": 89,
179
    "potentialMergeCommit": null,
180
    "projectCards": [],
181
    "projectItems": [],
182
    "reactionGroups": [],
183
    "reviewDecision": "CHANGES_REQUESTED",
184
    "reviewRequests": [],
185
    "reviews": [
186
      {
187
        "id": "PRR_kwDOCL0xJc6hpxI0",
188
        "author": {
189
          "login": "gavinhoward"
190
        },
191
        "authorAssociation": "OWNER",
192
        "body": "I'll be upfront: I have accepted this because it passes the tests, and yes, it is a bug.\r\n\r\nHowever, if you run `./scripts/format.sh` on the repo before I do that, I won't have to adjust the style, which would hide your contribution for the `if` statement in `src/lang.c`.\r\n\r\nIf you could do that, I'd appreciate it, and you would get to keep your credit. If not, no problem; just tell me.",
193
        "submittedAt": "2025-03-25T01:55:21Z",
194
        "includesCreatedEdit": false,
195
        "reactionGroups": [],
196
        "state": "CHANGES_REQUESTED",
197
        "commit": {
198
          "oid": "97756f3dc17b74c2a9c31488e8680a03f2f016eb"
199
        }
200
      }
201
    ],
202
    "state": "MERGED",
203
    "statusCheckRollup": [],
204
    "title": "Fix duplicate param check for ref arrays",
205
    "updatedAt": "2025-03-25T04:55:32Z",
206
    "url": "https://github.com/gavinhoward/bc/pull/89"
207
  },
208
  {
209
    "additions": 21,
210
    "assignees": [],
211
    "author": {
212
      "id": "MDQ6VXNlcjM5MjUwOQ==",
213
      "is_bot": false,
214
      "login": "bolknote",
215
      "name": "Evgeny Stepanischev"
216
    },
217
    "autoMergeRequest": null,
218
    "baseRefName": "master",
219
    "baseRefOid": "79d5bffaa1c74888d62c47342e5b99a96797a8b5",
220
    "body": "```\r\nsrand = 10\r\n\r\nfor (i = 0; i < 1000000; i++) {\r\n\ta = irand(100000000)\r\n\tb = irand(100000000)\r\n\r\n\t. = new_band(a, b)\r\n}\r\n```\r\n\r\ntime bc -l band.bc\r\n\r\nreal\t0m12.768s\r\nuser\t0m12.735s\r\nsys\t0m0.030s\r\n\r\n```\r\nsrand = 10\r\n\r\nfor (i = 0; i < 1000000; i++) {\r\n\ta = irand(100000000)\r\n\tb = irand(100000000)\r\n\r\n\t. = band(a, b)\r\n}\r\n```\r\ntime bc -l band.bc\r\n\r\nreal\t0m25.416s\r\nuser\t0m25.270s\r\nsys\t0m0.119s",
221
    "changedFiles": 1,
222
    "closed": true,
223
    "closedAt": "2025-03-01T05:22:26Z",
224
    "comments": [
225
      {
226
        "id": "IC_kwDOCL0xJc6gdBpI",
227
        "author": {
228
          "login": "gavinhoward"
229
        },
230
        "authorAssociation": "OWNER",
231
        "body": "After convincing myself that your changes are correct, I accept them.\r\n\r\nHowever, I *am* going to adjust the style; the lib2 file gets put into the executable as a string, and I want to eliminate useless characters.",
232
        "createdAt": "2025-03-01T05:22:29Z",
233
        "includesCreatedEdit": false,
234
        "isMinimized": false,
235
        "minimizedReason": "",
236
        "reactionGroups": [],
237
        "url": "https://github.com/gavinhoward/bc/pull/88#issuecomment-2691963464",
238
        "viewerDidAuthor": true
239
      }
240
    ],
241
    "commits": [
242
      {
243
        "authoredDate": "2025-02-27T06:55:52Z",
244
        "authors": [
245
          {
246
            "email": "[email protected]",
247
            "id": "MDQ6VXNlcjM5MjUwOQ==",
248
            "login": "bolknote",
249
            "name": "Evgeny Stepanischev"
250
          }
251
        ],
252
        "committedDate": "2025-02-27T06:55:52Z",
253
        "messageBody": "",
254
        "messageHeadline": "The band() function has been accelerated almost 2x",
255
        "oid": "4112814ae6456dd8d0455a1a6b1d06f7ab78d59a"
256
      }
257
    ],
258
    "createdAt": "2025-02-27T07:03:09Z",
259
    "deletions": 19,
260
    "files": [
261
      {
262
        "path": "gen/lib2.bc",
263
        "additions": 21,
264
        "deletions": 19
265
      }
266
    ],
267
    "fullDatabaseId": "2361404896",
268
    "headRefName": "master",
269
    "headRefOid": "4112814ae6456dd8d0455a1a6b1d06f7ab78d59a",
270
    "headRepository": {
271
      "id": "R_kgDOOARsdw",
272
      "name": "bc"
273
    },
274
    "headRepositoryOwner": {
275
      "id": "MDQ6VXNlcjM5MjUwOQ==",
276
      "name": "Evgeny Stepanischev",
277
      "login": "bolknote"
278
    },
279
    "id": "PR_kwDOCL0xJc6MwC3g",
280
    "isCrossRepository": true,
281
    "isDraft": false,
282
    "labels": [],
283
    "latestReviews": [],
284
    "maintainerCanModify": false,
285
    "mergeCommit": {
286
      "oid": "6c12610da98b69e873702479e49218e2944437da"
287
    },
288
    "mergeStateStatus": "UNKNOWN",
289
    "mergeable": "UNKNOWN",
290
    "mergedAt": "2025-03-01T05:22:26Z",
291
    "mergedBy": {
292
      "id": "MDQ6VXNlcjMxNzI2ODc=",
293
      "is_bot": false,
294
      "login": "gavinhoward",
295
      "name": "Gavin D. Howard"
296
    },
297
    "milestone": null,
298
    "number": 88,
299
    "potentialMergeCommit": null,
300
    "projectCards": [],
301
    "projectItems": [],
302
    "reactionGroups": [],
303
    "reviewDecision": "",
304
    "reviewRequests": [],
305
    "reviews": [],
306
    "state": "MERGED",
307
    "statusCheckRollup": [],
308
    "title": "The band() function has been accelerated almost 2x",
309
    "updatedAt": "2025-03-01T05:22:30Z",
310
    "url": "https://github.com/gavinhoward/bc/pull/88"
311
  },
312
  {
313
    "additions": 8,
314
    "assignees": [],
315
    "author": {
316
      "id": "MDQ6VXNlcjQ5NzIxNTU=",
317
      "is_bot": false,
318
      "login": "dag-erling",
319
      "name": "Dag-Erling Smørgrav"
320
    },
321
    "autoMergeRequest": null,
322
    "baseRefName": "master",
323
    "baseRefOid": "ca389548763c40852040e5c028b0869b47a3710f",
324
    "body": "Previously, we would catch `SIGWINCH` and call `el_resize()` from the signal handler.  This is unsafe and led to strange behavior such as terminating on second resize.  The simplest solution is to let libedit handle `SIGWINCH` itself.\r\n\r\nThis reverts 56bb18255a24 and 89d6c3451a60 and removes all traces of `SIGWINCH` from bc itself, and instead sets the `EL_SIGNAL` flag on the editline context, which causes libedit to detect and handle terminal size changes internally.",
325
    "changedFiles": 5,
326
    "closed": true,
327
    "closedAt": "2025-01-09T03:21:56Z",
328
    "comments": [
329
      {
330
        "id": "IC_kwDOCL0xJc6UKjDG",
331
        "author": {
332
          "login": "gavinhoward"
333
        },
334
        "authorAssociation": "OWNER",
335
        "body": "Thank you for your contribution.\r\n\r\nHowever, I cannot accept it. The man page for libedit says that it installs its own signal handler for a set of signals, one of which is `SIGINT`, which `bc` needs to treat specially. So I cannot use `EL_SIGNAL`. If libedit only handled `SIGWINCH`, this would work.",
336
        "createdAt": "2024-11-19T13:57:00Z",
337
        "includesCreatedEdit": false,
338
        "isMinimized": false,
339
        "minimizedReason": "",
340
        "reactionGroups": [],
341
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2485792966",
342
        "viewerDidAuthor": true
343
      },
344
      {
345
        "id": "IC_kwDOCL0xJc6UKzkD",
346
        "author": {
347
          "login": "dag-erling"
348
        },
349
        "authorAssociation": "CONTRIBUTOR",
350
        "body": "Did you even test my patch? It works just fine, because (except for `SIGWINCH` and `SIGCONT`) libedit restores the previous signal handler and re-posts the signal after cleaning up.",
351
        "createdAt": "2024-11-19T14:24:15Z",
352
        "includesCreatedEdit": false,
353
        "isMinimized": false,
354
        "minimizedReason": "",
355
        "reactionGroups": [],
356
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2485860611",
357
        "viewerDidAuthor": false
358
      },
359
      {
360
        "id": "IC_kwDOCL0xJc6ULIip",
361
        "author": {
362
          "login": "gavinhoward"
363
        },
364
        "authorAssociation": "OWNER",
365
        "body": "I tested it on macOS. It did not work with `SIGINT`. I do not have access to a Linux machine, but I will later in the day.\r\n\r\nBut I do not like depending on that behavior. Signals are finicky, and that could expose platform differences.",
366
        "createdAt": "2024-11-19T14:56:46Z",
367
        "includesCreatedEdit": false,
368
        "isMinimized": false,
369
        "minimizedReason": "",
370
        "reactionGroups": [],
371
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2485946537",
372
        "viewerDidAuthor": true
373
      },
374
      {
375
        "id": "IC_kwDOCL0xJc6ULaEs",
376
        "author": {
377
          "login": "dag-erling"
378
        },
379
        "authorAssociation": "CONTRIBUTOR",
380
        "body": "I developed the patch on macOS, it works perfectly fine there and on FreeBSD. If you have an issue with it, perhaps you can describe the symptoms so I can help you figure it out instead of dismissing it out of hand?",
381
        "createdAt": "2024-11-19T15:22:57Z",
382
        "includesCreatedEdit": false,
383
        "isMinimized": false,
384
        "minimizedReason": "",
385
        "reactionGroups": [],
386
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2486018348",
387
        "viewerDidAuthor": false
388
      },
389
      {
390
        "id": "IC_kwDOCL0xJc6UMfC7",
391
        "author": {
392
          "login": "gavinhoward"
393
        },
394
        "authorAssociation": "OWNER",
395
        "body": "Please give me some leniency. Testing it is not dismissing it out of hand. I am wary of making changes that may break things. And I have little time.\r\n\r\nHowever, in this case, I decided to test my code as well and found that it had the same problem: that multiple interrupts would not be handled. I found the fix, and it works for your code.\r\n\r\nIt make still take me time to test on Linux and FreeBSD, but this patch may still be viable.",
396
        "createdAt": "2024-11-19T17:16:46Z",
397
        "includesCreatedEdit": false,
398
        "isMinimized": false,
399
        "minimizedReason": "",
400
        "reactionGroups": [],
401
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2486300859",
402
        "viewerDidAuthor": true
403
      },
404
      {
405
        "id": "IC_kwDOCL0xJc6Zugh4",
406
        "author": {
407
          "login": "gavinhoward"
408
        },
409
        "authorAssociation": "OWNER",
410
        "body": "Tested on Linux, FreeBSD, and macOS. With my fix, it works. There should be a release out soon-ish.\r\n\r\nThank you for your patience.",
411
        "createdAt": "2025-01-09T03:22:42Z",
412
        "includesCreatedEdit": false,
413
        "isMinimized": false,
414
        "minimizedReason": "",
415
        "reactionGroups": [],
416
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2579105912",
417
        "viewerDidAuthor": true
418
      },
419
      {
420
        "id": "IC_kwDOCL0xJc6aDHFg",
421
        "author": {
422
          "login": "dag-erling"
423
        },
424
        "authorAssociation": "CONTRIBUTOR",
425
        "body": "Thank you!",
426
        "createdAt": "2025-01-10T22:18:03Z",
427
        "includesCreatedEdit": false,
428
        "isMinimized": false,
429
        "minimizedReason": "",
430
        "reactionGroups": [],
431
        "url": "https://github.com/gavinhoward/bc/pull/86#issuecomment-2584506720",
432
        "viewerDidAuthor": false
433
      }
434
    ],
435
    "commits": [
436
      {
437
        "authoredDate": "2024-11-12T11:50:39Z",
438
        "authors": [
439
          {
440
            "email": "[email protected]",
441
            "id": "MDQ6VXNlcjQ5NzIxNTU=",
442
            "login": "dag-erling",
443
            "name": "Dag-Erling Smørgrav"
444
          }
445
        ],
446
        "committedDate": "2024-11-12T11:59:50Z",
447
        "messageBody": "Previously, we would catch SIGWINCH and call el_resize() from the signal handler.  This is unsafe and led to strange behavior such as terminating on second resize.  The simplest solution is to let libedit handle SIGWINCH itself.\n\nThis reverts 56bb18255a24 and 89d6c3451a60 and removes all traces of SIGWINCH from bc itself, and instead sets the EL_SIGNAL flag on the editline context, which causes libedit to detect and handle terminal size changes internally.",
448
        "messageHeadline": "Let libedit handle terminal size changes.",
449
        "oid": "e671399e9dc92181219da87e3aa02d44a0b4a4c3"
450
      }
451
    ],
452
    "createdAt": "2024-11-12T12:02:29Z",
453
    "deletions": 79,
454
    "files": [
455
      {
456
        "path": "include/history.h",
457
        "additions": 0,
458
        "deletions": 24
459
      },
460
      {
461
        "path": "include/status.h",
462
        "additions": 0,
463
        "deletions": 5
464
      },
465
      {
466
        "path": "src/history.c",
467
        "additions": 2,
468
        "deletions": 12
469
      },
470
      {
471
        "path": "src/read.c",
472
        "additions": 6,
473
        "deletions": 12
474
      },
475
      {
476
        "path": "src/vm.c",
477
        "additions": 0,
478
        "deletions": 26
479
      }
480
    ],
481
    "fullDatabaseId": "2174734014",
482
    "headRefName": "des/sigwinch",
483
    "headRefOid": "e671399e9dc92181219da87e3aa02d44a0b4a4c3",
484
    "headRepository": {
485
      "id": "R_kgDONOIgRA",
486
      "name": "bc"
487
    },
488
    "headRepositoryOwner": {
489
      "id": "MDQ6VXNlcjQ5NzIxNTU=",
490
      "name": "Dag-Erling Smørgrav",
491
      "login": "dag-erling"
492
    },
493
    "id": "PR_kwDOCL0xJc6Bn86-",
494
    "isCrossRepository": true,
495
    "isDraft": false,
496
    "labels": [],
497
    "latestReviews": [],
498
    "maintainerCanModify": false,
499
    "mergeCommit": {
500
      "oid": "79d5bffaa1c74888d62c47342e5b99a96797a8b5"
501
    },
502
    "mergeStateStatus": "UNKNOWN",
503
    "mergeable": "UNKNOWN",
504
    "mergedAt": "2025-01-09T03:21:55Z",
505
    "mergedBy": {
506
      "id": "MDQ6VXNlcjMxNzI2ODc=",
507
      "is_bot": false,
508
      "login": "gavinhoward",
509
      "name": "Gavin D. Howard"
510
    },
511
    "milestone": null,
512
    "number": 86,
513
    "potentialMergeCommit": null,
514
    "projectCards": [],
515
    "projectItems": [],
516
    "reactionGroups": [],
517
    "reviewDecision": "",
518
    "reviewRequests": [],
519
    "reviews": [],
520
    "state": "MERGED",
521
    "statusCheckRollup": [],
522
    "title": "Let libedit handle terminal size changes.",
523
    "updatedAt": "2025-01-10T22:18:04Z",
524
    "url": "https://github.com/gavinhoward/bc/pull/86"
525
  },
526
  {
527
    "additions": 12,
528
    "assignees": [],
529
    "author": {
530
      "id": "U_kgDOCgjy1g",
531
      "is_bot": false,
532
      "login": "henke9600",
533
      "name": ""
534
    },
535
    "autoMergeRequest": null,
536
    "baseRefName": "master",
537
    "baseRefOid": "c5b7724ee07daa729f0123c6024223b834de42e3",
538
    "body": "It's possible that the warning being ignored wasn't enabled in the first place, so always enabling it again is wrong.\r\n\r\nIn practice, this resulted in unexpected -Wdisabled-macro-expansion warnings when compiling against musl libc.",
539
    "changedFiles": 3,
540
    "closed": true,
541
    "closedAt": "2024-09-21T19:14:25Z",
542
    "comments": [
543
      {
544
        "id": "IC_kwDOCL0xJc6M-4FI",
545
        "author": {
546
          "login": "gavinhoward"
547
        },
548
        "authorAssociation": "OWNER",
549
        "body": "I have no comments. You followed style, and I agree that this was a problem. In fact, I had been intending to fix it, but I kept forgetting.\r\n\r\nThe question now is whether I should release. Do you know of any musl-based distros that use this `bc`? If not, I may not worry about releasing.",
550
        "createdAt": "2024-09-21T19:15:47Z",
551
        "includesCreatedEdit": false,
552
        "isMinimized": false,
553
        "minimizedReason": "",
554
        "reactionGroups": [],
555
        "url": "https://github.com/gavinhoward/bc/pull/84#issuecomment-2365292872",
556
        "viewerDidAuthor": true
557
      },
558
      {
559
        "id": "IC_kwDOCL0xJc6M-6p8",
560
        "author": {
561
          "login": "henke9600"
562
        },
563
        "authorAssociation": "CONTRIBUTOR",
564
        "body": "Not sure. I use it in my hobby distro, but i can live with the warning :slightly_smiling_face: ",
565
        "createdAt": "2024-09-21T19:57:46Z",
566
        "includesCreatedEdit": false,
567
        "isMinimized": false,
568
        "minimizedReason": "",
569
        "reactionGroups": [],
570
        "url": "https://github.com/gavinhoward/bc/pull/84#issuecomment-2365303420",
571
        "viewerDidAuthor": false
572
      },
573
      {
574
        "id": "IC_kwDOCL0xJc6M_b08",
575
        "author": {
576
          "login": "gavinhoward"
577
        },
578
        "authorAssociation": "OWNER",
579
        "body": ":)\r\n\r\nI think I'll do a release soonish for Gentoo's sake; technically, Gentoo users can use musl.",
580
        "createdAt": "2024-09-22T03:16:02Z",
581
        "includesCreatedEdit": false,
582
        "isMinimized": false,
583
        "minimizedReason": "",
584
        "reactionGroups": [],
585
        "url": "https://github.com/gavinhoward/bc/pull/84#issuecomment-2365439292",
586
        "viewerDidAuthor": true
587
      },
588
      {
589
        "id": "IC_kwDOCL0xJc6NRQWz",
590
        "author": {
591
          "login": "gavinhoward"
592
        },
593
        "authorAssociation": "OWNER",
594
        "body": "`7.0.3` is out. I hope it works for you.",
595
        "createdAt": "2024-09-24T04:12:15Z",
596
        "includesCreatedEdit": false,
597
        "isMinimized": false,
598
        "minimizedReason": "",
599
        "reactionGroups": [],
600
        "url": "https://github.com/gavinhoward/bc/pull/84#issuecomment-2370110899",
601
        "viewerDidAuthor": true
602
      }
603
    ],
604
    "commits": [
605
      {
606
        "authoredDate": "2024-09-21T15:30:32Z",
607
        "authors": [
608
          {
609
            "email": "[email protected]",
610
            "id": "U_kgDOCgjy1g",
611
            "login": "henke9600",
612
            "name": "Henrik Lindström"
613
          }
614
        ],
615
        "committedDate": "2024-09-21T15:47:44Z",
616
        "messageBody": "It's possible that the warning being ignored wasn't enabled in the first\nplace, so always enabling it again is wrong.\n\nIn practice, this resulted in unexpected -Wdisabled-macro-expansion warnings\nwhen compiling against musl libc.\n\nSigned-off-by: Henrik Lindström <[email protected]>",
617
        "messageHeadline": "Don't unconditionally enable warnings after ignoring them",
618
        "oid": "16c4f913ed0935a878ce2644aab2ccc0da05c8d0"
619
      }
620
    ],
621
    "createdAt": "2024-09-21T15:49:45Z",
622
    "deletions": 6,
623
    "files": [
624
      {
625
        "path": "src/file.c",
626
        "additions": 2,
627
        "deletions": 1
628
      },
629
      {
630
        "path": "src/program.c",
631
        "additions": 8,
632
        "deletions": 4
633
      },
634
      {
635
        "path": "src/vm.c",
636
        "additions": 2,
637
        "deletions": 1
638
      }
639
    ],
640
    "fullDatabaseId": "2084576864",
641
    "headRefName": "master",
642
    "headRefOid": "16c4f913ed0935a878ce2644aab2ccc0da05c8d0",
643
    "headRepository": {
644
      "id": "R_kgDOL0az5w",
645
      "name": "bc"
646
    },
647
    "headRepositoryOwner": {
648
      "id": "U_kgDOCgjy1g",
649
      "login": "henke9600"
650
    },
651
    "id": "PR_kwDOCL0xJc58QB5g",
652
    "isCrossRepository": true,
653
    "isDraft": false,
654
    "labels": [],
655
    "latestReviews": [],
656
    "maintainerCanModify": false,
657
    "mergeCommit": {
658
      "oid": "e5d675785383ce6142116243aa63d21e5afb54f7"
659
    },
660
    "mergeStateStatus": "UNKNOWN",
661
    "mergeable": "UNKNOWN",
662
    "mergedAt": "2024-09-21T19:14:25Z",
663
    "mergedBy": {
664
      "id": "MDQ6VXNlcjMxNzI2ODc=",
665
      "is_bot": false,
666
      "login": "gavinhoward",
667
      "name": "Gavin D. Howard"
668
    },
669
    "milestone": null,
670
    "number": 84,
671
    "potentialMergeCommit": null,
672
    "projectCards": [],
673
    "projectItems": [],
674
    "reactionGroups": [],
675
    "reviewDecision": "",
676
    "reviewRequests": [],
677
    "reviews": [],
678
    "state": "MERGED",
679
    "statusCheckRollup": [],
680
    "title": "Don't unconditionally enable warnings after ignoring them",
681
    "updatedAt": "2024-09-24T04:12:15Z",
682
    "url": "https://github.com/gavinhoward/bc/pull/84"
683
  },
684
  {
685
    "additions": 1,
686
    "assignees": [],
687
    "author": {
688
      "id": "U_kgDOBqIXaQ",
689
      "is_bot": false,
690
      "login": "GregTonoski",
691
      "name": "Greg Tonoski"
692
    },
693
    "autoMergeRequest": null,
694
    "baseRefName": "master",
695
    "baseRefOid": "324c30985c0d3d6f918fe81f2d8750c0bd1c78b1",
696
    "body": "",
697
    "changedFiles": 1,
698
    "closed": true,
699
    "closedAt": "2024-08-31T18:15:37Z",
700
    "comments": [
701
      {
702
        "id": "IC_kwDOCL0xJc6KdjgL",
703
        "author": {
704
          "login": "gavinhoward"
705
        },
706
        "authorAssociation": "OWNER",
707
        "body": "Thank you for catching that!\r\n\r\nUnfortunately, `A.1.md` is actually generated from `bc.1.md.in`. I edited `bc.1.md.in` instead and regenerated the manpages.\r\n\r\nI wasn't able to set you as the author of the commit because I don't know your email address, but I will if you want.",
708
        "createdAt": "2024-08-31T18:16:53Z",
709
        "includesCreatedEdit": false,
710
        "isMinimized": false,
711
        "minimizedReason": "",
712
        "reactionGroups": [
713
          {
714
            "content": "THUMBS_UP",
715
            "users": {
716
              "totalCount": 1
717
            }
718
          }
719
        ],
720
        "url": "https://github.com/gavinhoward/bc/pull/81#issuecomment-2323003403",
721
        "viewerDidAuthor": true
722
      }
723
    ],
724
    "commits": [
725
      {
726
        "authoredDate": "2024-08-31T07:52:27Z",
727
        "authors": [
728
          {
729
            "email": "[email protected]",
730
            "id": "U_kgDOBqIXaQ",
731
            "login": "GregTonoski",
732
            "name": "Greg Tonoski"
733
          }
734
        ],
735
        "committedDate": "2024-08-31T07:52:27Z",
736
        "messageBody": "",
737
        "messageHeadline": "Update A.1.md minor correction - number instead of integer",
738
        "oid": "8269063d303979de8188f4810a1c6b070494e025"
739
      }
740
    ],
741
    "createdAt": "2024-08-31T07:52:34Z",
742
    "deletions": 1,
743
    "files": [
744
      {
745
        "path": "manuals/bc/A.1.md",
746
        "additions": 1,
747
        "deletions": 1
748
      }
749
    ],
750
    "fullDatabaseId": "2047601609",
751
    "headRefName": "patch-1",
752
    "headRefOid": "8269063d303979de8188f4810a1c6b070494e025",
753
    "headRepository": {
754
      "id": "R_kgDOMq13Zg",
755
      "name": "bc"
756
    },
757
    "headRepositoryOwner": {
758
      "id": "U_kgDOBqIXaQ",
759
      "name": "Greg Tonoski",
760
      "login": "GregTonoski"
761
    },
762
    "id": "PR_kwDOCL0xJc56C-vJ",
763
    "isCrossRepository": true,
764
    "isDraft": false,
765
    "labels": [],
766
    "latestReviews": [],
767
    "maintainerCanModify": false,
768
    "mergeCommit": null,
769
    "mergeStateStatus": "UNKNOWN",
770
    "mergeable": "UNKNOWN",
771
    "mergedAt": null,
772
    "mergedBy": null,
773
    "milestone": null,
774
    "number": 81,
775
    "potentialMergeCommit": null,
776
    "projectCards": [],
777
    "projectItems": [],
778
    "reactionGroups": [],
779
    "reviewDecision": "",
780
    "reviewRequests": [],
781
    "reviews": [],
782
    "state": "CLOSED",
783
    "statusCheckRollup": [],
784
    "title": "Update A.1.md minor correction - number instead of integer",
785
    "updatedAt": "2024-08-31T18:16:54Z",
786
    "url": "https://github.com/gavinhoward/bc/pull/81"
787
  },
788
  {
789
    "additions": 1,
790
    "assignees": [],
791
    "author": {
792
      "id": "U_kgDOCgjy1g",
793
      "is_bot": false,
794
      "login": "henke9600",
795
      "name": ""
796
    },
797
    "autoMergeRequest": null,
798
    "baseRefName": "master",
799
    "baseRefOid": "3278daef0079c20ccaed3a8666457c531dbe576b",
800
    "body": "This avoids the `./configure.sh: 1693: [: unexpected operator` error when using dash.",
801
    "changedFiles": 1,
802
    "closed": true,
803
    "closedAt": "2024-04-30T01:57:03Z",
804
    "comments": [
805
      {
806
        "id": "IC_kwDOCL0xJc58OZbM",
807
        "author": {
808
          "login": "gavinhoward"
809
        },
810
        "authorAssociation": "OWNER",
811
        "body": "Sorry for the wait.\r\n\r\nYes, you are correct that that is a bug. Yes, your fix is correct. Accepted without comment!\r\n\r\nThank you for your contribution!",
812
        "createdAt": "2024-04-30T01:57:40Z",
813
        "includesCreatedEdit": false,
814
        "isMinimized": false,
815
        "minimizedReason": "",
816
        "reactionGroups": [],
817
        "url": "https://github.com/gavinhoward/bc/pull/76#issuecomment-2084148940",
818
        "viewerDidAuthor": true
819
      }
820
    ],
821
    "commits": [
822
      {
823
        "authoredDate": "2024-04-28T16:12:24Z",
824
        "authors": [
825
          {
826
            "email": "[email protected]",
827
            "id": "U_kgDOCgjy1g",
828
            "login": "henke9600",
829
            "name": "Henrik Lindström"
830
          }
831
        ],
832
        "committedDate": "2024-04-28T16:12:24Z",
833
        "messageBody": "",
834
        "messageHeadline": "Make configure.sh posix compliant",
835
        "oid": "938fc2cbcace3fb1fb353a5befff1b4a81180350"
836
      }
837
    ],
838
    "createdAt": "2024-04-28T16:25:19Z",
839
    "deletions": 1,
840
    "files": [
841
      {
842
        "path": "configure.sh",
843
        "additions": 1,
844
        "deletions": 1
845
      }
846
    ],
847
    "fullDatabaseId": "1844494404",
848
    "headRefName": "master",
849
    "headRefOid": "938fc2cbcace3fb1fb353a5befff1b4a81180350",
850
    "headRepository": {
851
      "id": "R_kgDOL0az5w",
852
      "name": "bc"
853
    },
854
    "headRepositoryOwner": {
855
      "id": "U_kgDOCgjy1g",
856
      "login": "henke9600"
857
    },
858
    "id": "PR_kwDOCL0xJc5t8MBE",
859
    "isCrossRepository": true,
860
    "isDraft": false,
861
    "labels": [],
862
    "latestReviews": [],
863
    "maintainerCanModify": false,
864
    "mergeCommit": {
865
      "oid": "59cf3b86eb4cafb6d7aa164d988a8c14c287e7f8"
866
    },
867
    "mergeStateStatus": "UNKNOWN",
868
    "mergeable": "UNKNOWN",
869
    "mergedAt": "2024-04-30T01:57:03Z",
870
    "mergedBy": {
871
      "id": "MDQ6VXNlcjMxNzI2ODc=",
872
      "is_bot": false,
873
      "login": "gavinhoward",
874
      "name": "Gavin D. Howard"
875
    },
876
    "milestone": null,
877
    "number": 76,
878
    "potentialMergeCommit": null,
879
    "projectCards": [],
880
    "projectItems": [],
881
    "reactionGroups": [],
882
    "reviewDecision": "",
883
    "reviewRequests": [],
884
    "reviews": [],
885
    "state": "MERGED",
886
    "statusCheckRollup": [],
887
    "title": "Make configure.sh posix compliant",
888
    "updatedAt": "2024-04-30T01:57:41Z",
889
    "url": "https://github.com/gavinhoward/bc/pull/76"
890
  },
891
  {
892
    "additions": 1,
893
    "assignees": [],
894
    "author": {
895
      "id": "U_kgDOB2enHg",
896
      "is_bot": false,
897
      "login": "naggamura",
898
      "name": ""
899
    },
900
    "autoMergeRequest": null,
901
    "baseRefName": "master",
902
    "baseRefOid": "1a381d61b079fc3548d3e4dee3a8ccd9200a3f87",
903
    "body": "Found a printing error.\r\nTry obase=2; 2^99; 2^100; 2^105; you'll get it right away.",
904
    "changedFiles": 1,
905
    "closed": true,
906
    "closedAt": "2023-12-22T15:38:08Z",
907
    "comments": [
908
      {
909
        "id": "IC_kwDOCL0xJc5vVPQZ",
910
        "author": {
911
          "login": "gavinhoward"
912
        },
913
        "authorAssociation": "OWNER",
914
        "body": "You are correct; that is a bug.\r\n\r\nYour fix is correct; I got the condition backwards. Accepted without comment.\r\n\r\nSorry for taking so long, I struggle to read my own code; this is why I put in so many \"useless\" comments!\r\n\r\nAlso, I can think of another place that this *could have been* a problem and quickly tested it.\r\n\r\nThe problem is in printing in bases above base 16, where multiple characters may be printed for one digit.\r\n\r\nGuess what? I tested your fix after accepting it (I wanted your name in the Contributors list regardless), and your fix works for that too!\r\n\r\nTry this:\r\n\r\n```\r\n$ BC_LINE_LENGTH=77 bc\r\n>>> obase=128\r\n>>> 2^126\r\n 001 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000\r\n>>> quit\r\n```\r\n\r\nThat's what it is with the fix. Without, the bug shows:\r\n\r\n```\r\n$ BC_LINE_LENGTH=77 bc\r\n>>> obase=128\r\n>>> 2^126\r\n 001 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000 00\\\r\n0\r\n>>> quit\r\n```\r\n\r\nI checked your fix with `BC_LINE_LENGTH=78` and `BC_LINE_LENGTH=76`, and your fix properly handles both.\r\n\r\nI am confident in your fix.\r\n\r\nAnyway, I'll start my release process and put out a release with your fix ASAP.",
915
        "createdAt": "2023-12-22T15:53:14Z",
916
        "includesCreatedEdit": false,
917
        "isMinimized": false,
918
        "minimizedReason": "",
919
        "reactionGroups": [],
920
        "url": "https://github.com/gavinhoward/bc/pull/74#issuecomment-1867838489",
921
        "viewerDidAuthor": true
922
      },
923
      {
924
        "id": "IC_kwDOCL0xJc5vWpvU",
925
        "author": {
926
          "login": "naggamura"
927
        },
928
        "authorAssociation": "CONTRIBUTOR",
929
        "body": "Oh I helped... ^^; I'm happy.\r\nI'm Jonathan Kim",
930
        "createdAt": "2023-12-23T05:14:48Z",
931
        "includesCreatedEdit": false,
932
        "isMinimized": false,
933
        "minimizedReason": "",
934
        "reactionGroups": [],
935
        "url": "https://github.com/gavinhoward/bc/pull/74#issuecomment-1868209108",
936
        "viewerDidAuthor": false
937
      },
938
      {
939
        "id": "IC_kwDOCL0xJc5vWqt8",
940
        "author": {
941
          "login": "gavinhoward"
942
        },
943
        "authorAssociation": "OWNER",
944
        "body": "Yes, you did! And your fix has now passed the release process untouched.\r\n\r\nPlease don't think I'm a jerk for your previous PR; I try to not be.\r\n\r\nI just have ridiculously high standards and personal weaknesses in programming. And an eccentric style.\r\n\r\nIn fact, I [don't accept contributions at all][1] in my [next project][2]. Nothing against people, but I really struggle with patches. It's so bad that I actually can't get a programming job because of that. If you work in the industry, you're doing better than me.\r\n\r\nAnd nice to meet you. :)\r\n\r\n[1]: https://git.yzena.com/Yzena/Yc#user-content-open-source-not-open-contribution\r\n[2]: https://git.yzena.com/Yzena/Yc",
945
        "createdAt": "2023-12-23T05:37:53Z",
946
        "includesCreatedEdit": false,
947
        "isMinimized": false,
948
        "minimizedReason": "",
949
        "reactionGroups": [],
950
        "url": "https://github.com/gavinhoward/bc/pull/74#issuecomment-1868213116",
951
        "viewerDidAuthor": true
952
      }
953
    ],
954
    "commits": [
955
      {
956
        "authoredDate": "2023-12-22T13:22:27Z",
957
        "authors": [
958
          {
959
            "email": "[email protected]",
960
            "id": "U_kgDOB2enHg",
961
            "login": "naggamura",
962
            "name": "jonathan"
963
          }
964
        ],
965
        "committedDate": "2023-12-22T13:22:27Z",
966
        "messageBody": "Try obase=2; 2^105;",
967
        "messageHeadline": "Fixed printing error.",
968
        "oid": "930cb2fd56d7851ecc1af3de16b4b7357b0b5ba8"
969
      }
970
    ],
971
    "createdAt": "2023-12-22T13:25:36Z",
972
    "deletions": 1,
973
    "files": [
974
      {
975
        "path": "src/num.c",
976
        "additions": 1,
977
        "deletions": 1
978
      }
979
    ],
980
    "fullDatabaseId": "1655098845",
981
    "headRefName": "master",
982
    "headRefOid": "930cb2fd56d7851ecc1af3de16b4b7357b0b5ba8",
983
    "headRepository": null,
984
    "headRepositoryOwner": {
985
      "id": "U_kgDOB2enHg",
986
      "login": "naggamura"
987
    },
988
    "id": "PR_kwDOCL0xJc5ips3d",
989
    "isCrossRepository": true,
990
    "isDraft": false,
991
    "labels": [],
992
    "latestReviews": [],
993
    "maintainerCanModify": false,
994
    "mergeCommit": {
995
      "oid": "39bd2c5622167a3c092ca9e2c38886ff288ba508"
996
    },
997
    "mergeStateStatus": "UNKNOWN",
998
    "mergeable": "UNKNOWN",
999
    "mergedAt": "2023-12-22T15:38:08Z",
1000
    "mergedBy": {
1001
      "id": "MDQ6VXNlcjMxNzI2ODc=",
1002
      "is_bot": false,
1003
      "login": "gavinhoward",
1004
      "name": "Gavin D. Howard"
1005
    },
1006
    "milestone": null,
1007
    "number": 74,
1008
    "potentialMergeCommit": null,
1009
    "projectCards": [],
1010
    "projectItems": [],
1011
    "reactionGroups": [],
1012
    "reviewDecision": "",
1013
    "reviewRequests": [],
1014
    "reviews": [],
1015
    "state": "MERGED",
1016
    "statusCheckRollup": [],
1017
    "title": "Fixed printing error.",
1018
    "updatedAt": "2023-12-23T05:37:55Z",
1019
    "url": "https://github.com/gavinhoward/bc/pull/74"
1020
  },
1021
  {
1022
    "additions": 657,
1023
    "assignees": [],
1024
    "author": {
1025
      "id": "U_kgDOB2enHg",
1026
      "is_bot": false,
1027
      "login": "naggamura",
1028
      "name": ""
1029
    },
1030
    "autoMergeRequest": null,
1031
    "baseRefName": "master",
1032
    "baseRefOid": "fcbe9d68ccc964fda12457ebbf687a27f57ff31f",
1033
    "body": "I'm sorry I missed many things on last PR.\r\nI followed your instructions step by step.\r\n\r\nImproved SQRT needs no long division in iteration.\r\nOnly one long division is needed for compose an initial estimation.\r\n\r\nNo meaningful difference for small input.\r\n\r\nFor large input, about 2.4 times faster, no meaningful difference in memory usage.\r\n\r\nHere is the result for large input.\r\n\r\n( 'CC=clang CFLAGS=-flto ./configure -O3' is used for configuring. )\r\n[stat_c1.txt](https://github.com/gavinhoward/bc/files/13696239/stat_c1.txt)\r\n[stat_c4.txt](https://github.com/gavinhoward/bc/files/13696240/stat_c4.txt)\r\n\r\nsqrt1_large.txt : by your code.\r\nsqrt2_large.txt :  by my code.\r\n\r\n---------------------------------\r\n\r\nElapsed time for large input.\r\n\r\nx ../../sqrt1_large.txt\r\n+ ../../sqrt2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                              |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x   |\r\n| +                                                                          x  x|\r\n| ++                                                                         x xx|\r\n|+++                                                                         x xx|\r\n|+++                                                                         x xx|\r\n|+++                                                                         xxxx|\r\n|+++                                                                         xxxx|\r\n|+++                                                                      x  xxxx|\r\n|+++                                                                      x  xxxx|\r\n|+++                                                                      x  xxxx|\r\n|++++                                                                     x  xxxx|\r\n| A|                                                                        |_A| |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         87.84         91.81        90.215       90.3572     1.0769137\r\n+  50         36.96         38.71        37.805       37.8088    0.44755408\r\nDifference at 99.5% confidence\r\n        -52.5484 +/- 0.523644\r\n        -58.1563% +/- 0.315605%\r\n        (Student's t, pooled s = 0.824636)\r\n\r\n\r\n----------------------\r\n\r\n\r\nMemory for large input.\r\n\r\nx ../../sqrt1_large.txt\r\n+ ../../sqrt2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n|                  +                                                             |\r\n|                  +                                       x                     |\r\n|                  +                                       x                     |\r\n|                  +          +                        x   x                x    |\r\n|                  +     +    +                        x   x                x    |\r\n|                  +  + ++    ++                      xx x x  x    x        x    |\r\n|+              ++++ +++++ + +++                    x xx x x  x   xx      xxx  xx|\r\n|+ +            +++++++++++++++++     *    + *      x xxxxxxxxx xxxx      xxxx xx|\r\n|              |_______AM_______|                    |______M__A_________|       |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          5376          5596          5494       5508.96      51.80535\r\n+  50          5184          5412          5302       5301.12     44.115174\r\nDifference at 99.5% confidence\r\n        -207.84 +/- 30.5525\r\n        -3.77276% +/- 0.542566%\r\n        (Student's t, pooled s = 48.1141)\r\n\r\n\r\n- END -",
1034
    "changedFiles": 3,
1035
    "closed": true,
1036
    "closedAt": "2023-12-20T01:50:17Z",
1037
    "comments": [
1038
      {
1039
        "id": "IC_kwDOCL0xJc5u0b9I",
1040
        "author": {
1041
          "login": "gavinhoward"
1042
        },
1043
        "authorAssociation": "OWNER",
1044
        "body": "Unfortunately, you still did not check everything. That's probably my fault because I didn't tell you everything.\r\n\r\nNevertheless, this is what I found this time:\r\n\r\n* `CC=clang ./configure -pDBG; make`, my standard debug build, failed to build.\r\n* `CC=clang ./configure -gO0; make; make test`, a less strict debug build, failed the test suite.\r\n* `CC=clang ./configure -pGDH; make`, my standard release build for myself, failed to build.\r\n* `CC=clang ./configure -pGNU; make; make test`, the standard release build for Linux, failed the test suite.\r\n* `CC=gcc ./configure -pGNU; make; make test`, the same standard Linux build but with `gcc`, also failed the test suite.\r\n* `CC=clang ./configure -pBSD; make; make test`, the standard release build for FreeBSD and friends, failed the test suite.\r\n* `CC=gcc ./configure -pBSD; make; make test`, the same standard FreeBSD build but with `gcc`, also failed the test suite.\r\n\r\nIn addition, what failed on the test suite was off by a lot; the result I got for all cases was:\r\n\r\n```\r\nRunning bc sqrt...FAIL!!!\r\n12c12\r\n< .0000000000000035071355833500363\r\n---\r\n> .8915580480000035071355833500363\r\nbc failed test sqrt\r\n```\r\n\r\nAs you can see, the numbers are the same, except at the beginning, which means that answer was about as far off as it could be.\r\n\r\nIn addition, when I ran this:\r\n\r\n```\r\n$ ./configure -gO0 -v\r\n$ make\r\n$ make test\r\n```\r\n\r\nwhich is a Valgrind-enabled build, I got this:\r\n\r\n```\r\nRunning bc sqrt...==47836== Memcheck, a memory error detector\r\n==47836== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.\r\n==47836== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info\r\n==47836== Command: bin/bc -lqc ./tests/bc/sqrt.txt\r\n==47836==\r\n==47836== Invalid write of size 8\r\n==47836==    at 0x484C96E: memset (vg_replace_strmem.c:1386)\r\n==47836==    by 0x12A28F: bc_int_elementary_mul (num.c:4274)\r\n==47836==    by 0x1253AA: bc_int_k_mul (num.c:4327)\r\n==47836==    by 0x124972: bc_num_sqrt (num.c:4636)\r\n==47836==    by 0x13156F: bc_program_builtin (program.c:1990)\r\n==47836==    by 0x12DB0C: bc_program_exec (program.c:3332)\r\n==47836==    by 0x13D623: bc_vm_process (vm.c:1046)\r\n==47836==    by 0x13CCA5: bc_vm_file (vm.c:1103)\r\n==47836==    by 0x13C117: bc_vm_exec (vm.c:1498)\r\n==47836==    by 0x13B4E1: bc_vm_boot (vm.c:1718)\r\n==47836==    by 0x10C0CC: bc_main (bc.c:62)\r\n==47836==    by 0x119995: main (main.c:108)\r\n==47836==  Address 0x4aa2270 is 32 bytes inside a block of size 36 alloc'd\r\n==47836==    at 0x4840784: malloc (vg_replace_malloc.c:442)\r\n==47836==    by 0x13A4C3: bc_vm_malloc (vm.c:810)\r\n==47836==    by 0x11BA76: bc_num_init (num.c:3368)\r\n==47836==    by 0x1244B1: bc_num_sqrt (num.c:4567)\r\n==47836==    by 0x13156F: bc_program_builtin (program.c:1990)\r\n==47836==    by 0x12DB0C: bc_program_exec (program.c:3332)\r\n==47836==    by 0x13D623: bc_vm_process (vm.c:1046)\r\n==47836==    by 0x13CCA5: bc_vm_file (vm.c:1103)\r\n==47836==    by 0x13C117: bc_vm_exec (vm.c:1498)\r\n==47836==    by 0x13B4E1: bc_vm_boot (vm.c:1718)\r\n==47836==    by 0x10C0CC: bc_main (bc.c:62)\r\n==47836==    by 0x119995: main (main.c:108)\r\n==47836==\r\n==47836==\r\n==47836== HEAP SUMMARY:\r\n==47836==     in use at exit: 0 bytes in 0 blocks\r\n==47836==   total heap usage: 1,633 allocs, 1,633 frees, 331,419 bytes allocated\r\n==47836==\r\n==47836== All heap blocks were freed -- no leaks are possible\r\n==47836==\r\n==47836== For lists of detected and suppressed errors, rerun with: -s\r\n==47836== ERROR SUMMARY: 8 errors from 1 contexts (suppressed: 0 from 0)\r\nFAIL!!!\r\nbc failed test 'sqrt' with error code 100\r\n```\r\n\r\nThat needs to be fixed, both the out-of-bounds write and the unaligned write.\r\n\r\nIf you're wondering how much testing I do, do this:\r\n\r\n* Create two clones of your branch in separate directories, which I will call `bc1/` and `bc2/`.\r\n* In `bc1/`, run `scripts/release.sh 1 1 1 1 0 1 0 0 1 0 1 0 1 0 0 1 1`.\r\n* In `bc2/`, run `scripts/release.sh 1 1 1 0 1 0 1 0 1 0 1 0 0 1 1 1 1`.\r\n* Run them both in separate terminals and at the same time.\r\n* Leave it overnight.\r\n\r\nYep, you heard that last bit right: my full test run is an overnight thing. And I run both because one does `clang`, and one does `gcc`.\r\n\r\nMoving on to benchmarks, I ran\r\n\r\n```\r\n$ CC=clang CFLAGS=-flto ./configure -O3\r\n$ make\r\n```\r\n\r\nin both branches. Then I ran\r\n\r\n```\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_small > ../sqrt2_small.txt\r\n```\r\n\r\nin your branch, copied `benchmarks/bc/newton_raphson_sqrt_small.txt` to my branch and ran\r\n\r\n```\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_small > ../sqrt1_small.txt\r\n```\r\n\r\nThese are my results:\r\n\r\n```\r\n$ ./scripts/ministat -w 80 -c99.5 -C1 ../sqrt1_small.txt ../sqrt2_small.txt\r\nx ../sqrt1_small.txt\r\n+ ../sqrt2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n|                       +                           x                            |\r\n|                       +                           x    x                       |\r\n|                       +                           x    x                       |\r\n|                 +     +    +                      x    x                       |\r\n|                 +     +    +                      x    x     x                 |\r\n|           +     +     +    +                      x    x     x                 |\r\n|           +     +     +    +                      x    x     x                 |\r\n|           +     +     +    +                      x    x     x                 |\r\n|           +     +     +    +                      x    x     x                 |\r\n|           +     +     +    +     +          x     x    x     x     x    x      |\r\n|      +    +     +     +    +     +     x    x     x    x     x     x    x      |\r\n|      +    +     +     +    +     +     x    x     x    x     x     x    x      |\r\n|+     +    +     +     +    +     +     *    x     x    x     x     x    x     x|\r\n|            |________A_M_____|                 |________MA________|             |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          1.45          1.52          1.48        1.4806   0.016463937\r\n+  50          1.38          1.45          1.42        1.4164   0.015220824\r\nDifference at 99.5% confidence\r\n        -0.0642 +/- 0.0100677\r\n        -4.33608% +/- 0.664237%\r\n        (Student's t, pooled s = 0.0158546)\r\n$ ./scripts/ministat -w 80 -c99.5 -C4 ../sqrt1_small.txt ../sqrt2_small.txt\r\nx ../sqrt1_small.txt\r\n+ ../sqrt2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n|                                                              +                 |\r\n|                                                              +                 |\r\n|                                        x                     +                 |\r\n|                          x             x                     +                 |\r\n|                          x             x         +           +                 |\r\n|                          x             x      +x +     +     +                 |\r\n|                          x         +  xx      +x +  x  +     +                 |\r\n|                          x         *+ xx      *x++  xx +  +  +                 |\r\n|                          xx       +*+xxxx    x**++  xx +  +  +                 |\r\n|x                      x  xx       +*+xxxx   x***++xx*x+++++  +               ++|\r\n|                             |__________A_|_______M|A_________|                 |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         18956         19244         19168      19168.16     57.880722\r\n+  50         19144         19376         19224      19232.88      54.73373\r\nDifference at 99.5% confidence\r\n        64.72 +/- 35.769\r\n        0.337643% +/- 0.186939%\r\n        (Student's t, pooled s = 56.3292)\r\n```\r\n\r\nYours was slightly faster and used slightly more memory.\r\n\r\nI ran the same benchmark for large, but only for one sample each, and my numbers say that yours are accurate for that benchmark.\r\n\r\nHowever, I cannot accept code that fails tests or has memory bugs. In addition, because of the test failures, you can expect that I will run a lot more tests on your code before I accept.\r\n\r\nSo I won't close this PR, but you need to fix the problems above (by running that `release.sh` script both ways and fixing every problem) before I'll look at it again.\r\n\r\nAlso, I can't understand `sqrt_2.png`. I can follow `sqrt_1.png`, but I need you to redo `sqrt_2.png` because I also won't accept the code if I don't understand it.",
1045
        "createdAt": "2023-12-17T18:09:30Z",
1046
        "includesCreatedEdit": false,
1047
        "isMinimized": false,
1048
        "minimizedReason": "",
1049
        "reactionGroups": [],
1050
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1859239752",
1051
        "viewerDidAuthor": true
1052
      },
1053
      {
1054
        "id": "IC_kwDOCL0xJc5u10BR",
1055
        "author": {
1056
          "login": "naggamura"
1057
        },
1058
        "authorAssociation": "CONTRIBUTOR",
1059
        "body": "BcNum.len is managed as tight as possible. So clearing upper digits is needed for like sqrt(0.000...000xyz...)  \r\nPassed 'make test'\r\n---",
1060
        "createdAt": "2023-12-18T05:52:00Z",
1061
        "includesCreatedEdit": false,
1062
        "isMinimized": false,
1063
        "minimizedReason": "",
1064
        "reactionGroups": [],
1065
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1859600465",
1066
        "viewerDidAuthor": false
1067
      },
1068
      {
1069
        "id": "IC_kwDOCL0xJc5u12rZ",
1070
        "author": {
1071
          "login": "naggamura"
1072
        },
1073
        "authorAssociation": "CONTRIBUTOR",
1074
        "body": "Last push was not the latest version. Pushed again.\r\n\r\nAnyway, test again and passed all tests.\r\n\r\n...\r\n==5965== \r\n==5965== HEAP SUMMARY:\r\n==5965==     in use at exit: 0 bytes in 0 blocks\r\n==5965==   total heap usage: 1,520 allocs, 1,520 frees, 205,685 bytes allocated\r\n==5965== \r\n==5965== All heap blocks were freed -- no leaks are possible\r\n==5965== \r\n==5965== For counts of detected and suppressed errors, rerun with: -v\r\n==5965== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)\r\npass\r\nRunning bc directory test...pass\r\nRunning bc binary file test...pass\r\nRunning bc binary stdin test...pass\r\nRunning bc limits tests...pass\r\n\r\nAll bc tests passed.\r\n\r\n...\r\n...\r\n\r\n==6927== \r\n==6927== HEAP SUMMARY:\r\n==6927==     in use at exit: 0 bytes in 0 blocks\r\n==6927==   total heap usage: 73 allocs, 73 frees, 37,886 bytes allocated\r\n==6927== \r\n==6927== All heap blocks were freed -- no leaks are possible\r\n==6927== \r\n==6927== For counts of detected and suppressed errors, rerun with: -v\r\n==6927== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)\r\npass\r\nRunning dc directory test...pass\r\nRunning dc binary file test...pass\r\nRunning dc binary stdin test...pass\r\n\r\nAll dc tests passed.\r\n\r\n***********************************************************************\r\n\r\n----",
1075
        "createdAt": "2023-12-18T06:05:29Z",
1076
        "includesCreatedEdit": true,
1077
        "isMinimized": false,
1078
        "minimizedReason": "",
1079
        "reactionGroups": [],
1080
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1859611353",
1081
        "viewerDidAuthor": false
1082
      },
1083
      {
1084
        "id": "IC_kwDOCL0xJc5u3LdX",
1085
        "author": {
1086
          "login": "naggamura"
1087
        },
1088
        "authorAssociation": "CONTRIBUTOR",
1089
        "body": "Doing scripts/release.sh test...",
1090
        "createdAt": "2023-12-18T09:47:53Z",
1091
        "includesCreatedEdit": false,
1092
        "isMinimized": false,
1093
        "minimizedReason": "",
1094
        "reactionGroups": [],
1095
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1859958615",
1096
        "viewerDidAuthor": false
1097
      },
1098
      {
1099
        "id": "IC_kwDOCL0xJc5u_Gjj",
1100
        "author": {
1101
          "login": "naggamura"
1102
        },
1103
        "authorAssociation": "CONTRIBUTOR",
1104
        "body": "Passed the tests.\r\n\r\nBenchmarks\r\n\r\n[stat_small_c1.txt](https://github.com/gavinhoward/bc/files/13712108/stat_small_c1.txt)\r\n[stat_small_c4.txt](https://github.com/gavinhoward/bc/files/13712109/stat_small_c4.txt)\r\n[stat_large_c1.txt](https://github.com/gavinhoward/bc/files/13712110/stat_large_c1.txt)\r\n[stat_large_c4.txt](https://github.com/gavinhoward/bc/files/13712111/stat_large_c4.txt)\r\n",
1105
        "createdAt": "2023-12-19T03:09:54Z",
1106
        "includesCreatedEdit": true,
1107
        "isMinimized": false,
1108
        "minimizedReason": "",
1109
        "reactionGroups": [],
1110
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1862035683",
1111
        "viewerDidAuthor": false
1112
      },
1113
      {
1114
        "id": "IC_kwDOCL0xJc5vCDYq",
1115
        "author": {
1116
          "login": "naggamura"
1117
        },
1118
        "authorAssociation": "CONTRIBUTOR",
1119
        "body": "sqrt_2.png updated.",
1120
        "createdAt": "2023-12-19T13:58:49Z",
1121
        "includesCreatedEdit": false,
1122
        "isMinimized": false,
1123
        "minimizedReason": "",
1124
        "reactionGroups": [],
1125
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1862809130",
1126
        "viewerDidAuthor": false
1127
      },
1128
      {
1129
        "id": "IC_kwDOCL0xJc5vFhZX",
1130
        "author": {
1131
          "login": "gavinhoward"
1132
        },
1133
        "authorAssociation": "OWNER",
1134
        "body": "I have spent two full days on this since the last time I sent a message. I cannot spend any more time on this; I have a project to finish and a hard deadline.\r\n\r\nSo I have to make a final decision, which is to reject this. Thank you for your contribution, but I guess I don't want it.\r\n\r\nThere are several reasons why:\r\n\r\n* Your code still contains debug code.\r\n* You created your own functions to do things when functions to do those things already exist, which shows lack of research again. And duplication.\r\n* Your proof looks wrong to me, or I still can't understand it.\r\n* Your code passes the test suite, but it did not pass another set of tests I threw at it.\r\n* This is purely a performance PR, which is not really important to me right now.\r\n\r\nBut most of all, and this is nothing against you, I just can't read other people's code. I am unable to build a theory of mind, and this extends to reading code written by other people.\r\n\r\nThere is a reason I tend to do things by myself; I can't work on the code otherwise.\r\n\r\nSo I'm afraid I have run out of time and desire. Sorry.",
1135
        "createdAt": "2023-12-20T01:50:17Z",
1136
        "includesCreatedEdit": false,
1137
        "isMinimized": false,
1138
        "minimizedReason": "",
1139
        "reactionGroups": [],
1140
        "url": "https://github.com/gavinhoward/bc/pull/73#issuecomment-1863718487",
1141
        "viewerDidAuthor": true
1142
      }
1143
    ],
1144
    "commits": [
1145
      {
1146
        "authoredDate": "2023-12-17T12:30:19Z",
1147
        "authors": [
1148
          {
1149
            "email": "[email protected]",
1150
            "id": "U_kgDOB2enHg",
1151
            "login": "naggamura",
1152
            "name": "jonathan"
1153
          }
1154
        ],
1155
        "committedDate": "2023-12-17T12:30:19Z",
1156
        "messageBody": "",
1157
        "messageHeadline": "New bc_num_sqrt function needs only one long division.",
1158
        "oid": "a8821844d9f05df15fde8bed92332226e147b151"
1159
      },
1160
      {
1161
        "authoredDate": "2023-12-18T02:46:18Z",
1162
        "authors": [
1163
          {
1164
            "email": "[email protected]",
1165
            "id": "U_kgDOB2enHg",
1166
            "login": "naggamura",
1167
            "name": "jonathan"
1168
          }
1169
        ],
1170
        "committedDate": "2023-12-18T02:46:18Z",
1171
        "messageBody": "Passed 'sqrt test'",
1172
        "messageHeadline": "SQRT fix: post process for numbers like 0.000000...000000xyz...",
1173
        "oid": "a4e27bb46a0fc9dc59e51ba5de153b6f2fe55f5d"
1174
      },
1175
      {
1176
        "authoredDate": "2023-12-18T05:46:38Z",
1177
        "authors": [
1178
          {
1179
            "email": "[email protected]",
1180
            "id": "U_kgDOB2enHg",
1181
            "login": "naggamura",
1182
            "name": "jonathan"
1183
          }
1184
        ],
1185
        "committedDate": "2023-12-18T05:46:38Z",
1186
        "messageBody": "",
1187
        "messageHeadline": "SQRT: fixed memory bug. passed 'make test'",
1188
        "oid": "f4f8cf72d513f2986bb477d10bcd0fcb520a0e7e"
1189
      },
1190
      {
1191
        "authoredDate": "2023-12-18T06:01:30Z",
1192
        "authors": [
1193
          {
1194
            "email": "[email protected]",
1195
            "id": "U_kgDOB2enHg",
1196
            "login": "naggamura",
1197
            "name": "jonathan"
1198
          }
1199
        ],
1200
        "committedDate": "2023-12-18T06:01:30Z",
1201
        "messageBody": "",
1202
        "messageHeadline": "Commit missed!!! fix again.",
1203
        "oid": "1faa1296390f5e689d78c28fa9b434516f47c15d"
1204
      },
1205
      {
1206
        "authoredDate": "2023-12-18T09:22:18Z",
1207
        "authors": [
1208
          {
1209
            "email": "[email protected]",
1210
            "id": "U_kgDOB2enHg",
1211
            "login": "naggamura",
1212
            "name": "jonathan"
1213
          }
1214
        ],
1215
        "committedDate": "2023-12-18T09:22:18Z",
1216
        "messageBody": "…r running release.sh",
1217
        "messageHeadline": "Removed unused variables, explicit type conversion in assignments, fo…",
1218
        "oid": "fb9d7b88c60ecdb7ce8bdfe8a11e23d09b2342fb"
1219
      },
1220
      {
1221
        "authoredDate": "2023-12-18T13:17:09Z",
1222
        "authors": [
1223
          {
1224
            "email": "[email protected]",
1225
            "id": "U_kgDOB2enHg",
1226
            "login": "naggamura",
1227
            "name": "jonathan"
1228
          }
1229
        ],
1230
        "committedDate": "2023-12-18T13:17:09Z",
1231
        "messageBody": "…unning release.sh.\n\nRunning release.sh for this commit now...",
1232
        "messageHeadline": "Fixed memory warning(passing NULL with zero length to memcpy) while r…",
1233
        "oid": "9f171378fe38619d032107d388eef06519dde4a7"
1234
      },
1235
      {
1236
        "authoredDate": "2023-12-19T03:08:34Z",
1237
        "authors": [
1238
          {
1239
            "email": "[email protected]",
1240
            "id": "U_kgDOB2enHg",
1241
            "login": "naggamura",
1242
            "name": "jonathan"
1243
          }
1244
        ],
1245
        "committedDate": "2023-12-19T03:08:34Z",
1246
        "messageBody": "…old one!)\n\n2. Passed Valgrind memory test.\n./configure -gO0 -v\nmake\nmake test\n\n3. Passed\nscripts/release.sh 1 1 1 0 1 0 1 0 1 0 1 0 0 1 1 1 1\non Ubuntu 18.04.2 LTS",
1247
        "messageHeadline": "1. Simple multiplication modified based on Gavin's (much better than …",
1248
        "oid": "2b3616586454f315a5014360f7f7d5d36f10bd9a"
1249
      },
1250
      {
1251
        "authoredDate": "2023-12-19T13:57:21Z",
1252
        "authors": [
1253
          {
1254
            "email": "[email protected]",
1255
            "id": "U_kgDOB2enHg",
1256
            "login": "naggamura",
1257
            "name": "jonathan"
1258
          }
1259
        ],
1260
        "committedDate": "2023-12-19T13:57:21Z",
1261
        "messageBody": "",
1262
        "messageHeadline": "Proof related to sqrt approximation updated.",
1263
        "oid": "2d7b8fe4efe528076a568b0f174c35a53e47ae93"
1264
      }
1265
    ],
1266
    "createdAt": "2023-12-17T13:16:03Z",
1267
    "deletions": 72,
1268
    "files": [
1269
      {
1270
        "path": "sqrt_1.png",
1271
        "additions": 0,
1272
        "deletions": 0
1273
      },
1274
      {
1275
        "path": "sqrt_2.png",
1276
        "additions": 0,
1277
        "deletions": 0
1278
      },
1279
      {
1280
        "path": "src/num.c",
1281
        "additions": 657,
1282
        "deletions": 72
1283
      }
1284
    ],
1285
    "fullDatabaseId": "1647316989",
1286
    "headRefName": "master",
1287
    "headRefOid": "2d7b8fe4efe528076a568b0f174c35a53e47ae93",
1288
    "headRepository": null,
1289
    "headRepositoryOwner": {
1290
      "id": "U_kgDOB2enHg",
1291
      "login": "naggamura"
1292
    },
1293
    "id": "PR_kwDOCL0xJc5iMA_9",
1294
    "isCrossRepository": true,
1295
    "isDraft": false,
1296
    "labels": [],
1297
    "latestReviews": [],
1298
    "maintainerCanModify": false,
1299
    "mergeCommit": null,
1300
    "mergeStateStatus": "UNKNOWN",
1301
    "mergeable": "UNKNOWN",
1302
    "mergedAt": null,
1303
    "mergedBy": null,
1304
    "milestone": null,
1305
    "number": 73,
1306
    "potentialMergeCommit": null,
1307
    "projectCards": [],
1308
    "projectItems": [],
1309
    "reactionGroups": [],
1310
    "reviewDecision": "",
1311
    "reviewRequests": [],
1312
    "reviews": [],
1313
    "state": "CLOSED",
1314
    "statusCheckRollup": [],
1315
    "title": "New bc_num_sqrt function needs only one long division.",
1316
    "updatedAt": "2023-12-20T01:50:17Z",
1317
    "url": "https://github.com/gavinhoward/bc/pull/73"
1318
  },
1319
  {
1320
    "additions": 831,
1321
    "assignees": [],
1322
    "author": {
1323
      "id": "U_kgDOB2enHg",
1324
      "is_bot": false,
1325
      "login": "naggamura",
1326
      "name": ""
1327
    },
1328
    "autoMergeRequest": null,
1329
    "baseRefName": "master",
1330
    "baseRefOid": "5ee6a05918bd8341a7ed97d6594862ad5d713557",
1331
    "body": "Newton-Raphson approximation is applied to division and sqrt.\r\nTry 5^1000000 / 2^1000000 and sort(5^999999)\r\n",
1332
    "changedFiles": 3,
1333
    "closed": true,
1334
    "closedAt": "2023-12-14T04:47:11Z",
1335
    "comments": [
1336
      {
1337
        "id": "IC_kwDOCL0xJc5uku2Q",
1338
        "author": {
1339
          "login": "gavinhoward"
1340
        },
1341
        "authorAssociation": "OWNER",
1342
        "body": "Thank you for your PR. I have some comments.\r\n\r\n* If you run `CC=clang ./configure.sh -pDBG; make`, my regular debug build, the build fails.\r\n* If you run `CC=clang ./configure.sh -pGDH; make`, my regular release build, the build fails.\r\n* If you run `CC=gcc CFLAGS=\"-pedantic -Wextra -Werror\" ./configure -O3; make`, the build fails.\r\n* If you run `CC=clang ./configure -gO3; make; make test`, a release build with debug information, the build succeeds, but the test suite fails on an assert.\r\n* You have functions that have reserved names (names that begin with an underscore); using those names is undefined behavior.\r\n* You did not follow my style even though there is a script (`scripts/format.sh`) that will style the code for you.\r\n\r\nIn addition, I can unfortunately tell that you did no research into my `bc`. If you had, you would know that [I already use Newton-Raphson for `sqrt()`][1].\r\n\r\nHowever, all of that could be safely discarded if the code shows promise. So I wrote [benchmarks to test your new code][2].\r\n\r\nI ran these commands with my code:\r\n\r\n```\r\n$ CC=clang CFLAGS=-flto ./configure -O3\r\n$ make\r\n```\r\n\r\nThen I ran the benchmarks as follows:\r\n\r\n```\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_div_small > ../div1_small.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_div_large > ../div1_large.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_small > ../sqrt1_small.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_large > ../sqrt1_large.txt\r\n```\r\n\r\nThen I repeated the steps with your code:\r\n\r\n```\r\n$ CC=clang CFLAGS=-flto ./configure -O3\r\n$ make\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_div_small > ../div2_small.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_div_large > ../div2_large.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_small > ../sqrt2_small.txt\r\n$ ./scripts/benchmark.sh -p1 -n50 bc newton_raphson_sqrt_large > ../sqrt2_large.txt\r\n```\r\n\r\nThe `small` benchmarks test the operation on \"small\" numbers (below `2^64`), and the `large` benchmarks test the operation on large numbers (a small number to a power up to 1,000,000).\r\n\r\nTo test how your code did, I used `ministat` in the repo, so I ran this:\r\n\r\n```\r\n$ make ministat\r\n```\r\n\r\nThen to test the time difference on `div_small`, I ran the following:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c95 -C1 ../div1_small.txt ../div2_small.txt\r\nx ../div1_small.txt\r\n+ ../div2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n|       +  x                                                                     |\r\n|   +   +  x  *                                                                  |\r\n|   +   +  *  *  x                                                               |\r\n|   +   *  *  *  x                                                               |\r\n|   +   *  *  *  x                                                               |\r\n|   +   *  *  *  x                                                               |\r\n|   *   *  *  *  x     +                                                         |\r\n|   *   *  *  *  *  x  +     x                                                   |\r\n|*  *   *  *  *  *  x  *  +  x                                                   |\r\n|*  *   *  *  *  *  *  *  *  x     x  +                                         +|\r\n||____|____M_AA______|___|                                                       |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          3.41          3.52          3.45        3.4504   0.024071323\r\n+  50          3.41          3.67          3.44        3.4484   0.039967334\r\nNo difference proven at 95.0% confidence\r\n```\r\n\r\nAs you can tell, there's no difference at the lowest confidence I can accept.\r\n\r\nTo test the memory difference (max RSS) for `div_small`, I ran the following:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c95 -C4 ../div1_small.txt ../div2_small.txt\r\nx ../div1_small.txt\r\n+ ../div2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n|   x                    x  x+  +   +   x       +xx xx  ++                       |\r\n| x x   +          x     *  x+ +++ ++   x  x *+ +xx xx  ++  +            x     + |\r\n|xx x  +++ +     + x    x*x x* *++ ++ x x +x ** +** ** x++ +* +x      + +xx    ++|\r\n|                 |_____|_____________A____A_M___________|___|                   |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         34792         35000         34912      34896.88     55.262136\r\n+  50         34808         35016         34916         34910     52.956663\r\nNo difference proven at 95.0% confidence\r\n```\r\n\r\nNo memory difference. Cool.\r\n\r\nFor the elapsed time for `div_large`:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C1 ../div1_large.txt ../div2_large.txt\r\nx ../div1_large.txt\r\n+ ../div2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n|     x                                                                      +   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     x                                                                     ++   |\r\n|     xx                                                                    ++   |\r\n|     xx                                                                    ++   |\r\n|     xx                                                                    ++   |\r\n|     xx                                                                    ++   |\r\n|     xx                                                                    ++   |\r\n|     xx                                                                    +++  |\r\n|     xx                                                                   ++++  |\r\n|     xx                                                                   ++++  |\r\n|    xxx                                                                   ++++  |\r\n|    xxx                                        x                          ++++++|\r\n||____MA_____|                                                              |A|  |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         13.72         21.71        13.845        14.013     1.1141964\r\n+  50          26.7         27.64        27.005       27.0158    0.17722452\r\nDifference at 99.5% confidence\r\n        13.0028 +/- 0.506578\r\n        92.791% +/- 6.90636%\r\n        (Student's t, pooled s = 0.79776)\r\n```\r\n\r\nAs you can see, there *is* a difference, with *99.5% confidence*, but in favor of the *old code*. In fact, if not for the one outlier, your code would be twice as slow.\r\n\r\nAnd if we look at the max RSS difference for `div_large`:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C4 ../div1_large.txt ../div2_large.txt\r\nx ../div1_large.txt\r\n+ ../div2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n|                                                                              + |\r\n|                                                                              + |\r\n|                                                                              + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| xx                                                                           + |\r\n| xx                                                                           ++|\r\n| xx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx                                                                          +++|\r\n|xxx x                                                                        +++|\r\n|xxxxx                                                                        +++|\r\n||A|                                                                          |A||\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          8716          8968          8796       8802.72     57.549638\r\n+  50         13812         13960         13888      13890.08     41.837314\r\nDifference at 99.5% confidence\r\n        5087.36 +/- 31.9473\r\n        57.793% +/- 0.51%\r\n        (Student's t, pooled s = 50.3106)\r\n```\r\n\r\nYour code uses 50% more memory, with 99.5% confidence.\r\n\r\nMoving onto `sqrt_small`, for elapsed time, I got this:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C1 ../sqrt1_small.txt ../sqrt2_small.txt\r\nx ../sqrt1_small.txt\r\n+ ../sqrt2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n| x                                                                        +     |\r\n| xx                                                                       +     |\r\n| xx                                                                       +     |\r\n| xx                                                                       +     |\r\n| xx                                                                     + +     |\r\n| xx                                                                     ++++    |\r\n| xx                                                                     ++++    |\r\n|xxx                                                                     ++++    |\r\n|xxx                                                                     ++++    |\r\n|xxxx                                                                    +++++   |\r\n|xxxx                                                                    +++++   |\r\n|xxxx                                                                    +++++   |\r\n|xxxxx                                                                   +++++   |\r\n|xxxxx x                                                                +++++++ +|\r\n| MA|                                                                    |_A_|   |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          1.47           1.6           1.5        1.5072   0.023822473\r\n+  50          3.07          3.26          3.14        3.1452   0.036153866\r\nDifference at 99.5% confidence\r\n        1.638 +/- 0.0194408\r\n        108.678% +/- 1.83123%\r\n        (Student's t, pooled s = 0.0306155)\r\n```\r\n\r\nYour code is twice as slow with 99.5% confidence.\r\n\r\nFor memory on `sqrt_small`, I got this:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C4 ../sqrt1_small.txt ../sqrt2_small.txt\r\nx ../sqrt1_small.txt\r\n+ ../sqrt2_small.txt\r\n+--------------------------------------------------------------------------------+\r\n|                                            xx    +   x                         |\r\n|                                          x xx    + x x        ++               |\r\n|                              x x         x xx  + + x x        ++               |\r\n|               x             xxxx         x xxx++ + x x  +x x +++      ++    +  |\r\n|xx      +      x x    +   + xxxxx +  + +* *xx***+++ x+xx++***++++    ++++   ++++|\r\n|                           |_____________|__M__________|A_M____________|        |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         18964         19252         19176       19160.4     68.353224\r\n+  50         19004         19344         19242      19231.68     71.990203\r\nDifference at 99.5% confidence\r\n        71.28 +/- 44.574\r\n        0.372017% +/- 0.233047%\r\n        (Student's t, pooled s = 70.1953)\r\n```\r\n\r\nSo there's a small increase of memory in your code, even at 99.5% confidence, but that's small enough that I can ignore it.\r\n\r\nFor time on `sqrt_large`, I got this:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C1 ../sqrt1_large.txt ../sqrt2_large.txt\r\nx ../sqrt1_large.txt\r\n+ ../sqrt2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n| xx                                                                       +     |\r\n| xx                                                                       ++    |\r\n| xx                                                                       +++   |\r\n| xx                                                                       +++   |\r\n| xx                                                                       +++   |\r\n| xx                                                                       +++   |\r\n| xx                                                                      ++++   |\r\n| xx                                                                      ++++   |\r\n| xxx                                                                     +++++  |\r\n|xxxx                                                                     +++++  |\r\n|xxxx                                                                     +++++  |\r\n|xxxx                                                                     +++++  |\r\n|xxxxx                                                                    +++++++|\r\n| |A|                                                                      |A_|  |\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50         176.9        184.63       180.565       180.403     1.6383681\r\n+  50        327.42        339.26        331.24      331.3832     2.8256482\r\nDifference at 99.5% confidence\r\n        150.98 +/- 1.4666\r\n        83.6905% +/- 1.02747%\r\n        (Student's t, pooled s = 2.3096)\r\n```\r\n\r\nYour code is *almost* twice as slow at 99.5% confidence.\r\n\r\nFor memory on `sqrt_large`, I got this:\r\n\r\n```\r\n$ ./scripts/ministat -w80 -c99.5 -C4 ../sqrt1_large.txt ../sqrt2_large.txt\r\nx ../sqrt1_large.txt\r\n+ ../sqrt2_large.txt\r\n+--------------------------------------------------------------------------------+\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            + |\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n| x                                                                            ++|\r\n|xx                                                                            ++|\r\n|xx                                                                            ++|\r\n|xx                                                                            ++|\r\n|xx                                                                            ++|\r\n|xx                                                                            ++|\r\n|xxx                                                                           ++|\r\n|xxx                                                                           ++|\r\n||A                                                                            A||\r\n+--------------------------------------------------------------------------------+\r\n    N           Min           Max        Median           Avg        Stddev\r\nx  50          6952          7156          7044       7046.48     42.561955\r\n+  50         15412         15568         15496      15485.84     51.175313\r\nDifference at 99.5% confidence\r\n        8439.36 +/- 29.887\r\n        119.767% +/- 0.679408%\r\n        (Student's t, pooled s = 47.0661)\r\n```\r\n\r\nYour code uses twice as much memory at 99.5% confidence.\r\n\r\nSo on average, your code is twice as slow and uses more memory.\r\n\r\nUnfortunately, based on the poor performance of your code compared to what already exists, I can't say that it shows promise.\r\n\r\nCombined with the problems I mentioned at the beginning, I'm afraid I must reject this PR completely. Sorry.\r\n\r\n[1]: https://github.com/gavinhoward/bc/blob/master/manuals/algorithms.md#square-root\r\n[2]: https://github.com/gavinhoward/bc/commit/fcbe9d68ccc964fda12457ebbf687a27f57ff31f",
1343
        "createdAt": "2023-12-14T04:47:11Z",
1344
        "includesCreatedEdit": false,
1345
        "isMinimized": false,
1346
        "minimizedReason": "",
1347
        "reactionGroups": [
1348
          {
1349
            "content": "THUMBS_UP",
1350
            "users": {
1351
              "totalCount": 1
1352
            }
1353
          },
1354
          {
1355
            "content": "EYES",
1356
            "users": {
1357
              "totalCount": 1
1358
            }
1359
          }
1360
        ],
1361
        "url": "https://github.com/gavinhoward/bc/pull/72#issuecomment-1855122832",
1362
        "viewerDidAuthor": true
1363
      }
1364
    ],
1365
    "commits": [
1366
      {
1367
        "authoredDate": "2023-12-11T20:27:06Z",
1368
        "authors": [
1369
          {
1370
            "email": "[email protected]",
1371
            "id": "U_kgDOB2enHg",
1372
            "login": "naggamura",
1373
            "name": "jonathan"
1374
          }
1375
        ],
1376
        "committedDate": "2023-12-11T20:27:06Z",
1377
        "messageBody": "",
1378
        "messageHeadline": "div, sqrt improved using Newton-Raphson algorithm.",
1379
        "oid": "d6e0849220eea59ff7b380dfc779a43a33a234d1"
1380
      },
1381
      {
1382
        "authoredDate": "2023-12-12T11:49:47Z",
1383
        "authors": [
1384
          {
1385
            "email": "[email protected]",
1386
            "id": "U_kgDOB2enHg",
1387
            "login": "naggamura",
1388
            "name": "jonathan"
1389
          }
1390
        ],
1391
        "committedDate": "2023-12-12T11:49:47Z",
1392
        "messageBody": "",
1393
        "messageHeadline": "Make secure more",
1394
        "oid": "7a1cd5f7667308300e7f9db46b1827fbc1dc2703"
1395
      },
1396
      {
1397
        "authoredDate": "2023-12-13T13:53:11Z",
1398
        "authors": [
1399
          {
1400
            "email": "[email protected]",
1401
            "id": "U_kgDOB2enHg",
1402
            "login": "naggamura",
1403
            "name": "jonathan"
1404
          }
1405
        ],
1406
        "committedDate": "2023-12-13T13:53:11Z",
1407
        "messageBody": "",
1408
        "messageHeadline": "markdown test",
1409
        "oid": "1f0cce37b56205fbc24db847d184ce452bfdb8fa"
1410
      },
1411
      {
1412
        "authoredDate": "2023-12-13T16:30:08Z",
1413
        "authors": [
1414
          {
1415
            "email": "[email protected]",
1416
            "id": "U_kgDOB2enHg",
1417
            "login": "naggamura",
1418
            "name": "jonathan"
1419
          }
1420
        ],
1421
        "committedDate": "2023-12-13T16:30:08Z",
1422
        "messageBody": "",
1423
        "messageHeadline": "Newton-Raphson div, sqrt",
1424
        "oid": "248e3b9b34cf4893f6440c169584592fc78f6090"
1425
      }
1426
    ],
1427
    "createdAt": "2023-12-13T16:38:28Z",
1428
    "deletions": 50,
1429
    "files": [
1430
      {
1431
        "path": "newton-raphson-div.png",
1432
        "additions": 0,
1433
        "deletions": 0
1434
      },
1435
      {
1436
        "path": "newton-raphson-sqrt.png",
1437
        "additions": 0,
1438
        "deletions": 0
1439
      },
1440
      {
1441
        "path": "src/num.c",
1442
        "additions": 831,
1443
        "deletions": 50
1444
      }
1445
    ],
1446
    "fullDatabaseId": "1642781993",
1447
    "headRefName": "newton-raphson",
1448
    "headRefOid": "248e3b9b34cf4893f6440c169584592fc78f6090",
1449
    "headRepository": null,
1450
    "headRepositoryOwner": {
1451
      "id": "U_kgDOB2enHg",
1452
      "login": "naggamura"
1453
    },
1454
    "id": "PR_kwDOCL0xJc5h6t0p",
1455
    "isCrossRepository": true,
1456
    "isDraft": false,
1457
    "labels": [],
1458
    "latestReviews": [],
1459
    "maintainerCanModify": false,
1460
    "mergeCommit": null,
1461
    "mergeStateStatus": "UNKNOWN",
1462
    "mergeable": "UNKNOWN",
1463
    "mergedAt": null,
1464
    "mergedBy": null,
1465
    "milestone": null,
1466
    "number": 72,
1467
    "potentialMergeCommit": null,
1468
    "projectCards": [],
1469
    "projectItems": [],
1470
    "reactionGroups": [],
1471
    "reviewDecision": "",
1472
    "reviewRequests": [],
1473
    "reviews": [],
1474
    "state": "CLOSED",
1475
    "statusCheckRollup": [],
1476
    "title": "Newton-Raphson divison, sqrt",
1477
    "updatedAt": "2023-12-14T04:47:11Z",
1478
    "url": "https://github.com/gavinhoward/bc/pull/72"
1479
  },
1480
  {
1481
    "additions": 337,
1482
    "assignees": [],
1483
    "author": {
1484
      "id": "MDQ6VXNlcjgwNzU4MA==",
1485
      "is_bot": false,
1486
      "login": "SamuelMarks",
1487
      "name": "Samuel Marks"
1488
    },
1489
    "autoMergeRequest": null,
1490
    "baseRefName": "master",
1491
    "baseRefOid": "3f4c8cc5f86092fa4a8d59bc99d8f10ad2894cf0",
1492
    "body": "WiP\r\n\r\nCan finish if you like. Can also send you a PR on your own website, just make me an account",
1493
    "changedFiles": 19,
1494
    "closed": true,
1495
    "closedAt": "2025-03-25T05:20:50Z",
1496
    "comments": [
1497
      {
1498
        "id": "IC_kwDOCL0xJc5kTkGI",
1499
        "author": {
1500
          "login": "gavinhoward"
1501
        },
1502
        "authorAssociation": "OWNER",
1503
        "body": "Thank you for the PR!\r\n\r\nAllow me to I apologize upfront. Usually, I do not question user requests; after all, there is a user, and they have a request, so obviously, there is a need or a want.\r\n\r\n*However*, personally, [I ***hate*** CMake][1]. I hate it so much that I have spent *three years* designing and implementing a build system to remove it from my [other project][2], a build system that would allow building on Windows, Mac OSX, Linux, the BSD's, etc. And I was going to add support for that build system to `bc`, which I hoped would remove any need for people to use CMake to build `bc` cross-platform.\r\n\r\nSo, I apologize because I can tell you put a lot of work into this, but for once, I am asking you to provide justification. I won't ask for much; I just need to know why CMake is necessary and why you believe that keeping a fork would not serve. (Since a separate build system won't touch the code, it seems like an easy fork to keep.)\r\n\r\nAgain, I'm sorry.\r\n\r\nAlso, if I do decide to merge, I'm going to need you to explain the more complicated bits; I've tried to avoid complicated CMake as much as possible. But I need to be able to maintain the CMake code without your help.\r\n\r\n[1]: https://news.ycombinator.com/item?id=36469860\r\n[2]: https://git.yzena.com/Yzena/Yc",
1504
        "createdAt": "2023-08-17T19:34:43Z",
1505
        "includesCreatedEdit": false,
1506
        "isMinimized": false,
1507
        "minimizedReason": "",
1508
        "reactionGroups": [],
1509
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1682850184",
1510
        "viewerDidAuthor": true
1511
      },
1512
      {
1513
        "id": "IC_kwDOCL0xJc5kVWMk",
1514
        "author": {
1515
          "login": "SamuelMarks"
1516
        },
1517
        "authorAssociation": "NONE",
1518
        "body": "@gavinhoward I'm obsessed with interoperability. CMake is one way to achieve this. Open to your build system also, where I plan on taking `bc` to:\r\n- Windows (different MSVC versions);\r\n- MinGW (x86, x64, …)\r\n- DOS (via OpenWatcom and maybe via early MSVC versions)\r\n- Cygwin\r\n- Linux\r\n- macOS\r\n- iOS\r\n- Android\r\n- SunOS (Solaris→OpenSolaris→illumos→OpenIndiana)\r\n- *BSD (FreeBSD, OpenBSD, …)\r\n\r\n…and yes I know you support some of these targets already.\r\n\r\nThere are some other nice advantages like CPack and CTest, but honestly there are a number of other nice build generators out there and I tend to choose CMake just because it's the most popular and has a good number of generators.",
1519
        "createdAt": "2023-08-18T04:01:35Z",
1520
        "includesCreatedEdit": false,
1521
        "isMinimized": false,
1522
        "minimizedReason": "",
1523
        "reactionGroups": [],
1524
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1683317540",
1525
        "viewerDidAuthor": false
1526
      },
1527
      {
1528
        "id": "IC_kwDOCL0xJc5kVpyv",
1529
        "author": {
1530
          "login": "gavinhoward"
1531
        },
1532
        "authorAssociation": "OWNER",
1533
        "body": "Okay, interoperability is something I can understand. But oh boy, I would love it if my build system could do all that.\r\n\r\nThat said, my build system (named Rig, by the way) won't be able to cross-compile in the first release, so some of those targets may not be possible in the first release of Rig. (OpenWatcom is the one that makes me most nervous.)\r\n\r\nSo I'll make you a deal. I'll do these things:\r\n\r\n1. Merge your PR,\r\n2. Set up Rig in my `bc` once it's ready,\r\n3. Write you a tutorial on how to use Rig for `bc`, and\r\n4. Help you understand the new build scripts,\r\n\r\nas long as you'll do the following:\r\n\r\n1. Give me your contact info because this is a pretty big commitment, and I want to be able to ask you questions, if at all possible (you can use the info at <https://gavinhoward.com/contact/> to send me that info privately),\r\n2. Point me to material that will help me set up environments for all of those platforms (so I can test `bc` and CMake on them myself),\r\n3. Explain to me any CMake code I don't understand (I'll make them reviews in the PR),\r\n4. Learn how to use Rig for `bc` once it's ready (I don't care if you use it for anything else), and\r\n5. At that point, give me your honest opinion if Rig can fully replace the CMake build.\r\n\r\nIf it can, I'd ***really*** like to remove the CMake then. If it can't, well, it can't, and CMake will stay in perpetuity.\r\n\r\nIn other words, I'll add CMake now if you'll give Rig a fair shake later.\r\n\r\nOh, and point number 2 is crucial; if I can't test `bc` on those platforms with CMake, I won't merge the PR because I would basically be committing to supporting those platforms by merging the PR, and I can't do that without the ability to test.\r\n\r\nBy the way, I only need to know how to set up environments for:\r\n\r\n* Windows (specifically different MSVC versions because I can already compile on the latest Windows 10);\r\n* MinGW\r\n* DOS (via OpenWatcom and maybe via early MSVC versions)\r\n* Cygwin\r\n* iOS (do I need a Mac computer?)\r\n* Android\r\n* SunOS (Solaris, OpenSolaris, illumos, OpenIndiana)\r\n\r\nI have the capability for the rest.",
1534
        "createdAt": "2023-08-18T06:04:29Z",
1535
        "includesCreatedEdit": false,
1536
        "isMinimized": false,
1537
        "minimizedReason": "",
1538
        "reactionGroups": [],
1539
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1683397807",
1540
        "viewerDidAuthor": true
1541
      },
1542
      {
1543
        "id": "IC_kwDOCL0xJc5kX99Z",
1544
        "author": {
1545
          "login": "SamuelMarks"
1546
        },
1547
        "authorAssociation": "NONE",
1548
        "body": "Great yeah sure I'll give it a shot. No guaranteed time commitments (because of everything going on in my life); but I'll see what I can do.\r\n\r\nMy email is samuel`   `at symbol     offscale.io; or you can use    myfirstname mylastname`    `at symbol    gmail.com.\r\n\r\nI wrote some Windows Batch scripts for building on these different targets, and lots of things can run in a good CI/CD environment (e.g., GitHub Actions, Cirrus CI, &etc.): https://github.com/offscale/win-cmake-multi-build\r\n\r\nObviously still a ways to go to support all the different targets I'm interested in. But yeah something clean like your `bc` might be just complicated enough to test out my interoperability",
1549
        "createdAt": "2023-08-18T14:29:25Z",
1550
        "includesCreatedEdit": false,
1551
        "isMinimized": false,
1552
        "minimizedReason": "",
1553
        "reactionGroups": [],
1554
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1684004697",
1555
        "viewerDidAuthor": false
1556
      },
1557
      {
1558
        "id": "IC_kwDOCL0xJc5kcbRH",
1559
        "author": {
1560
          "login": "gavinhoward"
1561
        },
1562
        "authorAssociation": "OWNER",
1563
        "body": "Okay. Thank you.\r\n\r\nPlease let me know when this PR is not WIP.",
1564
        "createdAt": "2023-08-20T04:29:28Z",
1565
        "includesCreatedEdit": false,
1566
        "isMinimized": false,
1567
        "minimizedReason": "",
1568
        "reactionGroups": [],
1569
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1685173319",
1570
        "viewerDidAuthor": true
1571
      },
1572
      {
1573
        "id": "IC_kwDOCL0xJc5kc7km",
1574
        "author": {
1575
          "login": "SamuelMarks"
1576
        },
1577
        "authorAssociation": "NONE",
1578
        "body": "Sure thing, I'll see if I can get to it later in the week. Last remaining errors:\r\n```\r\nbc.c.obj : error LNK2001: unresolved external symbol _bc_help\r\nvm.c.obj : error LNK2001: unresolved external symbol _bc_lib\r\nvm.c.obj : error LNK2001: unresolved external symbol _bc_lib_name\r\nvm.c.obj : error LNK2001: unresolved external symbol _bc_lib2\r\nvm.c.obj : error LNK2001: unresolved external symbol _bc_lib2_name\r\n```\r\n\r\nWhich should be defined in an object file that you define in your existent configure script:\r\n```sh\r\ncontents=$(replace \"$contents\" \"BC_HELP_O\" \"$bc_help\")\r\n```\r\n\r\nSo I just need to reverse-engineer it into CMake and we should be good to go™.",
1579
        "createdAt": "2023-08-20T14:58:39Z",
1580
        "includesCreatedEdit": false,
1581
        "isMinimized": false,
1582
        "minimizedReason": "",
1583
        "reactionGroups": [],
1584
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-1685305638",
1585
        "viewerDidAuthor": false
1586
      },
1587
      {
1588
        "id": "IC_kwDOCL0xJc6j64Rc",
1589
        "author": {
1590
          "login": "gavinhoward"
1591
        },
1592
        "authorAssociation": "OWNER",
1593
        "body": "It's been a year and a half, unfortunately, with no word since then.\r\n\r\nHowever, I have not stood still. I have [added][1] [Rig][2] [to `bc`][3], and I have [implemented the entire test suite in Rig][4].\r\n\r\nIn addition, Rig has the ability to cross compile now, and it will deactivate the tests under those conditions.\r\n\r\nSo because no progress has been made with CMake, and Rig is now working (except on Windows, but the only thing left is getting itself to bootstrap itself), I am rejecting this PR in favor of Rig.\r\n\r\n[1]: https://github.com/gavinhoward/bc/blob/master/build.gaml\r\n[2]: https://github.com/gavinhoward/bc/blob/master/build.rig\r\n[3]: https://github.com/gavinhoward/bc/blob/master/build.pkg.rig\r\n[4]: https://github.com/gavinhoward/bc/commit/77fcd66898f754cb1dbce262c6c0efd0879f855c",
1594
        "createdAt": "2025-03-25T05:20:50Z",
1595
        "includesCreatedEdit": false,
1596
        "isMinimized": false,
1597
        "minimizedReason": "",
1598
        "reactionGroups": [],
1599
        "url": "https://github.com/gavinhoward/bc/pull/68#issuecomment-2750121052",
1600
        "viewerDidAuthor": true
1601
      }
1602
    ],
1603
    "commits": [
1604
      {
1605
        "authoredDate": "2023-08-17T18:47:20Z",
1606
        "authors": [
1607
          {
1608
            "email": "[email protected]",
1609
            "id": "MDQ6VXNlcjgwNzU4MA==",
1610
            "login": "SamuelMarks",
1611
            "name": "Samuel Marks"
1612
          }
1613
        ],
1614
        "committedDate": "2023-08-17T18:47:20Z",
1615
        "messageBody": "",
1616
        "messageHeadline": "CMake support (initial)",
1617
        "oid": "4256fe30a6eee88983bbe39b606a793a47b96ec0"
1618
      },
1619
      {
1620
        "authoredDate": "2023-08-17T20:06:53Z",
1621
        "authors": [
1622
          {
1623
            "email": "[email protected]",
1624
            "id": "MDQ6VXNlcjgwNzU4MA==",
1625
            "login": "SamuelMarks",
1626
            "name": "Samuel Marks"
1627
          }
1628
        ],
1629
        "committedDate": "2023-08-17T20:06:53Z",
1630
        "messageBody": "",
1631
        "messageHeadline": "Improve CMake suppoprt and remove extraneous code & files",
1632
        "oid": "63e687a593ca72430a23216ab35eb897a4677b36"
1633
      },
1634
      {
1635
        "authoredDate": "2023-08-18T21:02:52Z",
1636
        "authors": [
1637
          {
1638
            "email": "[email protected]",
1639
            "id": "MDQ6VXNlcjgwNzU4MA==",
1640
            "login": "SamuelMarks",
1641
            "name": "Samuel Marks"
1642
          }
1643
        ],
1644
        "committedDate": "2023-08-18T21:02:52Z",
1645
        "messageBody": "",
1646
        "messageHeadline": "Improve CMake support",
1647
        "oid": "a2e95a6e697fa9d6557a16c17ad6bf8d048b5bd3"
1648
      },
1649
      {
1650
        "authoredDate": "2023-08-19T00:43:54Z",
1651
        "authors": [
1652
          {
1653
            "email": "[email protected]",
1654
            "id": "MDQ6VXNlcjgwNzU4MA==",
1655
            "login": "SamuelMarks",
1656
            "name": "Samuel Marks"
1657
          }
1658
        ],
1659
        "committedDate": "2023-08-19T00:43:54Z",
1660
        "messageBody": "",
1661
        "messageHeadline": "Improve CMake support",
1662
        "oid": "b945314d5edcb660bc286f63e60a5a63697b9ee4"
1663
      }
1664
    ],
1665
    "createdAt": "2023-08-17T18:49:48Z",
1666
    "deletions": 17,
1667
    "files": [
1668
      {
1669
        "path": ".gitignore",
1670
        "additions": 3,
1671
        "deletions": 0
1672
      },
1673
      {
1674
        "path": "CMakeLists.txt",
1675
        "additions": 123,
1676
        "deletions": 0
1677
      },
1678
      {
1679
        "path": "bcl.pc.in",
1680
        "additions": 1,
1681
        "deletions": 1
1682
      },
1683
      {
1684
        "path": "cmake/BundleIcon.icns",
1685
        "additions": 0,
1686
        "deletions": 0
1687
      },
1688
      {
1689
        "path": "cmake/CTestConfig.cmake",
1690
        "additions": 7,
1691
        "deletions": 0
1692
      },
1693
      {
1694
        "path": "cmake/Config.cmake.in",
1695
        "additions": 4,
1696
        "deletions": 0
1697
      },
1698
      {
1699
        "path": "cmake/CustomVolumeIcon.icns",
1700
        "additions": 0,
1701
        "deletions": 0
1702
      },
1703
      {
1704
        "path": "cmake/Info.plist",
1705
        "additions": 14,
1706
        "deletions": 0
1707
      },
1708
      {
1709
        "path": "cmake/MultiCPackConfig.cmake",
1710
        "additions": 6,
1711
        "deletions": 0
1712
      },
1713
      {
1714
        "path": "cmake/README.txt",
1715
        "additions": 5,
1716
        "deletions": 0
1717
      },
1718
      {
1719
        "path": "cmake/Welcome.txt",
1720
        "additions": 1,
1721
        "deletions": 0
1722
      },
1723
      {
1724
        "path": "cmake/config.h.in",
1725
        "additions": 11,
1726
        "deletions": 0
1727
      },
1728
      {
1729
        "path": "include/bc.h",
1730
        "additions": 8,
1731
        "deletions": 7
1732
      },
1733
      {
1734
        "path": "include/dc.h",
1735
        "additions": 1,
1736
        "deletions": 1
1737
      },
1738
      {
1739
        "path": "include/history.h",
1740
        "additions": 6,
1741
        "deletions": 4
1742
      },
1743
      {
1744
        "path": "include/read.h",
1745
        "additions": 2,
1746
        "deletions": 1
1747
      },
1748
      {
1749
        "path": "include/vm.h",
1750
        "additions": 10,
1751
        "deletions": 2
1752
      },
1753
      {
1754
        "path": "src/CMakeLists.txt",
1755
        "additions": 134,
1756
        "deletions": 0
1757
      },
1758
      {
1759
        "path": "src/vm.c",
1760
        "additions": 1,
1761
        "deletions": 1
1762
      }
1763
    ],
1764
    "fullDatabaseId": "1479523420",
1765
    "headRefName": "cmake",
1766
    "headRefOid": "b945314d5edcb660bc286f63e60a5a63697b9ee4",
1767
    "headRepository": {
1768
      "id": "R_kgDOKIWfvQ",
1769
      "name": "bc"
1770
    },
1771
    "headRepositoryOwner": {
1772
      "id": "MDQ6VXNlcjgwNzU4MA==",
1773
      "name": "Samuel Marks",
1774
      "login": "SamuelMarks"
1775
    },
1776
    "id": "PR_kwDOCL0xJc5YL7xc",
1777
    "isCrossRepository": true,
1778
    "isDraft": false,
1779
    "labels": [],
1780
    "latestReviews": [],
1781
    "maintainerCanModify": false,
1782
    "mergeCommit": null,
1783
    "mergeStateStatus": "DIRTY",
1784
    "mergeable": "CONFLICTING",
1785
    "mergedAt": null,
1786
    "mergedBy": null,
1787
    "milestone": null,
1788
    "number": 68,
1789
    "potentialMergeCommit": null,
1790
    "projectCards": [],
1791
    "projectItems": [],
1792
    "reactionGroups": [],
1793
    "reviewDecision": "",
1794
    "reviewRequests": [],
1795
    "reviews": [],
1796
    "state": "CLOSED",
1797
    "statusCheckRollup": [],
1798
    "title": "CMake support",
1799
    "updatedAt": "2025-03-25T05:20:51Z",
1800
    "url": "https://github.com/gavinhoward/bc/pull/68"
1801
  },
1802
  {
1803
    "additions": 5,
1804
    "assignees": [],
1805
    "author": {
1806
      "id": "MDQ6VXNlcjc0MTgyNg==",
1807
      "is_bot": false,
1808
      "login": "dorjechang",
1809
      "name": "alexander naumochkin"
1810
    },
1811
    "autoMergeRequest": null,
1812
    "baseRefName": "master",
1813
    "baseRefOid": "71fa3cd4029d416a5272b262736c4d6ab709b6ce",
1814
    "body": "Casting int -1 to size_t produces SIZE_T_MAX so\r\nBC_NUM_PRINT_WIDTH is used instead of 0",
1815
    "changedFiles": 1,
1816
    "closed": true,
1817
    "closedAt": "2023-03-15T16:06:35Z",
1818
    "comments": [],
1819
    "commits": [
1820
      {
1821
        "authoredDate": "2023-03-15T12:46:29Z",
1822
        "authors": [
1823
          {
1824
            "email": "[email protected]",
1825
            "id": "MDQ6VXNlcjc0MTgyNg==",
1826
            "login": "dorjechang",
1827
            "name": "ash"
1828
          }
1829
        ],
1830
        "committedDate": "2023-03-15T12:46:29Z",
1831
        "messageBody": "Casting int -1 to size_t produces SIZE_T_MAX so\nBC_NUM_PRINT_WIDTH is used instead of 0",
1832
        "messageHeadline": "Fix incorrect processing of env:BC_LINE_LENGTH=0",
1833
        "oid": "31042aed8426850187b43d7e639f244354da0d6c"
1834
      }
1835
    ],
1836
    "createdAt": "2023-03-15T13:08:07Z",
1837
    "deletions": 2,
1838
    "files": [
1839
      {
1840
        "path": "src/vm.c",
1841
        "additions": 5,
1842
        "deletions": 2
1843
      }
1844
    ],
1845
    "fullDatabaseId": "1276831340",
1846
    "headRefName": "fix_BC_LINE_LENGTH=0",
1847
    "headRefOid": "31042aed8426850187b43d7e639f244354da0d6c",
1848
    "headRepository": null,
1849
    "headRepositoryOwner": {
1850
      "id": "MDQ6VXNlcjc0MTgyNg==",
1851
      "name": "alexander naumochkin",
1852
      "login": "dorjechang"
1853
    },
1854
    "id": "PR_kwDOCL0xJc5MGuZs",
1855
    "isCrossRepository": true,
1856
    "isDraft": false,
1857
    "labels": [],
1858
    "latestReviews": [],
1859
    "maintainerCanModify": false,
1860
    "mergeCommit": {
1861
      "oid": "0c42c52dfc0735026cb6d2534dc24436ff19778f"
1862
    },
1863
    "mergeStateStatus": "UNKNOWN",
1864
    "mergeable": "UNKNOWN",
1865
    "mergedAt": "2023-03-15T16:06:35Z",
1866
    "mergedBy": {
1867
      "id": "MDQ6VXNlcjMxNzI2ODc=",
1868
      "is_bot": false,
1869
      "login": "gavinhoward",
1870
      "name": "Gavin D. Howard"
1871
    },
1872
    "milestone": null,
1873
    "number": 65,
1874
    "potentialMergeCommit": null,
1875
    "projectCards": [],
1876
    "projectItems": [],
1877
    "reactionGroups": [],
1878
    "reviewDecision": "",
1879
    "reviewRequests": [],
1880
    "reviews": [],
1881
    "state": "MERGED",
1882
    "statusCheckRollup": [],
1883
    "title": "Fix incorrect processing of env:BC_LINE_LENGTH=0",
1884
    "updatedAt": "2023-03-15T16:06:35Z",
1885
    "url": "https://github.com/gavinhoward/bc/pull/65"
1886
  },
1887
  {
1888
    "additions": 16,
1889
    "assignees": [],
1890
    "author": {
1891
      "id": "MDQ6VXNlcjQ2MTYwNzI3",
1892
      "is_bot": false,
1893
      "login": "firasuke",
1894
      "name": "Firas Khalil Khana"
1895
    },
1896
    "autoMergeRequest": null,
1897
    "baseRefName": "master",
1898
    "baseRefOid": "2ed62ba26831b34cae22b9e7b2f1dd2f3a74b541",
1899
    "body": "",
1900
    "changedFiles": 1,
1901
    "closed": true,
1902
    "closedAt": "2022-11-26T15:16:46Z",
1903
    "comments": [],
1904
    "commits": [
1905
      {
1906
        "authoredDate": "2022-11-26T10:30:09Z",
1907
        "authors": [
1908
          {
1909
            "email": "[email protected]",
1910
            "id": "MDQ6VXNlcjQ2MTYwNzI3",
1911
            "login": "firasuke",
1912
            "name": "Firas Khalil Khana"
1913
          }
1914
        ],
1915
        "committedDate": "2022-11-26T10:30:09Z",
1916
        "messageBody": "",
1917
        "messageHeadline": "Mention MAN3DIR in build.md",
1918
        "oid": "f62ecdabc44ca2ed32f7f0895a78099919038da9"
1919
      }
1920
    ],
1921
    "createdAt": "2022-11-26T10:30:59Z",
1922
    "deletions": 7,
1923
    "files": [
1924
      {
1925
        "path": "manuals/build.md",
1926
        "additions": 16,
1927
        "deletions": 7
1928
      }
1929
    ],
1930
    "fullDatabaseId": "1136437158",
1931
    "headRefName": "master",
1932
    "headRefOid": "f62ecdabc44ca2ed32f7f0895a78099919038da9",
1933
    "headRepository": null,
1934
    "headRepositoryOwner": {
1935
      "id": "MDQ6VXNlcjQ2MTYwNzI3",
1936
      "name": "Firas Khalil Khana",
1937
      "login": "firasuke"
1938
    },
1939
    "id": "PR_kwDOCL0xJc5DvKem",
1940
    "isCrossRepository": true,
1941
    "isDraft": false,
1942
    "labels": [],
1943
    "latestReviews": [],
1944
    "maintainerCanModify": false,
1945
    "mergeCommit": {
1946
      "oid": "09247332bf9dafef6840864598c93df92ebc0820"
1947
    },
1948
    "mergeStateStatus": "UNKNOWN",
1949
    "mergeable": "UNKNOWN",
1950
    "mergedAt": "2022-11-26T15:16:46Z",
1951
    "mergedBy": {
1952
      "id": "MDQ6VXNlcjMxNzI2ODc=",
1953
      "is_bot": false,
1954
      "login": "gavinhoward",
1955
      "name": "Gavin D. Howard"
1956
    },
1957
    "milestone": null,
1958
    "number": 57,
1959
    "potentialMergeCommit": null,
1960
    "projectCards": [],
1961
    "projectItems": [],
1962
    "reactionGroups": [],
1963
    "reviewDecision": "",
1964
    "reviewRequests": [],
1965
    "reviews": [],
1966
    "state": "MERGED",
1967
    "statusCheckRollup": [],
1968
    "title": "Mention MAN3DIR in build.md",
1969
    "updatedAt": "2022-11-26T15:16:46Z",
1970
    "url": "https://github.com/gavinhoward/bc/pull/57"
1971
  },
1972
  {
1973
    "additions": 1,
1974
    "assignees": [],
1975
    "author": {
1976
      "id": "MDQ6VXNlcjU3MDUxMDY4",
1977
      "is_bot": false,
1978
      "login": "pacordova",
1979
      "name": "Paul Cordova"
1980
    },
1981
    "autoMergeRequest": null,
1982
    "baseRefName": "master",
1983
    "baseRefOid": "4355599e9a59834098ed18e670b90cec2b84120d",
1984
    "body": "On POSIX systems, `find` may have indeterministic output (I believe based on the inode on the filesystem).\r\n`sort` is needed to ensure the output is deterministic.\r\n\r\nIn my builds, this resulted in the build order in the generated `Makefile` changing around.\r\nThus building on a fresh partition made with `mkfs.ext4` would result in the binary being different each time.\r\nThe compiled binary code in the`bc` binary shuffled around depending on which files were built first.\r\nPossibly the build order in the Makefile was affecting the order in which files were linked?\r\n\r\nI added `LC_ALL=C` recommended by reproducible-builds.org. \r\nSee below for reference:\r\n- [https://reproducible-builds.org/docs/archives/](https://reproducible-builds.org/docs/archives/)\r\n- [https://reproducible-builds.org/docs/stable-inputs/](https://reproducible-builds.org/docs/stable-inputs/)",
1985
    "changedFiles": 1,
1986
    "closed": true,
1987
    "closedAt": "2022-08-03T02:35:23Z",
1988
    "comments": [
1989
      {
1990
        "id": "IC_kwDOCL0xJc5Huq4A",
1991
        "author": {
1992
          "login": "gavinhoward"
1993
        },
1994
        "authorAssociation": "OWNER",
1995
        "body": "The only hangup I would have had is if the way you did it was not portable to POSIX `sh`. I consulted the standard, and your solution is portable!\r\n\r\nI agree that reproducible builds are *very* important. So thank you for your contribution! I have accepted it, and it will be in the release out in a day or two. I just have to make sure everything builds correctly.",
1996
        "createdAt": "2022-08-03T02:37:10Z",
1997
        "includesCreatedEdit": false,
1998
        "isMinimized": false,
1999
        "minimizedReason": "",
2000
        "reactionGroups": [],
2001
        "url": "https://github.com/gavinhoward/bc/pull/54#issuecomment-1203416576",
2002
        "viewerDidAuthor": true
2003
      },
2004
      {
2005
        "id": "IC_kwDOCL0xJc5HuvNl",
2006
        "author": {
2007
          "login": "pacordova"
2008
        },
2009
        "authorAssociation": "CONTRIBUTOR",
2010
        "body": "No problem! Thank you for accepting my pull request!\r\nOne additional comment:\r\nWith this change I do get reproducible builds, although I do not use `-flto`\r\nYour recommended optimization of `-O3` I think should be ok, but I do know that Link Time Optimization (LTO) and Profile Guided Optimization (PGO) can both potentially break build determinism.\r\nEither way the end user should be able get reproducible builds if they want it with this change.\r\nThe CFLAGS I was testing with were `CFLAGS='-march=x86-64 -pipe -Os -fstack-protector-strong -fstack-clash-protection'` with GCC 11.2.0.",
2011
        "createdAt": "2022-08-03T03:13:48Z",
2012
        "includesCreatedEdit": true,
2013
        "isMinimized": false,
2014
        "minimizedReason": "",
2015
        "reactionGroups": [],
2016
        "url": "https://github.com/gavinhoward/bc/pull/54#issuecomment-1203434341",
2017
        "viewerDidAuthor": false
2018
      },
2019
      {
2020
        "id": "IC_kwDOCL0xJc5Hwkv2",
2021
        "author": {
2022
          "login": "gavinhoward"
2023
        },
2024
        "authorAssociation": "OWNER",
2025
        "body": "Thank you!",
2026
        "createdAt": "2022-08-03T12:57:26Z",
2027
        "includesCreatedEdit": false,
2028
        "isMinimized": false,
2029
        "minimizedReason": "",
2030
        "reactionGroups": [],
2031
        "url": "https://github.com/gavinhoward/bc/pull/54#issuecomment-1203915766",
2032
        "viewerDidAuthor": true
2033
      }
2034
    ],
2035
    "commits": [
2036
      {
2037
        "authoredDate": "2022-08-02T16:49:50Z",
2038
        "authors": [
2039
          {
2040
            "email": "[email protected]",
2041
            "id": "MDQ6VXNlcjU3MDUxMDY4",
2042
            "login": "pacordova",
2043
            "name": "pac"
2044
          }
2045
        ],
2046
        "committedDate": "2022-08-02T16:49:50Z",
2047
        "messageBody": "find has indeterministic output based on the inode on the filesystem,\nso sort is needed to ensure the output is deterministic",
2048
        "messageHeadline": "improve reproducibility",
2049
        "oid": "8c7d5fa125dae5049427cb9b0ddc9ee7bbf099b4"
2050
      },
2051
      {
2052
        "authoredDate": "2022-08-02T23:00:34Z",
2053
        "authors": [
2054
          {
2055
            "email": "[email protected]",
2056
            "id": "MDQ6VXNlcjU3MDUxMDY4",
2057
            "login": "pacordova",
2058
            "name": "pac"
2059
          }
2060
        ],
2061
        "committedDate": "2022-08-02T23:00:34Z",
2062
        "messageBody": "",
2063
        "messageHeadline": "remove -z",
2064
        "oid": "6ea4d12e2f11e0ce0bed779d991a17230db3a889"
2065
      }
2066
    ],
2067
    "createdAt": "2022-08-02T17:17:46Z",
2068
    "deletions": 1,
2069
    "files": [
2070
      {
2071
        "path": "configure.sh",
2072
        "additions": 1,
2073
        "deletions": 1
2074
      }
2075
    ],
2076
    "fullDatabaseId": "1015375109",
2077
    "headRefName": "reproducible_builds",
2078
    "headRefOid": "6ea4d12e2f11e0ce0bed779d991a17230db3a889",
2079
    "headRepository": null,
2080
    "headRepositoryOwner": {
2081
      "id": "MDQ6VXNlcjU3MDUxMDY4",
2082
      "name": "Paul Cordova",
2083
      "login": "pacordova"
2084
    },
2085
    "id": "PR_kwDOCL0xJc48hWUF",
2086
    "isCrossRepository": true,
2087
    "isDraft": false,
2088
    "labels": [],
2089
    "latestReviews": [],
2090
    "maintainerCanModify": false,
2091
    "mergeCommit": {
2092
      "oid": "71215b0eb1c20aa622bd77e664ad7f099b349e91"
2093
    },
2094
    "mergeStateStatus": "UNKNOWN",
2095
    "mergeable": "UNKNOWN",
2096
    "mergedAt": "2022-08-03T02:35:23Z",
2097
    "mergedBy": {
2098
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2099
      "is_bot": false,
2100
      "login": "gavinhoward",
2101
      "name": "Gavin D. Howard"
2102
    },
2103
    "milestone": null,
2104
    "number": 54,
2105
    "potentialMergeCommit": null,
2106
    "projectCards": [],
2107
    "projectItems": [],
2108
    "reactionGroups": [],
2109
    "reviewDecision": "",
2110
    "reviewRequests": [],
2111
    "reviews": [],
2112
    "state": "MERGED",
2113
    "statusCheckRollup": [],
2114
    "title": "Improve Reproducibility (Reproducible Builds)",
2115
    "updatedAt": "2022-08-03T12:57:26Z",
2116
    "url": "https://github.com/gavinhoward/bc/pull/54"
2117
  },
2118
  {
2119
    "additions": 11,
2120
    "assignees": [],
2121
    "author": {
2122
      "id": "MDQ6VXNlcjQxMzkwMDY=",
2123
      "is_bot": false,
2124
      "login": "bsdimp",
2125
      "name": "Warner Losh"
2126
    },
2127
    "autoMergeRequest": null,
2128
    "baseRefName": "master",
2129
    "baseRefOid": "cad172d8f0962f47b08007beedc8f4637618ffe6",
2130
    "body": "The historic gnu bc behavior was to have ^D be delete next character if\r\nthere were any characters in the input, or end of file if there\r\nweren't. This matches what emacs users expect for editing the command\r\nline. Implement this by assuming end of file if the input is empty, and\r\ndelete forward character if it isn't.\r\n\r\nSigned-off-by: Warner Losh <[email protected]>",
2131
    "changedFiles": 1,
2132
    "closed": true,
2133
    "closedAt": "2022-04-29T14:06:09Z",
2134
    "comments": [
2135
      {
2136
        "id": "IC_kwDOCL0xJc5CTTkH",
2137
        "author": {
2138
          "login": "bsdimp"
2139
        },
2140
        "authorAssociation": "CONTRIBUTOR",
2141
        "body": "I've been using this change in my tree for a while now since FreeBSD merged the Howard bc. If there's a way to write a test case for it, please let me know.\r\n\r\nTo test it out, it's simple: 123^B^D^M should leave you in bc and produce the answer 12. Current behavior is to exit after printing 123.",
2142
        "createdAt": "2022-04-28T15:36:16Z",
2143
        "includesCreatedEdit": true,
2144
        "isMinimized": false,
2145
        "minimizedReason": "",
2146
        "reactionGroups": [],
2147
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1112357127",
2148
        "viewerDidAuthor": false
2149
      },
2150
      {
2151
        "id": "IC_kwDOCL0xJc5CVMF_",
2152
        "author": {
2153
          "login": "gavinhoward"
2154
        },
2155
        "authorAssociation": "OWNER",
2156
        "body": "Thank you for this submission. I have tested it, and it works as advertised. It does require a tweak to the test suite to get all of the tests to pass.\r\n\r\nHowever, there are two hangups.\r\n\r\nFirst, if I do merge this, I'm not sure it warrants another release by itself; it might be better to wait until some other change comes along.\r\n\r\nSecond, this does change the behavior of `bc` and would require a major version bump. This is also the biggest reason for wanting at least one other change; this is a small change that requires a big version bump, and I'd want something big.\r\n\r\nBut the fact that it changes behavior also gives me pause. I don't know how many people depend on the `^D` behavior for end-of-file, even when there's input, and I hesitate to make this change without knowing the numbers.\r\n\r\nHowever, I would be satisfied with just a survey of FreeBSD users, which should be the biggest portion of my userbase. (Not many Linux distros have my `bc`, and history is not available on Windows.) That is, I would be satisfied if the survey showed that the vast majority of the FreeBSD users who respond either don't care or agree with the change.\r\n\r\nI would also be satisfied with the blessing of my regular FreeBSD contact, Stefan Esser, who I believe has a good handle on what changes would be okay to make.\r\n\r\nIf you can give me either one of those two things, I'll merge. If Stefan even gives a blessing for a release, I'll do that too.",
2157
        "createdAt": "2022-04-29T03:47:48Z",
2158
        "includesCreatedEdit": false,
2159
        "isMinimized": false,
2160
        "minimizedReason": "",
2161
        "reactionGroups": [],
2162
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1112850815",
2163
        "viewerDidAuthor": true
2164
      },
2165
      {
2166
        "id": "IC_kwDOCL0xJc5CW3df",
2167
        "author": {
2168
          "login": "bsdimp"
2169
        },
2170
        "authorAssociation": "CONTRIBUTOR",
2171
        "body": "Since it's only in the command history editing, I'm having trouble understanding how it would affect tests or other input since that code path appears to be disabled when we aren't reading from a tty.\r\n\r\nAnd even if it didn't, ^D on Unix is only a tty signal of EOF. It's not used at the end of files to signify EOF, which is done by zero read.\r\n\r\nFreeBSD used gnu bc since 1998. It has the behavior I've implemented for the past at least 24 years, so it wouldn't be unreasonable to assume that it's what FreeBSD users that care one way or the other would want. Once you've started to edit the text on the line, you don't want to terminate the program and get an answer for the partially edited line.\r\n\r\nI'd argue that this is a mere bug fix to make things more compatible with bc and isn't such a gross behavior change as to warrant a major release bump, but that's just my sensibilities.\r\n\r\nI'm OK waiting on a release. I'll also chat with Stefan as well about this point.",
2172
        "createdAt": "2022-04-29T13:07:47Z",
2173
        "includesCreatedEdit": false,
2174
        "isMinimized": false,
2175
        "minimizedReason": "",
2176
        "reactionGroups": [],
2177
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1113290591",
2178
        "viewerDidAuthor": false
2179
      },
2180
      {
2181
        "id": "IC_kwDOCL0xJc5CXG7p",
2182
        "author": {
2183
          "login": "gavinhoward"
2184
        },
2185
        "authorAssociation": "OWNER",
2186
        "body": "I have history tests, but they are only run when you run `make test_history` because they can be...flaky. No worries; I'll make the change to fix them. In fact, I might make a change to test this new behavior.\r\n\r\nYou make a compelling and convincing case that this is merely a bug fix. Stefan seems to agree that it is and that many old Unix users would expect this behavior change.\r\n\r\nIn fact, if old Unix users expect the change, then the fact that no one has said anything is probably a good indicator that no one has been using it, which means I can pull the rug out without making anybody mad.\r\n\r\nSo I'm more than satisfied. I'll make the change, and I'll make it in a bugfix release.",
2187
        "createdAt": "2022-04-29T14:06:00Z",
2188
        "includesCreatedEdit": false,
2189
        "isMinimized": false,
2190
        "minimizedReason": "",
2191
        "reactionGroups": [],
2192
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1113353961",
2193
        "viewerDidAuthor": true
2194
      },
2195
      {
2196
        "id": "IC_kwDOCL0xJc5CXNGY",
2197
        "author": {
2198
          "login": "gavinhoward"
2199
        },
2200
        "authorAssociation": "OWNER",
2201
        "body": "I do have a question: should I remove the EOF behavior entirely?",
2202
        "createdAt": "2022-04-29T14:22:22Z",
2203
        "includesCreatedEdit": false,
2204
        "isMinimized": false,
2205
        "minimizedReason": "",
2206
        "reactionGroups": [],
2207
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1113379224",
2208
        "viewerDidAuthor": true
2209
      },
2210
      {
2211
        "id": "IC_kwDOCL0xJc5CXQAy",
2212
        "author": {
2213
          "login": "bsdimp"
2214
        },
2215
        "authorAssociation": "CONTRIBUTOR",
2216
        "body": "> I do have a question: should I remove the EOF behavior entirely?\r\n\r\nNo. The behavior I implemented matches gnu bc's behavior.",
2217
        "createdAt": "2022-04-29T14:28:47Z",
2218
        "includesCreatedEdit": false,
2219
        "isMinimized": false,
2220
        "minimizedReason": "",
2221
        "reactionGroups": [
2222
          {
2223
            "content": "THUMBS_UP",
2224
            "users": {
2225
              "totalCount": 1
2226
            }
2227
          }
2228
        ],
2229
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1113391154",
2230
        "viewerDidAuthor": false
2231
      },
2232
      {
2233
        "id": "IC_kwDOCL0xJc5CXkZ_",
2234
        "author": {
2235
          "login": "stesser"
2236
        },
2237
        "authorAssociation": "CONTRIBUTOR",
2238
        "body": " I had sent a reply to Gavin a few hours ago, and I do see that the pull request has already been merged.\r\n\r\nJust a comment regarding compatibility with the previous bc version in FreeBSD:\r\n\r\nWhile GNU bc has the requested behavior, the previous bc in FreeBSD up to 12.x did not:\r\n\r\n$ bc -v\r\nbc (BSD bc) 1.1-FreeBSD\r\n$ bc\r\n12345^B^B^B  <- cursor on 3\r\n^D <- bell sound, nothing deleted\r\n<DEL>\r\n1245 <- result after pressing DEL\r\n\r\nIn the FreeBSD bc (which had been obtained from OpenBSD) ^D did only signal EOF if the input line was empty, but it did not delete to the right.\r\n\r\nGNU bc actually has the line editing behavior created by this patch, and thus it is further step towards GNU bc compatibility. (And IIRC, GNU bc had been in the FreeBSD base system, a few decades ago ...)",
2239
        "createdAt": "2022-04-29T15:55:50Z",
2240
        "includesCreatedEdit": false,
2241
        "isMinimized": false,
2242
        "minimizedReason": "",
2243
        "reactionGroups": [
2244
          {
2245
            "content": "THUMBS_UP",
2246
            "users": {
2247
              "totalCount": 1
2248
            }
2249
          }
2250
        ],
2251
        "url": "https://github.com/gavinhoward/bc/pull/51#issuecomment-1113474687",
2252
        "viewerDidAuthor": false
2253
      }
2254
    ],
2255
    "commits": [
2256
      {
2257
        "authoredDate": "2022-04-28T15:30:25Z",
2258
        "authors": [
2259
          {
2260
            "email": "[email protected]",
2261
            "id": "MDQ6VXNlcjQxMzkwMDY=",
2262
            "login": "bsdimp",
2263
            "name": "Warner Losh"
2264
          }
2265
        ],
2266
        "committedDate": "2022-04-28T15:35:21Z",
2267
        "messageBody": "The historic gnu bc behavior was to have ^D be delete next character if\nthere were any characters in the input, or end of file if there\nweren't. This matches what emacs users expect for editing the command\nline. Implement this by assuming end of file if the input is empty, and\ndelete forward character if it isn't.\n\nSigned-off-by: Warner Losh <[email protected]>",
2268
        "messageHeadline": "Emacs delete-next-character",
2269
        "oid": "cee56074a8fe669901e0869ee8a6e23106d1634b"
2270
      }
2271
    ],
2272
    "createdAt": "2022-04-28T15:35:29Z",
2273
    "deletions": 4,
2274
    "files": [
2275
      {
2276
        "path": "src/history.c",
2277
        "additions": 11,
2278
        "deletions": 4
2279
      }
2280
    ],
2281
    "fullDatabaseId": "922011328",
2282
    "headRefName": "del-forward",
2283
    "headRefOid": "cee56074a8fe669901e0869ee8a6e23106d1634b",
2284
    "headRepository": {
2285
      "id": "R_kgDOHQG2MA",
2286
      "name": "bc"
2287
    },
2288
    "headRepositoryOwner": {
2289
      "id": "MDQ6VXNlcjQxMzkwMDY=",
2290
      "name": "Warner Losh",
2291
      "login": "bsdimp"
2292
    },
2293
    "id": "PR_kwDOCL0xJc429MbA",
2294
    "isCrossRepository": true,
2295
    "isDraft": false,
2296
    "labels": [],
2297
    "latestReviews": [],
2298
    "maintainerCanModify": false,
2299
    "mergeCommit": {
2300
      "oid": "f8fa6febf7521062f0c4ecb6ca4406c91c125360"
2301
    },
2302
    "mergeStateStatus": "UNKNOWN",
2303
    "mergeable": "UNKNOWN",
2304
    "mergedAt": "2022-04-29T14:06:09Z",
2305
    "mergedBy": {
2306
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2307
      "is_bot": false,
2308
      "login": "gavinhoward",
2309
      "name": "Gavin D. Howard"
2310
    },
2311
    "milestone": null,
2312
    "number": 51,
2313
    "potentialMergeCommit": null,
2314
    "projectCards": [],
2315
    "projectItems": [],
2316
    "reactionGroups": [],
2317
    "reviewDecision": "",
2318
    "reviewRequests": [],
2319
    "reviews": [],
2320
    "state": "MERGED",
2321
    "statusCheckRollup": [],
2322
    "title": "Emacs delete-next-character",
2323
    "updatedAt": "2022-04-29T15:55:50Z",
2324
    "url": "https://github.com/gavinhoward/bc/pull/51"
2325
  },
2326
  {
2327
    "additions": 1,
2328
    "assignees": [],
2329
    "author": {
2330
      "id": "MDQ6VXNlcjQ2MTYwNzI3",
2331
      "is_bot": false,
2332
      "login": "firasuke",
2333
      "name": "Firas Khalil Khana"
2334
    },
2335
    "autoMergeRequest": null,
2336
    "baseRefName": "master",
2337
    "baseRefOid": "c3b2d28b2d615ca2b84ba398d796040348c5f13a",
2338
    "body": "",
2339
    "changedFiles": 1,
2340
    "closed": true,
2341
    "closedAt": "2021-12-26T16:59:58Z",
2342
    "comments": [
2343
      {
2344
        "id": "IC_kwDOCL0xJc47rUun",
2345
        "author": {
2346
          "login": "gavinhoward"
2347
        },
2348
        "authorAssociation": "OWNER",
2349
        "body": "Whoops! Thanks for catching.",
2350
        "createdAt": "2021-12-26T17:00:08Z",
2351
        "includesCreatedEdit": false,
2352
        "isMinimized": false,
2353
        "minimizedReason": "",
2354
        "reactionGroups": [],
2355
        "url": "https://github.com/gavinhoward/bc/pull/49#issuecomment-1001212839",
2356
        "viewerDidAuthor": true
2357
      },
2358
      {
2359
        "id": "IC_kwDOCL0xJc47rVpi",
2360
        "author": {
2361
          "login": "firasuke"
2362
        },
2363
        "authorAssociation": "CONTRIBUTOR",
2364
        "body": "Glad I could help!",
2365
        "createdAt": "2021-12-26T17:27:15Z",
2366
        "includesCreatedEdit": false,
2367
        "isMinimized": false,
2368
        "minimizedReason": "",
2369
        "reactionGroups": [],
2370
        "url": "https://github.com/gavinhoward/bc/pull/49#issuecomment-1001216610",
2371
        "viewerDidAuthor": false
2372
      }
2373
    ],
2374
    "commits": [
2375
      {
2376
        "authoredDate": "2021-12-26T16:30:19Z",
2377
        "authors": [
2378
          {
2379
            "email": "[email protected]",
2380
            "id": "MDQ6VXNlcjQ2MTYwNzI3",
2381
            "login": "firasuke",
2382
            "name": "Firas Khalil Khana"
2383
          }
2384
        ],
2385
        "committedDate": "2021-12-26T16:30:19Z",
2386
        "messageBody": "",
2387
        "messageHeadline": "Add missing newline character",
2388
        "oid": "ef5412b1bc939c0dbe18c7cf523e05de8561b25f"
2389
      }
2390
    ],
2391
    "createdAt": "2021-12-26T16:30:26Z",
2392
    "deletions": 1,
2393
    "files": [
2394
      {
2395
        "path": "configure.sh",
2396
        "additions": 1,
2397
        "deletions": 1
2398
      }
2399
    ],
2400
    "fullDatabaseId": "810041419",
2401
    "headRefName": "patch-1",
2402
    "headRefOid": "ef5412b1bc939c0dbe18c7cf523e05de8561b25f",
2403
    "headRepository": null,
2404
    "headRepositoryOwner": {
2405
      "id": "MDQ6VXNlcjQ2MTYwNzI3",
2406
      "name": "Firas Khalil Khana",
2407
      "login": "firasuke"
2408
    },
2409
    "id": "PR_kwDOCL0xJc4wSEBL",
2410
    "isCrossRepository": true,
2411
    "isDraft": false,
2412
    "labels": [],
2413
    "latestReviews": [],
2414
    "maintainerCanModify": false,
2415
    "mergeCommit": {
2416
      "oid": "232a12f6870eaf8fed95c12aa33fb3dbd7df8715"
2417
    },
2418
    "mergeStateStatus": "UNKNOWN",
2419
    "mergeable": "UNKNOWN",
2420
    "mergedAt": "2021-12-26T16:59:58Z",
2421
    "mergedBy": {
2422
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2423
      "is_bot": false,
2424
      "login": "gavinhoward",
2425
      "name": "Gavin D. Howard"
2426
    },
2427
    "milestone": null,
2428
    "number": 49,
2429
    "potentialMergeCommit": null,
2430
    "projectCards": [],
2431
    "projectItems": [],
2432
    "reactionGroups": [],
2433
    "reviewDecision": "",
2434
    "reviewRequests": [],
2435
    "reviews": [],
2436
    "state": "MERGED",
2437
    "statusCheckRollup": [],
2438
    "title": "Add missing newline character",
2439
    "updatedAt": "2021-12-26T17:27:19Z",
2440
    "url": "https://github.com/gavinhoward/bc/pull/49"
2441
  },
2442
  {
2443
    "additions": 7,
2444
    "assignees": [],
2445
    "author": {
2446
      "id": "MDQ6VXNlcjEzNTQxNjk5",
2447
      "is_bot": false,
2448
      "login": "depler",
2449
      "name": ""
2450
    },
2451
    "autoMergeRequest": null,
2452
    "baseRefName": "master",
2453
    "baseRefOid": "289ad4a08981c4eaf1328ab9d16f184ee0466a34",
2454
    "body": "",
2455
    "changedFiles": 1,
2456
    "closed": true,
2457
    "closedAt": "2021-09-29T15:05:03Z",
2458
    "comments": [
2459
      {
2460
        "id": "IC_kwDOCL0xJc43crZP",
2461
        "author": {
2462
          "login": "gavinhoward"
2463
        },
2464
        "authorAssociation": "OWNER",
2465
        "body": "Looks good! Thank you!",
2466
        "createdAt": "2021-09-29T15:05:16Z",
2467
        "includesCreatedEdit": false,
2468
        "isMinimized": false,
2469
        "minimizedReason": "",
2470
        "reactionGroups": [],
2471
        "url": "https://github.com/gavinhoward/bc/pull/44#issuecomment-930264655",
2472
        "viewerDidAuthor": true
2473
      }
2474
    ],
2475
    "commits": [
2476
      {
2477
        "authoredDate": "2021-09-29T09:33:47Z",
2478
        "authors": [
2479
          {
2480
            "email": "[email protected]",
2481
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2482
            "login": "depler",
2483
            "name": "depler"
2484
          }
2485
        ],
2486
        "committedDate": "2021-09-29T09:33:47Z",
2487
        "messageBody": "",
2488
        "messageHeadline": "tests_bc.bat fix",
2489
        "oid": "2d05fde966b12cee7e02220f1466efd7a78a56c4"
2490
      }
2491
    ],
2492
    "createdAt": "2021-09-29T09:34:23Z",
2493
    "deletions": 7,
2494
    "files": [
2495
      {
2496
        "path": "vs/tests/tests_bc.bat",
2497
        "additions": 7,
2498
        "deletions": 7
2499
      }
2500
    ],
2501
    "fullDatabaseId": "745557688",
2502
    "headRefName": "master",
2503
    "headRefOid": "2d05fde966b12cee7e02220f1466efd7a78a56c4",
2504
    "headRepository": null,
2505
    "headRepositoryOwner": {
2506
      "id": "MDQ6VXNlcjEzNTQxNjk5",
2507
      "login": "depler"
2508
    },
2509
    "id": "PR_kwDOCL0xJc4scE64",
2510
    "isCrossRepository": true,
2511
    "isDraft": false,
2512
    "labels": [],
2513
    "latestReviews": [],
2514
    "maintainerCanModify": false,
2515
    "mergeCommit": {
2516
      "oid": "74d55ddfc79df8adeb70cdb2fc81dc05f8bacbde"
2517
    },
2518
    "mergeStateStatus": "UNKNOWN",
2519
    "mergeable": "UNKNOWN",
2520
    "mergedAt": "2021-09-29T15:05:03Z",
2521
    "mergedBy": {
2522
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2523
      "is_bot": false,
2524
      "login": "gavinhoward",
2525
      "name": "Gavin D. Howard"
2526
    },
2527
    "milestone": null,
2528
    "number": 44,
2529
    "potentialMergeCommit": null,
2530
    "projectCards": [],
2531
    "projectItems": [],
2532
    "reactionGroups": [],
2533
    "reviewDecision": "",
2534
    "reviewRequests": [],
2535
    "reviews": [],
2536
    "state": "MERGED",
2537
    "statusCheckRollup": [],
2538
    "title": "tests_bc.bat fix",
2539
    "updatedAt": "2021-09-29T15:05:16Z",
2540
    "url": "https://github.com/gavinhoward/bc/pull/44"
2541
  },
2542
  {
2543
    "additions": 1017,
2544
    "assignees": [],
2545
    "author": {
2546
      "id": "MDQ6VXNlcjEzNTQxNjk5",
2547
      "is_bot": false,
2548
      "login": "depler",
2549
      "name": ""
2550
    },
2551
    "autoMergeRequest": null,
2552
    "baseRefName": "master",
2553
    "baseRefOid": "da29d88f70dca79c8a7e274b1cb5dee3c4bccb6f",
2554
    "body": "Changes:\r\n- projects moved to subfolder `vs`\r\n- projects created from scratch\r\n- fixed release configuration in executable (code optimizations enabled)\r\n- executable is statically linked (should work without any dependencies starting on Vista and newer)\r\n- library contains configurations `ReleaseMD` and  `ReleaseMT` (shared and static linkage)\r\n- added 'vs\\tests' subfolder with scripts for windows (uses original test files, see `tests_bc.bat`, `tests_dc.bat`)\r\n\r\nBy the way, did you test binaries on windows? I've found failed test for dc:\r\n\r\n```\r\nc:\\Data\\Sources\\bc\\vs\\tests>tests_dc.bat\r\nPASS: abs\r\nPASS: add\r\nPASS: arctangent\r\nPASS: arrays\r\nPASS: assignments\r\n\r\n...\r\n\r\nParse error: bad character 't'\r\n    <stdin>:2\r\n\r\nFAIL_RUNTIME: vars\r\n```\r\n",
2555
    "changedFiles": 15,
2556
    "closed": true,
2557
    "closedAt": "2021-09-25T21:06:56Z",
2558
    "comments": [
2559
      {
2560
        "id": "IC_kwDOCL0xJc43Q7BQ",
2561
        "author": {
2562
          "login": "gavinhoward"
2563
        },
2564
        "authorAssociation": "OWNER",
2565
        "body": "I'm pulling this now because I made the fixes for all issues based on your code.\r\n\r\nI'm probably going to need your help still.",
2566
        "createdAt": "2021-09-25T21:06:52Z",
2567
        "includesCreatedEdit": false,
2568
        "isMinimized": false,
2569
        "minimizedReason": "",
2570
        "reactionGroups": [],
2571
        "url": "https://github.com/gavinhoward/bc/pull/38#issuecomment-927182928",
2572
        "viewerDidAuthor": true
2573
      }
2574
    ],
2575
    "commits": [
2576
      {
2577
        "authoredDate": "2021-09-24T22:42:26Z",
2578
        "authors": [
2579
          {
2580
            "email": "[email protected]",
2581
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2582
            "login": "depler",
2583
            "name": "depler"
2584
          }
2585
        ],
2586
        "committedDate": "2021-09-24T22:42:26Z",
2587
        "messageBody": "",
2588
        "messageHeadline": "new bc.vcxproj, static linkage, release configuration",
2589
        "oid": "ae20dd7c1fedf9a7534aca4fda9783356cd15f86"
2590
      },
2591
      {
2592
        "authoredDate": "2021-09-25T07:07:19Z",
2593
        "authors": [
2594
          {
2595
            "email": "[email protected]",
2596
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2597
            "login": "depler",
2598
            "name": "depler"
2599
          }
2600
        ],
2601
        "committedDate": "2021-09-25T07:07:19Z",
2602
        "messageBody": "",
2603
        "messageHeadline": "bcl project",
2604
        "oid": "1c9479c50217773732f4111e4c3dfbc7e7415c1e"
2605
      },
2606
      {
2607
        "authoredDate": "2021-09-25T07:15:33Z",
2608
        "authors": [
2609
          {
2610
            "email": "[email protected]",
2611
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2612
            "login": "depler",
2613
            "name": "depler"
2614
          }
2615
        ],
2616
        "committedDate": "2021-09-25T07:15:33Z",
2617
        "messageBody": "",
2618
        "messageHeadline": "ReleaseMD, ReleaseMT",
2619
        "oid": "99a58fea193b6bcc1bec4adcd02c53522da20c86"
2620
      },
2621
      {
2622
        "authoredDate": "2021-09-25T07:16:06Z",
2623
        "authors": [
2624
          {
2625
            "email": "[email protected]",
2626
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2627
            "login": "depler",
2628
            "name": "depler"
2629
          }
2630
        ],
2631
        "committedDate": "2021-09-25T07:16:06Z",
2632
        "messageBody": "",
2633
        "messageHeadline": "cleanup",
2634
        "oid": "2230f31c8d4d53223a1dc13b0b399e374e57999f"
2635
      },
2636
      {
2637
        "authoredDate": "2021-09-25T07:20:11Z",
2638
        "authors": [
2639
          {
2640
            "email": "[email protected]",
2641
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2642
            "login": "depler",
2643
            "name": "depler"
2644
          }
2645
        ],
2646
        "committedDate": "2021-09-25T07:20:11Z",
2647
        "messageBody": "",
2648
        "messageHeadline": "fix",
2649
        "oid": "0a08c1a2d382fdf1406eecfc6669d8279810c51a"
2650
      },
2651
      {
2652
        "authoredDate": "2021-09-25T10:48:31Z",
2653
        "authors": [
2654
          {
2655
            "email": "[email protected]",
2656
            "id": "MDQ6VXNlcjEzNTQxNjk5",
2657
            "login": "depler",
2658
            "name": "depler"
2659
          }
2660
        ],
2661
        "committedDate": "2021-09-25T10:48:31Z",
2662
        "messageBody": "",
2663
        "messageHeadline": "windows tests",
2664
        "oid": "2aaf6a7c624b441346200126504e713e1e324553"
2665
      }
2666
    ],
2667
    "createdAt": "2021-09-25T07:27:03Z",
2668
    "deletions": 760,
2669
    "files": [
2670
      {
2671
        "path": "bc.vcxproj",
2672
        "additions": 0,
2673
        "deletions": 278
2674
      },
2675
      {
2676
        "path": "bc.vcxproj.filters",
2677
        "additions": 0,
2678
        "deletions": 182
2679
      },
2680
      {
2681
        "path": "bcl.sln",
2682
        "additions": 0,
2683
        "deletions": 31
2684
      },
2685
      {
2686
        "path": "bcl.vcxproj",
2687
        "additions": 0,
2688
        "deletions": 161
2689
      },
2690
      {
2691
        "path": "bcl.vcxproj.filters",
2692
        "additions": 0,
2693
        "deletions": 96
2694
      },
2695
      {
2696
        "path": "src/program.c",
2697
        "additions": 1,
2698
        "deletions": 1
2699
      },
2700
      {
2701
        "path": "vs/.gitignore",
2702
        "additions": 7,
2703
        "deletions": 0
2704
      },
2705
      {
2706
        "path": "vs/bc.sln",
2707
        "additions": 11,
2708
        "deletions": 11
2709
      },
2710
      {
2711
        "path": "vs/bc.vcxproj",
2712
        "additions": 298,
2713
        "deletions": 0
2714
      },
2715
      {
2716
        "path": "vs/bc.vcxproj.filters",
2717
        "additions": 173,
2718
        "deletions": 0
2719
      },
2720
      {
2721
        "path": "vs/bcl.sln",
2722
        "additions": 37,
2723
        "deletions": 0
2724
      },
2725
      {
2726
        "path": "vs/bcl.vcxproj",
2727
        "additions": 259,
2728
        "deletions": 0
2729
      },
2730
      {
2731
        "path": "vs/bcl.vcxproj.filters",
2732
        "additions": 90,
2733
        "deletions": 0
2734
      },
2735
      {
2736
        "path": "vs/tests/tests_bc.bat",
2737
        "additions": 81,
2738
        "deletions": 0
2739
      },
2740
      {
2741
        "path": "vs/tests/tests_dc.bat",
2742
        "additions": 60,
2743
        "deletions": 0
2744
      }
2745
    ],
2746
    "fullDatabaseId": "742640199",
2747
    "headRefName": "master",
2748
    "headRefOid": "2aaf6a7c624b441346200126504e713e1e324553",
2749
    "headRepository": null,
2750
    "headRepositoryOwner": {
2751
      "id": "MDQ6VXNlcjEzNTQxNjk5",
2752
      "login": "depler"
2753
    },
2754
    "id": "PR_kwDOCL0xJc4sQ8pH",
2755
    "isCrossRepository": true,
2756
    "isDraft": false,
2757
    "labels": [],
2758
    "latestReviews": [],
2759
    "maintainerCanModify": false,
2760
    "mergeCommit": {
2761
      "oid": "d3793fa5a17c198482baeee027464b98a3869270"
2762
    },
2763
    "mergeStateStatus": "UNKNOWN",
2764
    "mergeable": "UNKNOWN",
2765
    "mergedAt": "2021-09-25T21:06:56Z",
2766
    "mergedBy": {
2767
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2768
      "is_bot": false,
2769
      "login": "gavinhoward",
2770
      "name": "Gavin D. Howard"
2771
    },
2772
    "milestone": null,
2773
    "number": 38,
2774
    "potentialMergeCommit": null,
2775
    "projectCards": [],
2776
    "projectItems": [],
2777
    "reactionGroups": [],
2778
    "reviewDecision": "",
2779
    "reviewRequests": [],
2780
    "reviews": [],
2781
    "state": "MERGED",
2782
    "statusCheckRollup": [],
2783
    "title": "Visual Studio projects refactoring",
2784
    "updatedAt": "2021-09-25T21:06:56Z",
2785
    "url": "https://github.com/gavinhoward/bc/pull/38"
2786
  },
2787
  {
2788
    "additions": 1,
2789
    "assignees": [],
2790
    "author": {
2791
      "id": "MDQ6VXNlcjM4ODMzNTE=",
2792
      "is_bot": false,
2793
      "login": "ibara",
2794
      "name": "Brian Callahan"
2795
    },
2796
    "autoMergeRequest": null,
2797
    "baseRefName": "master",
2798
    "baseRefOid": "3317fc9138148ac48beb4886206be45ebac2a838",
2799
    "body": "on => one",
2800
    "changedFiles": 1,
2801
    "closed": true,
2802
    "closedAt": "2020-03-11T17:36:56Z",
2803
    "comments": [
2804
      {
2805
        "id": "MDEyOklzc3VlQ29tbWVudDU5NzcwNjM0Nw==",
2806
        "author": {
2807
          "login": "codecov"
2808
        },
2809
        "authorAssociation": "NONE",
2810
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=h1) Report\n> Merging [#28](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/3317fc9138148ac48beb4886206be45ebac2a838&el=desc) will **not change** coverage by `%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/28/graphs/tree.svg?width=650&height=150&src=pr&token=7VDYTvCBQX)](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #28   +/-   ##\n=======================================\n  Coverage   99.65%   99.65%           \n=======================================\n  Files          16       16           \n  Lines        3497     3497           \n=======================================\n  Hits         3485     3485           \n  Misses         12       12           \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=footer). Last update [3317fc9...24c93ff](https://codecov.io/gh/gavinhoward/bc/pull/28?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
2811
        "createdAt": "2020-03-11T15:39:52Z",
2812
        "includesCreatedEdit": true,
2813
        "isMinimized": false,
2814
        "minimizedReason": "",
2815
        "reactionGroups": [],
2816
        "url": "https://github.com/gavinhoward/bc/pull/28#issuecomment-597706347",
2817
        "viewerDidAuthor": false
2818
      },
2819
      {
2820
        "id": "MDEyOklzc3VlQ29tbWVudDU5Nzc3MTUwMw==",
2821
        "author": {
2822
          "login": "gavinhoward"
2823
        },
2824
        "authorAssociation": "OWNER",
2825
        "body": "Thank you! Merged.",
2826
        "createdAt": "2020-03-11T17:39:45Z",
2827
        "includesCreatedEdit": false,
2828
        "isMinimized": false,
2829
        "minimizedReason": "",
2830
        "reactionGroups": [],
2831
        "url": "https://github.com/gavinhoward/bc/pull/28#issuecomment-597771503",
2832
        "viewerDidAuthor": true
2833
      }
2834
    ],
2835
    "commits": [
2836
      {
2837
        "authoredDate": "2020-03-11T15:37:45Z",
2838
        "authors": [
2839
          {
2840
            "email": "[email protected]",
2841
            "id": "MDQ6VXNlcjM4ODMzNTE=",
2842
            "login": "ibara",
2843
            "name": "Brian Callahan"
2844
          }
2845
        ],
2846
        "committedDate": "2020-03-11T15:37:45Z",
2847
        "messageBody": "on => one",
2848
        "messageHeadline": "Fix a typo in build.md",
2849
        "oid": "24c93ffc52bfcae55f3b694e9684b49a105834e7"
2850
      }
2851
    ],
2852
    "createdAt": "2020-03-11T15:37:54Z",
2853
    "deletions": 1,
2854
    "files": [
2855
      {
2856
        "path": "manuals/build.md",
2857
        "additions": 1,
2858
        "deletions": 1
2859
      }
2860
    ],
2861
    "fullDatabaseId": "386765314",
2862
    "headRefName": "patch-1",
2863
    "headRefOid": "24c93ffc52bfcae55f3b694e9684b49a105834e7",
2864
    "headRepository": null,
2865
    "headRepositoryOwner": {
2866
      "id": "MDQ6VXNlcjM4ODMzNTE=",
2867
      "name": "Brian Callahan",
2868
      "login": "ibara"
2869
    },
2870
    "id": "MDExOlB1bGxSZXF1ZXN0Mzg2NzY1MzE0",
2871
    "isCrossRepository": true,
2872
    "isDraft": false,
2873
    "labels": [],
2874
    "latestReviews": [],
2875
    "maintainerCanModify": false,
2876
    "mergeCommit": {
2877
      "oid": "725f14b41767d34e6be02fa07dc2db659fa55b02"
2878
    },
2879
    "mergeStateStatus": "UNKNOWN",
2880
    "mergeable": "UNKNOWN",
2881
    "mergedAt": "2020-03-11T17:36:56Z",
2882
    "mergedBy": {
2883
      "id": "MDQ6VXNlcjMxNzI2ODc=",
2884
      "is_bot": false,
2885
      "login": "gavinhoward",
2886
      "name": "Gavin D. Howard"
2887
    },
2888
    "milestone": null,
2889
    "number": 28,
2890
    "potentialMergeCommit": null,
2891
    "projectCards": [],
2892
    "projectItems": [],
2893
    "reactionGroups": [],
2894
    "reviewDecision": "",
2895
    "reviewRequests": [],
2896
    "reviews": [],
2897
    "state": "MERGED",
2898
    "statusCheckRollup": [],
2899
    "title": "Fix a typo in build.md",
2900
    "updatedAt": "2020-03-11T18:18:12Z",
2901
    "url": "https://github.com/gavinhoward/bc/pull/28"
2902
  },
2903
  {
2904
    "additions": 86,
2905
    "assignees": [],
2906
    "author": {
2907
      "id": "MDQ6VXNlcjMwOTE2NjEz",
2908
      "is_bot": false,
2909
      "login": "zv-io",
2910
      "name": ""
2911
    },
2912
    "autoMergeRequest": null,
2913
    "baseRefName": "master",
2914
    "baseRefOid": "358951d4fa58db3077a5675a6547c44e41101de9",
2915
    "body": "This series addresses some bugs found on Solaris as discussed with the author in IRC earlier today. The following systems have been \"loosely\" tested to compile and pass the non-external-`bc` test suite:\r\n\r\n* Solaris 10 [sun4u] (GCC `5.5.0`) in both 32- and 64- bit modes;\r\n* Solaris 11 [sun4v] (GCC `4.8.2` and `7.5.0`) in both 32- and 64- bit modes;\r\n\r\nNote: Solaris 10 requires aliasing to a POSIX-compliant shell (e.g. `/usr/xpg4/bin/sh`) or modifying the top of any scripts citing `/bin/sh` to this value.",
2916
    "changedFiles": 62,
2917
    "closed": true,
2918
    "closedAt": "2020-01-15T22:33:33Z",
2919
    "comments": [
2920
      {
2921
        "id": "MDEyOklzc3VlQ29tbWVudDU3NDQ5NzI3Mw==",
2922
        "author": {
2923
          "login": "codecov"
2924
        },
2925
        "authorAssociation": "NONE",
2926
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=h1) Report\n> Merging [#27](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/358951d4fa58db3077a5675a6547c44e41101de9?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/27/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #27   +/-   ##\n=======================================\n  Coverage   99.65%   99.65%           \n=======================================\n  Files          16       16           \n  Lines        3496     3496           \n=======================================\n  Hits         3484     3484           \n  Misses         12       12\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/bc/parse.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL2JjL3BhcnNlLmM=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/parse.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/read.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL3JlYWQuYw==) | `100% <ø> (ø)` | :arrow_up: |\n| [src/vm.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL3ZtLmM=) | `99.59% <ø> (ø)` | :arrow_up: |\n| [src/main.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL21haW4uYw==) | `100% <ø> (ø)` | :arrow_up: |\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.41% <ø> (ø)` | :arrow_up: |\n| [src/lex.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL2xleC5j) | `100% <ø> (ø)` | :arrow_up: |\n| [src/bc/bc.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL2JjL2JjLmM=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/bc/lex.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL2JjL2xleC5j) | `100% <ø> (ø)` | :arrow_up: |\n| [src/lang.c](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree#diff-c3JjL2xhbmcuYw==) | `97.33% <ø> (ø)` | :arrow_up: |\n| ... and [6 more](https://codecov.io/gh/gavinhoward/bc/pull/27/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=footer). Last update [358951d...a756285](https://codecov.io/gh/gavinhoward/bc/pull/27?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
2927
        "createdAt": "2020-01-15T05:02:18Z",
2928
        "includesCreatedEdit": true,
2929
        "isMinimized": false,
2930
        "minimizedReason": "",
2931
        "reactionGroups": [],
2932
        "url": "https://github.com/gavinhoward/bc/pull/27#issuecomment-574497273",
2933
        "viewerDidAuthor": false
2934
      }
2935
    ],
2936
    "commits": [
2937
      {
2938
        "authoredDate": "2020-01-14T21:56:45Z",
2939
        "authors": [
2940
          {
2941
            "email": "[email protected]",
2942
            "id": "MDQ6VXNlcjMwOTE2NjEz",
2943
            "login": "zv-io",
2944
            "name": "Zach van Rijn"
2945
          }
2946
        ],
2947
        "committedDate": "2020-01-14T22:17:19Z",
2948
        "messageBody": "",
2949
        "messageHeadline": "Fix bug caused by inconsistent preservation of line endings by 'sed'.",
2950
        "oid": "d3b3813c94d6553caad61752dd7ac99dd860e20c"
2951
      },
2952
      {
2953
        "authoredDate": "2020-01-14T22:03:42Z",
2954
        "authors": [
2955
          {
2956
            "email": "[email protected]",
2957
            "id": "MDQ6VXNlcjMwOTE2NjEz",
2958
            "login": "zv-io",
2959
            "name": "Zach van Rijn"
2960
          }
2961
        ],
2962
        "committedDate": "2020-01-14T22:17:26Z",
2963
        "messageBody": "…'ls' command. Improve robustness of test conditions.",
2964
        "messageHeadline": "Switch from POSIX 2008 --> 2001 build flags. Remove use of dangerous …",
2965
        "oid": "72238e589bf7e8cb6a9bb380f367c1a5edcc8b82"
2966
      },
2967
      {
2968
        "authoredDate": "2020-01-14T22:05:02Z",
2969
        "authors": [
2970
          {
2971
            "email": "[email protected]",
2972
            "id": "MDQ6VXNlcjMwOTE2NjEz",
2973
            "login": "zv-io",
2974
            "name": "Zach van Rijn"
2975
          }
2976
        ],
2977
        "committedDate": "2020-01-14T22:17:27Z",
2978
        "messageBody": "",
2979
        "messageHeadline": "Update copyright year 2019 --> 2020.",
2980
        "oid": "eb34ee5e9d5607c08e7080d9c44e03d393756493"
2981
      },
2982
      {
2983
        "authoredDate": "2020-01-14T22:24:01Z",
2984
        "authors": [
2985
          {
2986
            "email": "[email protected]",
2987
            "id": "MDQ6VXNlcjMwOTE2NjEz",
2988
            "login": "zv-io",
2989
            "name": "Zach van Rijn"
2990
          }
2991
        ],
2992
        "committedDate": "2020-01-14T22:24:01Z",
2993
        "messageBody": "…sions.",
2994
        "messageHeadline": "Explicit '-std=c99' to avoid ambiguity across different compilers/ver…",
2995
        "oid": "a38469fd93c20d1de3f972c982de3c234000116a"
2996
      },
2997
      {
2998
        "authoredDate": "2020-01-14T22:57:04Z",
2999
        "authors": [
3000
          {
3001
            "email": "[email protected]",
3002
            "id": "MDQ6VXNlcjMwOTE2NjEz",
3003
            "login": "zv-io",
3004
            "name": "Zach van Rijn"
3005
          }
3006
        ],
3007
        "committedDate": "2020-01-14T22:59:48Z",
3008
        "messageBody": "",
3009
        "messageHeadline": "Update documentation and prepare for release.",
3010
        "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3011
      },
3012
      {
3013
        "authoredDate": "2020-01-15T13:56:00Z",
3014
        "authors": [
3015
          {
3016
            "email": "[email protected]",
3017
            "id": "MDQ6VXNlcjMwOTE2NjEz",
3018
            "login": "zv-io",
3019
            "name": "Zach van Rijn"
3020
          }
3021
        ],
3022
        "committedDate": "2020-01-15T13:56:00Z",
3023
        "messageBody": "…lers/versions.\"\n\nThis reverts commit a38469fd93c20d1de3f972c982de3c234000116a.",
3024
        "messageHeadline": "Revert \"Explicit '-std=c99' to avoid ambiguity across different compi…",
3025
        "oid": "8b83e334177701cd2c05fd10090a1f582bd7e9f8"
3026
      },
3027
      {
3028
        "authoredDate": "2020-01-15T13:57:24Z",
3029
        "authors": [
3030
          {
3031
            "email": "[email protected]",
3032
            "id": "MDQ6VXNlcjMwOTE2NjEz",
3033
            "login": "zv-io",
3034
            "name": "Zach van Rijn"
3035
          }
3036
        ],
3037
        "committedDate": "2020-01-15T13:57:24Z",
3038
        "messageBody": "",
3039
        "messageHeadline": "Comply with versioning policy as per author feedback in PR 27.",
3040
        "oid": "a756285f60b2139fc629c3edf230c8b1f9a875ed"
3041
      }
3042
    ],
3043
    "createdAt": "2020-01-15T04:59:12Z",
3044
    "deletions": 79,
3045
    "files": [
3046
      {
3047
        "path": "Makefile.in",
3048
        "additions": 3,
3049
        "deletions": 3
3050
      },
3051
      {
3052
        "path": "NEWS.md",
3053
        "additions": 6,
3054
        "deletions": 0
3055
      },
3056
      {
3057
        "path": "README.md",
3058
        "additions": 3,
3059
        "deletions": 2
3060
      },
3061
      {
3062
        "path": "configure.sh",
3063
        "additions": 12,
3064
        "deletions": 12
3065
      },
3066
      {
3067
        "path": "functions.sh",
3068
        "additions": 3,
3069
        "deletions": 3
3070
      },
3071
      {
3072
        "path": "gen/bc_help.txt",
3073
        "additions": 1,
3074
        "deletions": 1
3075
      },
3076
      {
3077
        "path": "gen/dc_help.txt",
3078
        "additions": 1,
3079
        "deletions": 1
3080
      },
3081
      {
3082
        "path": "gen/lib.bc",
3083
        "additions": 1,
3084
        "deletions": 1
3085
      },
3086
      {
3087
        "path": "gen/lib2.bc",
3088
        "additions": 1,
3089
        "deletions": 1
3090
      },
3091
      {
3092
        "path": "gen/strgen.c",
3093
        "additions": 2,
3094
        "deletions": 2
3095
      },
3096
      {
3097
        "path": "include/args.h",
3098
        "additions": 1,
3099
        "deletions": 1
3100
      },
3101
      {
3102
        "path": "include/bc.h",
3103
        "additions": 1,
3104
        "deletions": 1
3105
      },
3106
      {
3107
        "path": "include/dc.h",
3108
        "additions": 1,
3109
        "deletions": 1
3110
      },
3111
      {
3112
        "path": "include/history.h",
3113
        "additions": 1,
3114
        "deletions": 1
3115
      },
3116
      {
3117
        "path": "include/lang.h",
3118
        "additions": 1,
3119
        "deletions": 1
3120
      },
3121
      {
3122
        "path": "include/lex.h",
3123
        "additions": 1,
3124
        "deletions": 1
3125
      },
3126
      {
3127
        "path": "include/num.h",
3128
        "additions": 1,
3129
        "deletions": 1
3130
      },
3131
      {
3132
        "path": "include/parse.h",
3133
        "additions": 1,
3134
        "deletions": 1
3135
      },
3136
      {
3137
        "path": "include/program.h",
3138
        "additions": 1,
3139
        "deletions": 1
3140
      },
3141
      {
3142
        "path": "include/read.h",
3143
        "additions": 1,
3144
        "deletions": 1
3145
      },
3146
      {
3147
        "path": "include/status.h",
3148
        "additions": 1,
3149
        "deletions": 1
3150
      },
3151
      {
3152
        "path": "include/vector.h",
3153
        "additions": 1,
3154
        "deletions": 1
3155
      },
3156
      {
3157
        "path": "include/vm.h",
3158
        "additions": 1,
3159
        "deletions": 1
3160
      },
3161
      {
3162
        "path": "install.sh",
3163
        "additions": 1,
3164
        "deletions": 1
3165
      },
3166
      {
3167
        "path": "karatsuba.py",
3168
        "additions": 1,
3169
        "deletions": 1
3170
      },
3171
      {
3172
        "path": "link.sh",
3173
        "additions": 1,
3174
        "deletions": 1
3175
      },
3176
      {
3177
        "path": "locale_install.sh",
3178
        "additions": 1,
3179
        "deletions": 1
3180
      },
3181
      {
3182
        "path": "locale_uninstall.sh",
3183
        "additions": 1,
3184
        "deletions": 1
3185
      },
3186
      {
3187
        "path": "locales/en_US.msg",
3188
        "additions": 1,
3189
        "deletions": 1
3190
      },
3191
      {
3192
        "path": "locales/fr_FR.ISO8859-1.msg",
3193
        "additions": 1,
3194
        "deletions": 1
3195
      },
3196
      {
3197
        "path": "locales/fr_FR.UTF-8.msg",
3198
        "additions": 1,
3199
        "deletions": 1
3200
      },
3201
      {
3202
        "path": "locales/pt_PT.ISO-8859-1.msg",
3203
        "additions": 1,
3204
        "deletions": 1
3205
      },
3206
      {
3207
        "path": "locales/pt_PT.UTF-8.msg",
3208
        "additions": 1,
3209
        "deletions": 1
3210
      },
3211
      {
3212
        "path": "release.sh",
3213
        "additions": 1,
3214
        "deletions": 1
3215
      },
3216
      {
3217
        "path": "src/args.c",
3218
        "additions": 1,
3219
        "deletions": 1
3220
      },
3221
      {
3222
        "path": "src/bc/bc.c",
3223
        "additions": 1,
3224
        "deletions": 1
3225
      },
3226
      {
3227
        "path": "src/bc/lex.c",
3228
        "additions": 1,
3229
        "deletions": 1
3230
      },
3231
      {
3232
        "path": "src/bc/parse.c",
3233
        "additions": 1,
3234
        "deletions": 1
3235
      },
3236
      {
3237
        "path": "src/data.c",
3238
        "additions": 2,
3239
        "deletions": 2
3240
      },
3241
      {
3242
        "path": "src/dc/dc.c",
3243
        "additions": 1,
3244
        "deletions": 1
3245
      },
3246
      {
3247
        "path": "src/dc/lex.c",
3248
        "additions": 1,
3249
        "deletions": 1
3250
      },
3251
      {
3252
        "path": "src/dc/parse.c",
3253
        "additions": 1,
3254
        "deletions": 1
3255
      },
3256
      {
3257
        "path": "src/history/history.c",
3258
        "additions": 1,
3259
        "deletions": 1
3260
      },
3261
      {
3262
        "path": "src/lang.c",
3263
        "additions": 1,
3264
        "deletions": 1
3265
      },
3266
      {
3267
        "path": "src/lex.c",
3268
        "additions": 1,
3269
        "deletions": 1
3270
      },
3271
      {
3272
        "path": "src/main.c",
3273
        "additions": 1,
3274
        "deletions": 1
3275
      },
3276
      {
3277
        "path": "src/num.c",
3278
        "additions": 1,
3279
        "deletions": 1
3280
      },
3281
      {
3282
        "path": "src/parse.c",
3283
        "additions": 1,
3284
        "deletions": 1
3285
      },
3286
      {
3287
        "path": "src/program.c",
3288
        "additions": 1,
3289
        "deletions": 1
3290
      },
3291
      {
3292
        "path": "src/read.c",
3293
        "additions": 1,
3294
        "deletions": 1
3295
      },
3296
      {
3297
        "path": "src/vector.c",
3298
        "additions": 1,
3299
        "deletions": 1
3300
      },
3301
      {
3302
        "path": "src/vm.c",
3303
        "additions": 1,
3304
        "deletions": 1
3305
      },
3306
      {
3307
        "path": "tests/afl.py",
3308
        "additions": 1,
3309
        "deletions": 1
3310
      },
3311
      {
3312
        "path": "tests/all.sh",
3313
        "additions": 1,
3314
        "deletions": 1
3315
      },
3316
      {
3317
        "path": "tests/bc/timeconst.sh",
3318
        "additions": 1,
3319
        "deletions": 1
3320
      },
3321
      {
3322
        "path": "tests/errors.sh",
3323
        "additions": 1,
3324
        "deletions": 1
3325
      },
3326
      {
3327
        "path": "tests/randmath.py",
3328
        "additions": 1,
3329
        "deletions": 1
3330
      },
3331
      {
3332
        "path": "tests/read.sh",
3333
        "additions": 1,
3334
        "deletions": 1
3335
      },
3336
      {
3337
        "path": "tests/script.sh",
3338
        "additions": 1,
3339
        "deletions": 1
3340
      },
3341
      {
3342
        "path": "tests/scripts.sh",
3343
        "additions": 1,
3344
        "deletions": 1
3345
      },
3346
      {
3347
        "path": "tests/stdin.sh",
3348
        "additions": 1,
3349
        "deletions": 1
3350
      },
3351
      {
3352
        "path": "tests/test.sh",
3353
        "additions": 1,
3354
        "deletions": 1
3355
      }
3356
    ],
3357
    "fullDatabaseId": "362957298",
3358
    "headRefName": "master",
3359
    "headRefOid": "a756285f60b2139fc629c3edf230c8b1f9a875ed",
3360
    "headRepository": null,
3361
    "headRepositoryOwner": {
3362
      "id": "MDQ6VXNlcjMwOTE2NjEz",
3363
      "login": "zv-io"
3364
    },
3365
    "id": "MDExOlB1bGxSZXF1ZXN0MzYyOTU3Mjk4",
3366
    "isCrossRepository": true,
3367
    "isDraft": false,
3368
    "labels": [],
3369
    "latestReviews": [
3370
      {
3371
        "id": "",
3372
        "author": {
3373
          "login": "michaelforney"
3374
        },
3375
        "authorAssociation": "CONTRIBUTOR",
3376
        "body": "",
3377
        "submittedAt": "2020-01-15T06:00:48Z",
3378
        "includesCreatedEdit": false,
3379
        "reactionGroups": [],
3380
        "state": "COMMENTED",
3381
        "commit": {
3382
          "oid": ""
3383
        }
3384
      },
3385
      {
3386
        "id": "",
3387
        "author": {
3388
          "login": "ibara"
3389
        },
3390
        "authorAssociation": "CONTRIBUTOR",
3391
        "body": "",
3392
        "submittedAt": "2020-01-15T20:20:03Z",
3393
        "includesCreatedEdit": false,
3394
        "reactionGroups": [],
3395
        "state": "COMMENTED",
3396
        "commit": {
3397
          "oid": ""
3398
        }
3399
      },
3400
      {
3401
        "id": "",
3402
        "author": {
3403
          "login": "gavinhoward"
3404
        },
3405
        "authorAssociation": "OWNER",
3406
        "body": "",
3407
        "submittedAt": "2020-01-15T22:33:19Z",
3408
        "includesCreatedEdit": false,
3409
        "reactionGroups": [],
3410
        "state": "APPROVED",
3411
        "commit": {
3412
          "oid": ""
3413
        }
3414
      }
3415
    ],
3416
    "maintainerCanModify": false,
3417
    "mergeCommit": {
3418
      "oid": "063a155d1ee6c68bfba37733777ad1331810fdf1"
3419
    },
3420
    "mergeStateStatus": "UNKNOWN",
3421
    "mergeable": "UNKNOWN",
3422
    "mergedAt": "2020-01-15T22:33:33Z",
3423
    "mergedBy": {
3424
      "id": "MDQ6VXNlcjMxNzI2ODc=",
3425
      "is_bot": false,
3426
      "login": "gavinhoward",
3427
      "name": "Gavin D. Howard"
3428
    },
3429
    "milestone": null,
3430
    "number": 27,
3431
    "potentialMergeCommit": null,
3432
    "projectCards": [],
3433
    "projectItems": [],
3434
    "reactionGroups": [],
3435
    "reviewDecision": "APPROVED",
3436
    "reviewRequests": [],
3437
    "reviews": [
3438
      {
3439
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQyOTk0NDA3",
3440
        "author": {
3441
          "login": "gavinhoward"
3442
        },
3443
        "authorAssociation": "OWNER",
3444
        "body": "Thank you for this PR! Unfortunately, it needs some work before I can accept it. See reviews below.",
3445
        "submittedAt": "2020-01-15T05:32:13Z",
3446
        "includesCreatedEdit": false,
3447
        "reactionGroups": [],
3448
        "state": "CHANGES_REQUESTED",
3449
        "commit": {
3450
          "oid": "d3b3813c94d6553caad61752dd7ac99dd860e20c"
3451
        }
3452
      },
3453
      {
3454
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMDAyMDEx",
3455
        "author": {
3456
          "login": "michaelforney"
3457
        },
3458
        "authorAssociation": "CONTRIBUTOR",
3459
        "body": "",
3460
        "submittedAt": "2020-01-15T06:00:48Z",
3461
        "includesCreatedEdit": false,
3462
        "reactionGroups": [],
3463
        "state": "COMMENTED",
3464
        "commit": {
3465
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3466
        }
3467
      },
3468
      {
3469
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMDAyNTYx",
3470
        "author": {
3471
          "login": "gavinhoward"
3472
        },
3473
        "authorAssociation": "OWNER",
3474
        "body": "",
3475
        "submittedAt": "2020-01-15T06:02:59Z",
3476
        "includesCreatedEdit": false,
3477
        "reactionGroups": [],
3478
        "state": "COMMENTED",
3479
        "commit": {
3480
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3481
        }
3482
      },
3483
      {
3484
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMDEwNjM1",
3485
        "author": {
3486
          "login": "gavinhoward"
3487
        },
3488
        "authorAssociation": "OWNER",
3489
        "body": "",
3490
        "submittedAt": "2020-01-15T06:34:47Z",
3491
        "includesCreatedEdit": false,
3492
        "reactionGroups": [],
3493
        "state": "COMMENTED",
3494
        "commit": {
3495
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3496
        }
3497
      },
3498
      {
3499
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjM5MTU3",
3500
        "author": {
3501
          "login": "zv-io"
3502
        },
3503
        "authorAssociation": "CONTRIBUTOR",
3504
        "body": "",
3505
        "submittedAt": "2020-01-15T14:04:17Z",
3506
        "includesCreatedEdit": false,
3507
        "reactionGroups": [],
3508
        "state": "COMMENTED",
3509
        "commit": {
3510
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3511
        }
3512
      },
3513
      {
3514
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjQ0ODg5",
3515
        "author": {
3516
          "login": "zv-io"
3517
        },
3518
        "authorAssociation": "CONTRIBUTOR",
3519
        "body": "",
3520
        "submittedAt": "2020-01-15T14:12:43Z",
3521
        "includesCreatedEdit": false,
3522
        "reactionGroups": [],
3523
        "state": "COMMENTED",
3524
        "commit": {
3525
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3526
        }
3527
      },
3528
      {
3529
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjU1NTQ0",
3530
        "author": {
3531
          "login": "zv-io"
3532
        },
3533
        "authorAssociation": "CONTRIBUTOR",
3534
        "body": "",
3535
        "submittedAt": "2020-01-15T14:27:10Z",
3536
        "includesCreatedEdit": false,
3537
        "reactionGroups": [],
3538
        "state": "COMMENTED",
3539
        "commit": {
3540
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3541
        }
3542
      },
3543
      {
3544
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjU2MjE0",
3545
        "author": {
3546
          "login": "zv-io"
3547
        },
3548
        "authorAssociation": "CONTRIBUTOR",
3549
        "body": "",
3550
        "submittedAt": "2020-01-15T14:28:02Z",
3551
        "includesCreatedEdit": false,
3552
        "reactionGroups": [],
3553
        "state": "COMMENTED",
3554
        "commit": {
3555
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3556
        }
3557
      },
3558
      {
3559
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjczNTgx",
3560
        "author": {
3561
          "login": "gavinhoward"
3562
        },
3563
        "authorAssociation": "OWNER",
3564
        "body": "",
3565
        "submittedAt": "2020-01-15T14:50:50Z",
3566
        "includesCreatedEdit": false,
3567
        "reactionGroups": [],
3568
        "state": "COMMENTED",
3569
        "commit": {
3570
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3571
        }
3572
      },
3573
      {
3574
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzMjc3MTQ4",
3575
        "author": {
3576
          "login": "gavinhoward"
3577
        },
3578
        "authorAssociation": "OWNER",
3579
        "body": "",
3580
        "submittedAt": "2020-01-15T14:55:18Z",
3581
        "includesCreatedEdit": false,
3582
        "reactionGroups": [],
3583
        "state": "COMMENTED",
3584
        "commit": {
3585
          "oid": "f022d5dedc841bb1d23fa2e03fdc97a639de700d"
3586
        }
3587
      },
3588
      {
3589
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNDk1MzQ1",
3590
        "author": {
3591
          "login": "ibara"
3592
        },
3593
        "authorAssociation": "CONTRIBUTOR",
3594
        "body": "",
3595
        "submittedAt": "2020-01-15T20:20:03Z",
3596
        "includesCreatedEdit": false,
3597
        "reactionGroups": [],
3598
        "state": "COMMENTED",
3599
        "commit": {
3600
          "oid": "a756285f60b2139fc629c3edf230c8b1f9a875ed"
3601
        }
3602
      },
3603
      {
3604
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNDk5ODcx",
3605
        "author": {
3606
          "login": "gavinhoward"
3607
        },
3608
        "authorAssociation": "OWNER",
3609
        "body": "",
3610
        "submittedAt": "2020-01-15T20:28:14Z",
3611
        "includesCreatedEdit": false,
3612
        "reactionGroups": [],
3613
        "state": "COMMENTED",
3614
        "commit": {
3615
          "oid": "a756285f60b2139fc629c3edf230c8b1f9a875ed"
3616
        }
3617
      },
3618
      {
3619
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNTY3ODE3",
3620
        "author": {
3621
          "login": "gavinhoward"
3622
        },
3623
        "authorAssociation": "OWNER",
3624
        "body": "",
3625
        "submittedAt": "2020-01-15T22:33:01Z",
3626
        "includesCreatedEdit": false,
3627
        "reactionGroups": [],
3628
        "state": "COMMENTED",
3629
        "commit": {
3630
          "oid": "a756285f60b2139fc629c3edf230c8b1f9a875ed"
3631
        }
3632
      },
3633
      {
3634
        "id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNTY3OTcx",
3635
        "author": {
3636
          "login": "gavinhoward"
3637
        },
3638
        "authorAssociation": "OWNER",
3639
        "body": "",
3640
        "submittedAt": "2020-01-15T22:33:19Z",
3641
        "includesCreatedEdit": false,
3642
        "reactionGroups": [],
3643
        "state": "APPROVED",
3644
        "commit": {
3645
          "oid": "a756285f60b2139fc629c3edf230c8b1f9a875ed"
3646
        }
3647
      }
3648
    ],
3649
    "state": "MERGED",
3650
    "statusCheckRollup": [],
3651
    "title": "Improve portability, enable build on Solaris SPARC.",
3652
    "updatedAt": "2020-01-15T22:33:33Z",
3653
    "url": "https://github.com/gavinhoward/bc/pull/27"
3654
  },
3655
  {
3656
    "additions": 218,
3657
    "assignees": [],
3658
    "author": {
3659
      "id": "MDQ6VXNlcjM5NzU3OTY3",
3660
      "is_bot": false,
3661
      "login": "bugcrazy",
3662
      "name": ""
3663
    },
3664
    "autoMergeRequest": null,
3665
    "baseRefName": "master",
3666
    "baseRefOid": "39b0dc440325511db730ad8fbd7012ba6f3f4b4d",
3667
    "body": "Portuguese Translations pt_PT and pt_BR",
3668
    "changedFiles": 8,
3669
    "closed": true,
3670
    "closedAt": "2020-01-14T15:08:19Z",
3671
    "comments": [
3672
      {
3673
        "id": "MDEyOklzc3VlQ29tbWVudDU3NDAyODE2Nw==",
3674
        "author": {
3675
          "login": "codecov"
3676
        },
3677
        "authorAssociation": "NONE",
3678
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=h1) Report\n> Merging [#26](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/39b0dc440325511db730ad8fbd7012ba6f3f4b4d?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/26/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #26   +/-   ##\n=======================================\n  Coverage   99.65%   99.65%           \n=======================================\n  Files          16       16           \n  Lines        3496     3496           \n=======================================\n  Hits         3484     3484           \n  Misses         12       12\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=footer). Last update [39b0dc4...2572333](https://codecov.io/gh/gavinhoward/bc/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
3679
        "createdAt": "2020-01-14T06:43:10Z",
3680
        "includesCreatedEdit": true,
3681
        "isMinimized": false,
3682
        "minimizedReason": "",
3683
        "reactionGroups": [],
3684
        "url": "https://github.com/gavinhoward/bc/pull/26#issuecomment-574028167",
3685
        "viewerDidAuthor": false
3686
      },
3687
      {
3688
        "id": "MDEyOklzc3VlQ29tbWVudDU3NDIxOTEzMg==",
3689
        "author": {
3690
          "login": "gavinhoward"
3691
        },
3692
        "authorAssociation": "OWNER",
3693
        "body": "Thank you for your translations! They look good. Release of Version `2.5.0` with the translations will happen in a few minutes.",
3694
        "createdAt": "2020-01-14T15:09:22Z",
3695
        "includesCreatedEdit": false,
3696
        "isMinimized": false,
3697
        "minimizedReason": "",
3698
        "reactionGroups": [],
3699
        "url": "https://github.com/gavinhoward/bc/pull/26#issuecomment-574219132",
3700
        "viewerDidAuthor": true
3701
      },
3702
      {
3703
        "id": "MDEyOklzc3VlQ29tbWVudDU3NDIyMzU0Mw==",
3704
        "author": {
3705
          "login": "gavinhoward"
3706
        },
3707
        "authorAssociation": "OWNER",
3708
        "body": "Version `2.5.0` is out with your translations. Thank you!",
3709
        "createdAt": "2020-01-14T15:17:19Z",
3710
        "includesCreatedEdit": false,
3711
        "isMinimized": false,
3712
        "minimizedReason": "",
3713
        "reactionGroups": [
3714
          {
3715
            "content": "THUMBS_UP",
3716
            "users": {
3717
              "totalCount": 1
3718
            }
3719
          }
3720
        ],
3721
        "url": "https://github.com/gavinhoward/bc/pull/26#issuecomment-574223543",
3722
        "viewerDidAuthor": true
3723
      },
3724
      {
3725
        "id": "MDEyOklzc3VlQ29tbWVudDU3NDI0MTA2Mw==",
3726
        "author": {
3727
          "login": "bugcrazy"
3728
        },
3729
        "authorAssociation": "CONTRIBUTOR",
3730
        "body": "Thank you!",
3731
        "createdAt": "2020-01-14T15:52:18Z",
3732
        "includesCreatedEdit": false,
3733
        "isMinimized": false,
3734
        "minimizedReason": "",
3735
        "reactionGroups": [],
3736
        "url": "https://github.com/gavinhoward/bc/pull/26#issuecomment-574241063",
3737
        "viewerDidAuthor": false
3738
      }
3739
    ],
3740
    "commits": [
3741
      {
3742
        "authoredDate": "2020-01-14T06:32:59Z",
3743
        "authors": [
3744
          {
3745
            "email": "[email protected]",
3746
            "id": "MDQ6VXNlcjM5NzU3OTY3",
3747
            "login": "bugcrazy",
3748
            "name": "bugcrazy"
3749
          }
3750
        ],
3751
        "committedDate": "2020-01-14T06:32:59Z",
3752
        "messageBody": "Portuguese Translations pt_PT and pt_BR",
3753
        "messageHeadline": "Portuguese Translations",
3754
        "oid": "25723337b998ced4976dc5beae8717d81056dc5f"
3755
      }
3756
    ],
3757
    "createdAt": "2020-01-14T06:40:25Z",
3758
    "deletions": 0,
3759
    "files": [
3760
      {
3761
        "path": "locales/pt_BR.ISO-8859-1.msg",
3762
        "additions": 1,
3763
        "deletions": 0
3764
      },
3765
      {
3766
        "path": "locales/pt_BR.ISO-8859-15.msg",
3767
        "additions": 1,
3768
        "deletions": 0
3769
      },
3770
      {
3771
        "path": "locales/pt_BR.UTF-8.msg",
3772
        "additions": 1,
3773
        "deletions": 0
3774
      },
3775
      {
3776
        "path": "locales/pt_BR.utf8.msg",
3777
        "additions": 1,
3778
        "deletions": 0
3779
      },
3780
      {
3781
        "path": "locales/pt_PT.ISO-8859-1.msg",
3782
        "additions": 106,
3783
        "deletions": 0
3784
      },
3785
      {
3786
        "path": "locales/pt_PT.ISO-8859-15.msg",
3787
        "additions": 1,
3788
        "deletions": 0
3789
      },
3790
      {
3791
        "path": "locales/pt_PT.UTF-8.msg",
3792
        "additions": 106,
3793
        "deletions": 0
3794
      },
3795
      {
3796
        "path": "locales/pt_PT.utf8.msg",
3797
        "additions": 1,
3798
        "deletions": 0
3799
      }
3800
    ],
3801
    "fullDatabaseId": "362470901",
3802
    "headRefName": "master",
3803
    "headRefOid": "25723337b998ced4976dc5beae8717d81056dc5f",
3804
    "headRepository": {
3805
      "id": "MDEwOlJlcG9zaXRvcnkyMzM3NjI4NjY=",
3806
      "name": "bc"
3807
    },
3808
    "headRepositoryOwner": {
3809
      "id": "MDQ6VXNlcjM5NzU3OTY3",
3810
      "login": "bugcrazy"
3811
    },
3812
    "id": "MDExOlB1bGxSZXF1ZXN0MzYyNDcwOTAx",
3813
    "isCrossRepository": true,
3814
    "isDraft": false,
3815
    "labels": [],
3816
    "latestReviews": [],
3817
    "maintainerCanModify": false,
3818
    "mergeCommit": {
3819
      "oid": "c322c80e62415e69c8d65c69904a0e1ea37f4da3"
3820
    },
3821
    "mergeStateStatus": "UNKNOWN",
3822
    "mergeable": "UNKNOWN",
3823
    "mergedAt": "2020-01-14T15:08:19Z",
3824
    "mergedBy": {
3825
      "id": "MDQ6VXNlcjMxNzI2ODc=",
3826
      "is_bot": false,
3827
      "login": "gavinhoward",
3828
      "name": "Gavin D. Howard"
3829
    },
3830
    "milestone": null,
3831
    "number": 26,
3832
    "potentialMergeCommit": null,
3833
    "projectCards": [],
3834
    "projectItems": [],
3835
    "reactionGroups": [],
3836
    "reviewDecision": "",
3837
    "reviewRequests": [],
3838
    "reviews": [],
3839
    "state": "MERGED",
3840
    "statusCheckRollup": [],
3841
    "title": "Portuguese Translations",
3842
    "updatedAt": "2020-01-14T15:52:18Z",
3843
    "url": "https://github.com/gavinhoward/bc/pull/26"
3844
  },
3845
  {
3846
    "additions": 6,
3847
    "assignees": [],
3848
    "author": {
3849
      "id": "MDQ6VXNlcjIyMjk2NzA2",
3850
      "is_bot": false,
3851
      "login": "eg15",
3852
      "name": "Eugene Gladchenko"
3853
    },
3854
    "autoMergeRequest": null,
3855
    "baseRefName": "master",
3856
    "baseRefOid": "38cc5145cb66ba9f1706630d5f987d60a46fb1b1",
3857
    "body": "Looks like I found a bug.\r\n\"-1000000000 < -1\" returns 0 (false) on my machine which is obviously wrong.\r\nThe fix will follow.",
3858
    "changedFiles": 4,
3859
    "closed": true,
3860
    "closedAt": "2019-11-22T04:42:08Z",
3861
    "comments": [
3862
      {
3863
        "id": "MDEyOklzc3VlQ29tbWVudDU1NzE0ODY4Mw==",
3864
        "author": {
3865
          "login": "codecov"
3866
        },
3867
        "authorAssociation": "NONE",
3868
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=h1) Report\n> Merging [#25](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/38cc5145cb66ba9f1706630d5f987d60a46fb1b1?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/25/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #25   +/-   ##\n=======================================\n  Coverage   99.71%   99.71%           \n=======================================\n  Files          16       16           \n  Lines        3478     3478           \n=======================================\n  Hits         3468     3468           \n  Misses         10       10\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/25/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.41% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=footer). Last update [38cc514...96518d8](https://codecov.io/gh/gavinhoward/bc/pull/25?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
3869
        "createdAt": "2019-11-21T15:56:12Z",
3870
        "includesCreatedEdit": true,
3871
        "isMinimized": false,
3872
        "minimizedReason": "",
3873
        "reactionGroups": [],
3874
        "url": "https://github.com/gavinhoward/bc/pull/25#issuecomment-557148683",
3875
        "viewerDidAuthor": false
3876
      },
3877
      {
3878
        "id": "MDEyOklzc3VlQ29tbWVudDU1NzE2MDgyMg==",
3879
        "author": {
3880
          "login": "gavinhoward"
3881
        },
3882
        "authorAssociation": "OWNER",
3883
        "body": "Yes, you did find a bug.\r\n\r\nYour fix looks great, and your tests do as well. I just have two requests:\r\n\r\n1. Move your tests and results into files called `comp.txt` and `comp_results.txt`.\r\n2. Change the name in `tests/bc/all.txt`.\r\n\r\nI want you to do this because I am going to write a more comprehensive set of tests for comparisons in general to make sure I did not miss anything else.\r\n\r\nIf you don't have the time to do this, I could always pull it and do the change myself.",
3884
        "createdAt": "2019-11-21T16:22:26Z",
3885
        "includesCreatedEdit": false,
3886
        "isMinimized": false,
3887
        "minimizedReason": "",
3888
        "reactionGroups": [],
3889
        "url": "https://github.com/gavinhoward/bc/pull/25#issuecomment-557160822",
3890
        "viewerDidAuthor": true
3891
      },
3892
      {
3893
        "id": "MDEyOklzc3VlQ29tbWVudDU1NzIwNjQwNw==",
3894
        "author": {
3895
          "login": "eg15"
3896
        },
3897
        "authorAssociation": "CONTRIBUTOR",
3898
        "body": "Just finished, thank you.\r\n\r\nBTW it looks like busybox guys took your code and kept the bug in their modified version.\r\nJust fixed it there as well: https://bugs.busybox.net/show_bug.cgi?id=12336\r\n\r\nThen it should be fixed in Alpine (that's where I encountered it this morning).",
3899
        "createdAt": "2019-11-21T18:10:24Z",
3900
        "includesCreatedEdit": true,
3901
        "isMinimized": false,
3902
        "minimizedReason": "",
3903
        "reactionGroups": [],
3904
        "url": "https://github.com/gavinhoward/bc/pull/25#issuecomment-557206407",
3905
        "viewerDidAuthor": false
3906
      },
3907
      {
3908
        "id": "MDEyOklzc3VlQ29tbWVudDU1NzIzMDk2NA==",
3909
        "author": {
3910
          "login": "gavinhoward"
3911
        },
3912
        "authorAssociation": "OWNER",
3913
        "body": "`busybox` didn't exactly take my code; I gave them my code, when it had a lot more bugs as well. Unfortunately, they decided to go their own way with it, so I don't really contribute back. (They added even more bugs.)\r\n\r\nI will merge this when I get home from work. I should have a release out after testing, which could take up to a week. I don't expect this to take that long to test, since it's so small, but I may find other problems.",
3914
        "createdAt": "2019-11-21T19:14:33Z",
3915
        "includesCreatedEdit": false,
3916
        "isMinimized": false,
3917
        "minimizedReason": "",
3918
        "reactionGroups": [],
3919
        "url": "https://github.com/gavinhoward/bc/pull/25#issuecomment-557230964",
3920
        "viewerDidAuthor": true
3921
      },
3922
      {
3923
        "id": "MDEyOklzc3VlQ29tbWVudDU1NzM4NjYzOQ==",
3924
        "author": {
3925
          "login": "gavinhoward"
3926
        },
3927
        "authorAssociation": "OWNER",
3928
        "body": "I pulled manually. Thank you for your help!",
3929
        "createdAt": "2019-11-22T04:44:22Z",
3930
        "includesCreatedEdit": false,
3931
        "isMinimized": false,
3932
        "minimizedReason": "",
3933
        "reactionGroups": [
3934
          {
3935
            "content": "THUMBS_UP",
3936
            "users": {
3937
              "totalCount": 1
3938
            }
3939
          }
3940
        ],
3941
        "url": "https://github.com/gavinhoward/bc/pull/25#issuecomment-557386639",
3942
        "viewerDidAuthor": true
3943
      }
3944
    ],
3945
    "commits": [
3946
      {
3947
        "authoredDate": "2019-11-21T15:31:00Z",
3948
        "authors": [
3949
          {
3950
            "email": "[email protected]",
3951
            "id": "MDQ6VXNlcjIyMjk2NzA2",
3952
            "login": "eg15",
3953
            "name": "Eugene Gladchenko"
3954
          }
3955
        ],
3956
        "committedDate": "2019-11-21T15:31:00Z",
3957
        "messageBody": "",
3958
        "messageHeadline": "Add a test to compare negative numbers",
3959
        "oid": "888c422c21b558d3778d4ad215fd54f9387a137b"
3960
      },
3961
      {
3962
        "authoredDate": "2019-11-21T16:00:43Z",
3963
        "authors": [
3964
          {
3965
            "email": "[email protected]",
3966
            "id": "MDQ6VXNlcjIyMjk2NzA2",
3967
            "login": "eg15",
3968
            "name": "Eugene Gladchenko"
3969
          }
3970
        ],
3971
        "committedDate": "2019-11-21T16:00:43Z",
3972
        "messageBody": "",
3973
        "messageHeadline": "Fix a bug in comparing negative numbers",
3974
        "oid": "ddbecaa0601375b86dffb525973148cdd0dda8f7"
3975
      },
3976
      {
3977
        "authoredDate": "2019-11-21T18:05:15Z",
3978
        "authors": [
3979
          {
3980
            "email": "[email protected]",
3981
            "id": "MDQ6VXNlcjIyMjk2NzA2",
3982
            "login": "eg15",
3983
            "name": "Eugene Gladchenko"
3984
          }
3985
        ],
3986
        "committedDate": "2019-11-21T18:05:15Z",
3987
        "messageBody": "",
3988
        "messageHeadline": "The name of the test file changed",
3989
        "oid": "96518d8fd63fca1d01b82ac78a42251844f39201"
3990
      }
3991
    ],
3992
    "createdAt": "2019-11-21T15:52:02Z",
3993
    "deletions": 1,
3994
    "files": [
3995
      {
3996
        "path": "src/num.c",
3997
        "additions": 1,
3998
        "deletions": 1
3999
      },
4000
      {
4001
        "path": "tests/bc/all.txt",
4002
        "additions": 1,
4003
        "deletions": 0
4004
      },
4005
      {
4006
        "path": "tests/bc/comp.txt",
4007
        "additions": 2,
4008
        "deletions": 0
4009
      },
4010
      {
4011
        "path": "tests/bc/comp_results.txt",
4012
        "additions": 2,
4013
        "deletions": 0
4014
      }
4015
    ],
4016
    "fullDatabaseId": "344102387",
4017
    "headRefName": "master",
4018
    "headRefOid": "96518d8fd63fca1d01b82ac78a42251844f39201",
4019
    "headRepository": {
4020
      "id": "MDEwOlJlcG9zaXRvcnkyMjMyMDIxNDg=",
4021
      "name": "bc"
4022
    },
4023
    "headRepositoryOwner": {
4024
      "id": "MDQ6VXNlcjIyMjk2NzA2",
4025
      "name": "Eugene Gladchenko",
4026
      "login": "eg15"
4027
    },
4028
    "id": "MDExOlB1bGxSZXF1ZXN0MzQ0MTAyMzg3",
4029
    "isCrossRepository": true,
4030
    "isDraft": false,
4031
    "labels": [],
4032
    "latestReviews": [],
4033
    "maintainerCanModify": false,
4034
    "mergeCommit": {
4035
      "oid": "96518d8fd63fca1d01b82ac78a42251844f39201"
4036
    },
4037
    "mergeStateStatus": "UNKNOWN",
4038
    "mergeable": "UNKNOWN",
4039
    "mergedAt": "2019-11-22T04:42:07Z",
4040
    "mergedBy": {
4041
      "id": "MDQ6VXNlcjMxNzI2ODc=",
4042
      "is_bot": false,
4043
      "login": "gavinhoward",
4044
      "name": "Gavin D. Howard"
4045
    },
4046
    "milestone": null,
4047
    "number": 25,
4048
    "potentialMergeCommit": null,
4049
    "projectCards": [],
4050
    "projectItems": [],
4051
    "reactionGroups": [],
4052
    "reviewDecision": "",
4053
    "reviewRequests": [],
4054
    "reviews": [],
4055
    "state": "MERGED",
4056
    "statusCheckRollup": [],
4057
    "title": "Add a test to compare negative numbers",
4058
    "updatedAt": "2019-11-22T04:44:22Z",
4059
    "url": "https://github.com/gavinhoward/bc/pull/25"
4060
  },
4061
  {
4062
    "additions": 43,
4063
    "assignees": [],
4064
    "author": {
4065
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4066
      "is_bot": false,
4067
      "login": "stesser",
4068
      "name": "Stefan Eßer"
4069
    },
4070
    "autoMergeRequest": null,
4071
    "baseRefName": "master",
4072
    "baseRefOid": "b6cc5efba0e127c5a344c25505c807865494cc66",
4073
    "body": "I do not know how to restrict the pull request to just the two commits I consider relevant (probably is the GIT way to create a temporary branch for that purpose?)\r\n\r\nThe relevant commits are: \r\n\r\nca56e06\r\n684e3f6",
4074
    "changedFiles": 3,
4075
    "closed": true,
4076
    "closedAt": "2019-06-14T01:43:15Z",
4077
    "comments": [
4078
      {
4079
        "id": "MDEyOklzc3VlQ29tbWVudDUwMTgzMTY1Ng==",
4080
        "author": {
4081
          "login": "codecov"
4082
        },
4083
        "authorAssociation": "NONE",
4084
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=h1) Report\n> Merging [#24](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/b6cc5efba0e127c5a344c25505c807865494cc66?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/24/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #24      +/-   ##\n==========================================\n+ Coverage   99.73%   99.73%   +<.01%     \n==========================================\n  Files          16       16              \n  Lines        3431     3435       +4     \n==========================================\n+ Hits         3422     3426       +4     \n  Misses          9        9\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/bc/parse.c](https://codecov.io/gh/gavinhoward/bc/pull/24/diff?src=pr&el=tree#diff-c3JjL2JjL3BhcnNlLmM=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/program.c](https://codecov.io/gh/gavinhoward/bc/pull/24/diff?src=pr&el=tree#diff-c3JjL3Byb2dyYW0uYw==) | `99.73% <100%> (ø)` | :arrow_up: |\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/24/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.8% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=footer). Last update [b6cc5ef...ca56e06](https://codecov.io/gh/gavinhoward/bc/pull/24?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
4085
        "createdAt": "2019-06-13T18:43:42Z",
4086
        "includesCreatedEdit": true,
4087
        "isMinimized": false,
4088
        "minimizedReason": "",
4089
        "reactionGroups": [],
4090
        "url": "https://github.com/gavinhoward/bc/pull/24#issuecomment-501831656",
4091
        "viewerDidAuthor": false
4092
      },
4093
      {
4094
        "id": "MDEyOklzc3VlQ29tbWVudDUwMTg1MDQyMQ==",
4095
        "author": {
4096
          "login": "gavinhoward"
4097
        },
4098
        "authorAssociation": "OWNER",
4099
        "body": "I have already made these changes in my local branch. I just haven't pushed them yet. I will push them when I get home from work, and I will close this then to remind me.\r\n\r\nThank you.",
4100
        "createdAt": "2019-06-13T19:39:54Z",
4101
        "includesCreatedEdit": false,
4102
        "isMinimized": false,
4103
        "minimizedReason": "",
4104
        "reactionGroups": [],
4105
        "url": "https://github.com/gavinhoward/bc/pull/24#issuecomment-501850421",
4106
        "viewerDidAuthor": true
4107
      },
4108
      {
4109
        "id": "MDEyOklzc3VlQ29tbWVudDUwMTkzNzA0Ng==",
4110
        "author": {
4111
          "login": "gavinhoward"
4112
        },
4113
        "authorAssociation": "OWNER",
4114
        "body": "Changes are pushed.",
4115
        "createdAt": "2019-06-14T01:43:15Z",
4116
        "includesCreatedEdit": false,
4117
        "isMinimized": false,
4118
        "minimizedReason": "",
4119
        "reactionGroups": [],
4120
        "url": "https://github.com/gavinhoward/bc/pull/24#issuecomment-501937046",
4121
        "viewerDidAuthor": true
4122
      }
4123
    ],
4124
    "commits": [
4125
      {
4126
        "authoredDate": "2019-06-09T11:10:39Z",
4127
        "authors": [
4128
          {
4129
            "email": "[email protected]",
4130
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4131
            "login": "stesser",
4132
            "name": "Stefan Esser"
4133
          }
4134
        ],
4135
        "committedDate": "2019-06-09T11:10:39Z",
4136
        "messageBody": "",
4137
        "messageHeadline": "Small optimization: no data to copy for BC_RESULT_ONE or _LAST",
4138
        "oid": "b32b26ca8a533480155a427906025cbe9a0c061c"
4139
      },
4140
      {
4141
        "authoredDate": "2019-06-10T21:15:49Z",
4142
        "authors": [
4143
          {
4144
            "email": "[email protected]",
4145
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4146
            "login": "stesser",
4147
            "name": "Stefan Esser"
4148
          }
4149
        ],
4150
        "committedDate": "2019-06-10T21:15:49Z",
4151
        "messageBody": "",
4152
        "messageHeadline": "Make limit for extension of division results depend on BC_BASE_DIGS",
4153
        "oid": "1846088a5d37f02e608228e4214ed76464abdd05"
4154
      },
4155
      {
4156
        "authoredDate": "2019-06-10T21:17:33Z",
4157
        "authors": [
4158
          {
4159
            "email": "[email protected]",
4160
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4161
            "login": "stesser",
4162
            "name": "Stefan Esser"
4163
          }
4164
        ],
4165
        "committedDate": "2019-06-10T21:17:33Z",
4166
        "messageBody": "",
4167
        "messageHeadline": "Simplify and speed up parsing of decimal numbers",
4168
        "oid": "5954930eb013ed5e10bea2599735f06b05b89caa"
4169
      },
4170
      {
4171
        "authoredDate": "2019-06-12T10:16:50Z",
4172
        "authors": [
4173
          {
4174
            "email": "[email protected]",
4175
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4176
            "login": "stesser",
4177
            "name": "Stefan Esser"
4178
          }
4179
        ],
4180
        "committedDate": "2019-06-12T10:16:50Z",
4181
        "messageBody": "Do not allocate one BcDig per character of the string passed in.\nFor ibase between 11 and 26 (decimal) more than one BcDig may be\nneeded to store the value expressed by BC_BASE_DIGS characters.\n\nTesting for that case will probably cause more overhead than just\napplying a fudge factor (not verified - special casing the ibase\nrange that needs this factor and using a factor of 1.5 instead of\n2 might be worth the extra code complexity).",
4182
        "messageHeadline": "Fix allocation size for parsed number",
4183
        "oid": "c2dc7941ee0115ba8e820685021d70ab2ab13a91"
4184
      },
4185
      {
4186
        "authoredDate": "2019-06-12T10:25:11Z",
4187
        "authors": [
4188
          {
4189
            "email": "[email protected]",
4190
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4191
            "login": "stesser",
4192
            "name": "Stefan Esser"
4193
          }
4194
        ],
4195
        "committedDate": "2019-06-12T10:25:11Z",
4196
        "messageBody": "",
4197
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
4198
        "oid": "036b112a9d04b56b98ba3697e1641afa6352bbeb"
4199
      },
4200
      {
4201
        "authoredDate": "2019-06-12T12:00:07Z",
4202
        "authors": [
4203
          {
4204
            "email": "[email protected]",
4205
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4206
            "login": "stesser",
4207
            "name": "Stefan Esser"
4208
          }
4209
        ],
4210
        "committedDate": "2019-06-12T12:00:07Z",
4211
        "messageBody": "This change improves \"make test\" performance by more than 2%.",
4212
        "messageHeadline": "Better estimate of the number of BcDigs required to store a constant",
4213
        "oid": "43caceec40e4265edc8244b092bd39ba483361c5"
4214
      },
4215
      {
4216
        "authoredDate": "2019-06-12T21:43:54Z",
4217
        "authors": [
4218
          {
4219
            "email": "[email protected]",
4220
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4221
            "login": "stesser",
4222
            "name": "Stefan Esser"
4223
          }
4224
        ],
4225
        "committedDate": "2019-06-12T21:43:54Z",
4226
        "messageBody": "This implementation is not optimized for speed, yet. I have plans to\nadd copy-on-write semantics for BcNums (i.e. add a reference count and\ncopy the BcNum only if its refcount is > 1 it is about to be\nmodified).\n\nThis version fails in the bc/stdin test, but diagnosing this problem\nwill have to wait for tomorrow ...",
4227
        "messageHeadline": "Implement caching of numeric constants in vectors of BcNums",
4228
        "oid": "515dfe44886667eb9fbea48c214b559549d69417"
4229
      },
4230
      {
4231
        "authoredDate": "2019-06-13T08:23:45Z",
4232
        "authors": [
4233
          {
4234
            "email": "[email protected]",
4235
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4236
            "login": "stesser",
4237
            "name": "Stefan Esser"
4238
          }
4239
        ],
4240
        "committedDate": "2019-06-13T08:23:45Z",
4241
        "messageBody": "Beyond the changes performed by the automatic merge, remove references\nto the constvals field in struct BcFunc.",
4242
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
4243
        "oid": "cd30020d2fe2d4cef802b2e65299f4e0e1a3972f"
4244
      },
4245
      {
4246
        "authoredDate": "2019-06-13T08:33:21Z",
4247
        "authors": [
4248
          {
4249
            "email": "[email protected]",
4250
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4251
            "login": "stesser",
4252
            "name": "Stefan Esser"
4253
          }
4254
        ],
4255
        "committedDate": "2019-06-13T08:33:21Z",
4256
        "messageBody": "",
4257
        "messageHeadline": "Merge more changes from upstream",
4258
        "oid": "21e4395740342aa65e728d02e1a5d658a9a15bc0"
4259
      },
4260
      {
4261
        "authoredDate": "2019-06-13T08:49:54Z",
4262
        "authors": [
4263
          {
4264
            "email": "[email protected]",
4265
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4266
            "login": "stesser",
4267
            "name": "Stefan Esser"
4268
          }
4269
        ],
4270
        "committedDate": "2019-06-13T08:49:54Z",
4271
        "messageBody": "",
4272
        "messageHeadline": "Adjust whitespace and use value of \"base\" instead of fetching it again",
4273
        "oid": "684e3f6f8a7dd8efb5b49211ef20948710cf6457"
4274
      },
4275
      {
4276
        "authoredDate": "2019-06-13T09:14:04Z",
4277
        "authors": [
4278
          {
4279
            "email": "[email protected]",
4280
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4281
            "login": "stesser",
4282
            "name": "Stefan Esser"
4283
          }
4284
        ],
4285
        "committedDate": "2019-06-13T09:14:04Z",
4286
        "messageBody": "",
4287
        "messageHeadline": "Fix for failing scale(0.0000000000000000000) test case",
4288
        "oid": "25799a6fa21c69cb7f9e77e53329d3b735564c9b"
4289
      },
4290
      {
4291
        "authoredDate": "2019-06-13T11:05:20Z",
4292
        "authors": [
4293
          {
4294
            "email": "[email protected]",
4295
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4296
            "login": "stesser",
4297
            "name": "Stefan Esser"
4298
          }
4299
        ],
4300
        "committedDate": "2019-06-13T11:05:20Z",
4301
        "messageBody": "FreeBSD uses strict checks for base system components and the build\nfailed due to the compiler warnings being treated as errors in base.",
4302
        "messageHeadline": "Remove unused local variable declarations (fix build in FreeBSD)",
4303
        "oid": "ca56e060a471ed5476a78b38c1b2d0584777d693"
4304
      }
4305
    ],
4306
    "createdAt": "2019-06-13T18:39:56Z",
4307
    "deletions": 49,
4308
    "files": [
4309
      {
4310
        "path": "src/bc/parse.c",
4311
        "additions": 0,
4312
        "deletions": 2
4313
      },
4314
      {
4315
        "path": "src/num.c",
4316
        "additions": 37,
4317
        "deletions": 39
4318
      },
4319
      {
4320
        "path": "src/program.c",
4321
        "additions": 6,
4322
        "deletions": 8
4323
      }
4324
    ],
4325
    "fullDatabaseId": "288048911",
4326
    "headRefName": "master",
4327
    "headRefOid": "ca56e060a471ed5476a78b38c1b2d0584777d693",
4328
    "headRepository": {
4329
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
4330
      "name": "bc"
4331
    },
4332
    "headRepositoryOwner": {
4333
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4334
      "name": "Stefan Eßer",
4335
      "login": "stesser"
4336
    },
4337
    "id": "MDExOlB1bGxSZXF1ZXN0Mjg4MDQ4OTEx",
4338
    "isCrossRepository": true,
4339
    "isDraft": false,
4340
    "labels": [],
4341
    "latestReviews": [],
4342
    "maintainerCanModify": false,
4343
    "mergeCommit": null,
4344
    "mergeStateStatus": "DIRTY",
4345
    "mergeable": "CONFLICTING",
4346
    "mergedAt": null,
4347
    "mergedBy": null,
4348
    "milestone": null,
4349
    "number": 24,
4350
    "potentialMergeCommit": null,
4351
    "projectCards": [],
4352
    "projectItems": [],
4353
    "reactionGroups": [],
4354
    "reviewDecision": "",
4355
    "reviewRequests": [],
4356
    "reviews": [],
4357
    "state": "CLOSED",
4358
    "statusCheckRollup": [],
4359
    "title": "Whitespace adjustment and removal of some unused variables",
4360
    "updatedAt": "2019-06-14T01:43:15Z",
4361
    "url": "https://github.com/gavinhoward/bc/pull/24"
4362
  },
4363
  {
4364
    "additions": 1,
4365
    "assignees": [],
4366
    "author": {
4367
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4368
      "is_bot": false,
4369
      "login": "stesser",
4370
      "name": "Stefan Eßer"
4371
    },
4372
    "autoMergeRequest": null,
4373
    "baseRefName": "master",
4374
    "baseRefOid": "f555270c99e7d354704071628486df0870968286",
4375
    "body": "Benchmarks show a small but significant speed-up of \"make test\" if the\r\nlimit for the shifting of operands is made more strict. Many operands\r\nwill require a second iteration of the inner loop anyway, and shifting\r\nof the operands uses cycles for no gain, then.\r\n\r\nTo my surprise, BC_BASE_DIGS=4 and =9 seem to have near identical\r\nperformance after this change. Some operations (multiplication and\r\npower) ought to be faster with larger BcDigs, but at least for the\r\nperformance of \"make test\" on my system this does not seem to affect\r\nthe run-time by a significant amount.",
4376
    "changedFiles": 1,
4377
    "closed": true,
4378
    "closedAt": "2019-06-07T13:25:25Z",
4379
    "comments": [
4380
      {
4381
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTg4MzYwNQ==",
4382
        "author": {
4383
          "login": "gavinhoward"
4384
        },
4385
        "authorAssociation": "OWNER",
4386
        "body": "I am not planning on future releases, except for bug fixes. I will merge this now.",
4387
        "createdAt": "2019-06-07T13:25:27Z",
4388
        "includesCreatedEdit": false,
4389
        "isMinimized": false,
4390
        "minimizedReason": "",
4391
        "reactionGroups": [],
4392
        "url": "https://github.com/gavinhoward/bc/pull/23#issuecomment-499883605",
4393
        "viewerDidAuthor": true
4394
      }
4395
    ],
4396
    "commits": [
4397
      {
4398
        "authoredDate": "2019-06-07T07:33:26Z",
4399
        "authors": [
4400
          {
4401
            "email": "[email protected]",
4402
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4403
            "login": "stesser",
4404
            "name": "Stefan Esser"
4405
          }
4406
        ],
4407
        "committedDate": "2019-06-07T07:33:26Z",
4408
        "messageBody": "Benchmarks show a small but significant speed-up of \"make test\" if the\nlimit for the shifting of operands is made more strict. Many operands\nwill require a second iteration of the inner loop anyway, and shifting\nof the operands uses cycles for no gain, then.\n\nTo my surprise, BC_BASE_DIGS=4 and =9 seem to have near identical\nperformance after this change. Some operations (multiplication and\npower) ought to be faster with larger BcDigs, but at least for the\nperformance of \"make test\" on my system this does not seem to affect\nthe run-time by a significant amount.",
4409
        "messageHeadline": "Small performance optimization",
4410
        "oid": "d8526df195150f9f20ed4e8430dff3457e5d2913"
4411
      }
4412
    ],
4413
    "createdAt": "2019-06-07T08:28:48Z",
4414
    "deletions": 1,
4415
    "files": [
4416
      {
4417
        "path": "src/num.c",
4418
        "additions": 1,
4419
        "deletions": 1
4420
      }
4421
    ],
4422
    "fullDatabaseId": "286093193",
4423
    "headRefName": "master",
4424
    "headRefOid": "d8526df195150f9f20ed4e8430dff3457e5d2913",
4425
    "headRepository": {
4426
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
4427
      "name": "bc"
4428
    },
4429
    "headRepositoryOwner": {
4430
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4431
      "name": "Stefan Eßer",
4432
      "login": "stesser"
4433
    },
4434
    "id": "MDExOlB1bGxSZXF1ZXN0Mjg2MDkzMTkz",
4435
    "isCrossRepository": true,
4436
    "isDraft": false,
4437
    "labels": [],
4438
    "latestReviews": [],
4439
    "maintainerCanModify": false,
4440
    "mergeCommit": {
4441
      "oid": "6f662190645f8fb84b36a513b1369a8bf61e215e"
4442
    },
4443
    "mergeStateStatus": "UNKNOWN",
4444
    "mergeable": "UNKNOWN",
4445
    "mergedAt": "2019-06-07T13:25:25Z",
4446
    "mergedBy": {
4447
      "id": "MDQ6VXNlcjMxNzI2ODc=",
4448
      "is_bot": false,
4449
      "login": "gavinhoward",
4450
      "name": "Gavin D. Howard"
4451
    },
4452
    "milestone": null,
4453
    "number": 23,
4454
    "potentialMergeCommit": null,
4455
    "projectCards": [],
4456
    "projectItems": [],
4457
    "reactionGroups": [],
4458
    "reviewDecision": "",
4459
    "reviewRequests": [],
4460
    "reviews": [],
4461
    "state": "MERGED",
4462
    "statusCheckRollup": [],
4463
    "title": "Small performance optimization (perhaps for the next following release?)",
4464
    "updatedAt": "2019-06-07T13:25:28Z",
4465
    "url": "https://github.com/gavinhoward/bc/pull/23"
4466
  },
4467
  {
4468
    "additions": 38,
4469
    "assignees": [],
4470
    "author": {
4471
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4472
      "is_bot": false,
4473
      "login": "stesser",
4474
      "name": "Stefan Eßer"
4475
    },
4476
    "autoMergeRequest": null,
4477
    "baseRefName": "master",
4478
    "baseRefOid": "7373e5f89c9ce873eb1a84f129c1f9be3b1ec400",
4479
    "body": "",
4480
    "changedFiles": 1,
4481
    "closed": true,
4482
    "closedAt": "2019-06-07T04:04:59Z",
4483
    "comments": [
4484
      {
4485
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTY2Nzc4Nw==",
4486
        "author": {
4487
          "login": "codecov"
4488
        },
4489
        "authorAssociation": "NONE",
4490
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=h1) Report\n> Merging [#22](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/7373e5f89c9ce873eb1a84f129c1f9be3b1ec400?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/22/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #22      +/-   ##\n==========================================\n+ Coverage   99.73%   99.73%   +<.01%     \n==========================================\n  Files          16       16              \n  Lines        3392     3409      +17     \n==========================================\n+ Hits         3383     3400      +17     \n  Misses          9        9\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/22/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.8% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=footer). Last update [7373e5f...98719ee](https://codecov.io/gh/gavinhoward/bc/pull/22?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
4491
        "createdAt": "2019-06-06T21:06:55Z",
4492
        "includesCreatedEdit": true,
4493
        "isMinimized": false,
4494
        "minimizedReason": "",
4495
        "reactionGroups": [],
4496
        "url": "https://github.com/gavinhoward/bc/pull/22#issuecomment-499667787",
4497
        "viewerDidAuthor": false
4498
      },
4499
      {
4500
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTc0OTQ5MQ==",
4501
        "author": {
4502
          "login": "gavinhoward"
4503
        },
4504
        "authorAssociation": "OWNER",
4505
        "body": "Merging...for now. If it passes (which I think it will), it will stay.",
4506
        "createdAt": "2019-06-07T04:05:18Z",
4507
        "includesCreatedEdit": false,
4508
        "isMinimized": false,
4509
        "minimizedReason": "",
4510
        "reactionGroups": [],
4511
        "url": "https://github.com/gavinhoward/bc/pull/22#issuecomment-499749491",
4512
        "viewerDidAuthor": true
4513
      }
4514
    ],
4515
    "commits": [
4516
      {
4517
        "authoredDate": "2019-06-06T05:13:40Z",
4518
        "authors": [
4519
          {
4520
            "email": "[email protected]",
4521
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4522
            "login": "stesser",
4523
            "name": "Stefan Esser"
4524
          }
4525
        ],
4526
        "committedDate": "2019-06-06T05:13:40Z",
4527
        "messageBody": "Since stdout is not affected by this debug print function, nchars\nshould not be modified, or printing of large numbers will be broken.",
4528
        "messageHeadline": "Resetting of nchars after printing to stderr corrupts the output",
4529
        "oid": "76794442357318437574ec8c0aa3f71903ec419a"
4530
      },
4531
      {
4532
        "authoredDate": "2019-06-06T06:14:43Z",
4533
        "authors": [
4534
          {
4535
            "email": "[email protected]",
4536
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4537
            "login": "stesser",
4538
            "name": "Stefan Esser"
4539
          }
4540
        ],
4541
        "committedDate": "2019-06-06T06:14:43Z",
4542
        "messageBody": "If the top-most BcDig contains a small value and there are lower\nnon-zero BcDigs, the integer divisor is incremented to prevent\ndivision results that do not fit into a BcDig (are > BC_BASE_POW).\n\nE.g. for 1000 / 1.1 the integer divisor will become 2 and the first\nestimate of the result will be 1000 / 2 = 500, giving a reminder of\n1000 - 500 * 1.1 = 450. The next estimate will be 700 = 500 + 450 / 2\nand so on with the reminder slowly decreasing in each iteration.\n\nSince the relative error due to the approximation of the full division\nby an integer division becomes significant for small integer divisors,\nit makes sense to extend the divisor if it i ssmall. In fact, it seems\nto pay off for all divisors that are < BC_BASE_POW / 10.",
4543
        "messageHeadline": "Fix pathological behavior in case integer is rounded up a lot",
4544
        "oid": "035ace7d24afd722ce9a3325c90213d36772e5bd"
4545
      },
4546
      {
4547
        "authoredDate": "2019-06-06T06:25:29Z",
4548
        "authors": [
4549
          {
4550
            "email": "[email protected]",
4551
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4552
            "login": "stesser",
4553
            "name": "Stefan Esser"
4554
          }
4555
        ],
4556
        "committedDate": "2019-06-06T06:25:29Z",
4557
        "messageBody": "",
4558
        "messageHeadline": "Merge branch 'div'",
4559
        "oid": "c1e655b2dd38ea27668b3a0c5b7c86ef06a8dd88"
4560
      },
4561
      {
4562
        "authoredDate": "2019-06-06T08:21:51Z",
4563
        "authors": [
4564
          {
4565
            "email": "[email protected]",
4566
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4567
            "login": "stesser",
4568
            "name": "Stefan Esser"
4569
          }
4570
        ],
4571
        "committedDate": "2019-06-06T08:21:51Z",
4572
        "messageBody": "If there was a new-line character in the string, then strrchr will\nreturn a pointer to that character. If the length of the string\nstarting at the new-line position is 1, then no text follows on the\nnew line and nchars should be set to 0,not 2.",
4573
        "messageHeadline": "Fix calculation of nchars",
4574
        "oid": "54e3cd86494fd1e2c817ea3fa49c357738da5f82"
4575
      },
4576
      {
4577
        "authoredDate": "2019-06-06T11:32:50Z",
4578
        "authors": [
4579
          {
4580
            "email": "[email protected]",
4581
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4582
            "login": "stesser",
4583
            "name": "Stefan Esser"
4584
          }
4585
        ],
4586
        "committedDate": "2019-06-06T11:32:50Z",
4587
        "messageBody": "This reverts commit 54e3cd86494fd1e2c817ea3fa49c357738da5f82.\n\nI had misread the code (thought the + 1 was outside the brackets).",
4588
        "messageHeadline": "Revert \"Fix calculation of nchars\"",
4589
        "oid": "210d9c5863215d0c371f0ec68a0fda2f601920f3"
4590
      },
4591
      {
4592
        "authoredDate": "2019-06-06T20:07:20Z",
4593
        "authors": [
4594
          {
4595
            "email": "[email protected]",
4596
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4597
            "login": "stesser",
4598
            "name": "Stefan Esser"
4599
          }
4600
        ],
4601
        "committedDate": "2019-06-06T20:07:20Z",
4602
        "messageBody": "This version does not pass all tests (hangs in divide.bc).\nI'm commiting anyway, to have a basis that is ismilar to the upstream\nrepo for further testing.",
4603
        "messageHeadline": "Merge latest upstream version.",
4604
        "oid": "94fb480d06c4e082a635d2f4866682d4f6a7b6bb"
4605
      },
4606
      {
4607
        "authoredDate": "2019-06-06T20:50:44Z",
4608
        "authors": [
4609
          {
4610
            "email": "[email protected]",
4611
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4612
            "login": "stesser",
4613
            "name": "Stefan Esser"
4614
          }
4615
        ],
4616
        "committedDate": "2019-06-06T20:50:44Z",
4617
        "messageBody": "",
4618
        "messageHeadline": "Remove debug dump of operands and intermediate results",
4619
        "oid": "59e2953c61615ff5f3deecd181f15c5249fe0bb4"
4620
      },
4621
      {
4622
        "authoredDate": "2019-06-06T20:59:42Z",
4623
        "authors": [
4624
          {
4625
            "email": "[email protected]",
4626
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4627
            "login": "stesser",
4628
            "name": "Stefan Esser"
4629
          }
4630
        ],
4631
        "committedDate": "2019-06-06T20:59:42Z",
4632
        "messageBody": "",
4633
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
4634
        "oid": "6fe9b2fba0e7359152598d4e38ff93020b24b8e7"
4635
      },
4636
      {
4637
        "authoredDate": "2019-06-06T21:01:19Z",
4638
        "authors": [
4639
          {
4640
            "email": "[email protected]",
4641
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4642
            "login": "stesser",
4643
            "name": "Stefan Esser"
4644
          }
4645
        ],
4646
        "committedDate": "2019-06-06T21:01:19Z",
4647
        "messageBody": "",
4648
        "messageHeadline": "Reduce whitespace diff relative to upstream",
4649
        "oid": "595d84e4792bffa63ece31aa146ea7ccfc87ea4b"
4650
      },
4651
      {
4652
        "authoredDate": "2019-06-06T21:03:03Z",
4653
        "authors": [
4654
          {
4655
            "email": "[email protected]",
4656
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4657
            "login": "stesser",
4658
            "name": "Stefan Esser"
4659
          }
4660
        ],
4661
        "committedDate": "2019-06-06T21:03:03Z",
4662
        "messageBody": "",
4663
        "messageHeadline": "Fix lines that resulted from a mis-merge of upstream",
4664
        "oid": "98719eecc5f599365f5d2c3aa042a9cb7cdb6d6c"
4665
      }
4666
    ],
4667
    "createdAt": "2019-06-06T20:53:49Z",
4668
    "deletions": 6,
4669
    "files": [
4670
      {
4671
        "path": "src/num.c",
4672
        "additions": 38,
4673
        "deletions": 6
4674
      }
4675
    ],
4676
    "fullDatabaseId": "285965666",
4677
    "headRefName": "master",
4678
    "headRefOid": "98719eecc5f599365f5d2c3aa042a9cb7cdb6d6c",
4679
    "headRepository": {
4680
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
4681
      "name": "bc"
4682
    },
4683
    "headRepositoryOwner": {
4684
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4685
      "name": "Stefan Eßer",
4686
      "login": "stesser"
4687
    },
4688
    "id": "MDExOlB1bGxSZXF1ZXN0Mjg1OTY1NjY2",
4689
    "isCrossRepository": true,
4690
    "isDraft": false,
4691
    "labels": [],
4692
    "latestReviews": [],
4693
    "maintainerCanModify": false,
4694
    "mergeCommit": {
4695
      "oid": "016a5eed2e5cc0d7e65cea785e609a0bb8a0fa70"
4696
    },
4697
    "mergeStateStatus": "UNKNOWN",
4698
    "mergeable": "UNKNOWN",
4699
    "mergedAt": "2019-06-07T04:04:59Z",
4700
    "mergedBy": {
4701
      "id": "MDQ6VXNlcjMxNzI2ODc=",
4702
      "is_bot": false,
4703
      "login": "gavinhoward",
4704
      "name": "Gavin D. Howard"
4705
    },
4706
    "milestone": null,
4707
    "number": 22,
4708
    "potentialMergeCommit": null,
4709
    "projectCards": [],
4710
    "projectItems": [],
4711
    "reactionGroups": [],
4712
    "reviewDecision": "",
4713
    "reviewRequests": [],
4714
    "reviews": [],
4715
    "state": "MERGED",
4716
    "statusCheckRollup": [],
4717
    "title": "This version completes all tests on my system",
4718
    "updatedAt": "2019-06-07T04:05:18Z",
4719
    "url": "https://github.com/gavinhoward/bc/pull/22"
4720
  },
4721
  {
4722
    "additions": 30,
4723
    "assignees": [],
4724
    "author": {
4725
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4726
      "is_bot": false,
4727
      "login": "stesser",
4728
      "name": "Stefan Eßer"
4729
    },
4730
    "autoMergeRequest": null,
4731
    "baseRefName": "master",
4732
    "baseRefOid": "81eb6fba565695dfe054e0b3f651fa5fa089b605",
4733
    "body": "Reduce the number of iterations required for cases where the top-most BcDig of the divisor is a small value and there are lower non-zero BcDigs. This makes the performance of the division more even for all types of operands of a given length and speeds up \"make test\" by about 3% on my system. The worst case performance of the division is improved by about a factor of 20 (estimated, not measured) for operations like 1/1.000000001.",
4734
    "changedFiles": 1,
4735
    "closed": true,
4736
    "closedAt": "2019-06-06T15:34:13Z",
4737
    "comments": [
4738
      {
4739
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTM5OTU1Nw==",
4740
        "author": {
4741
          "login": "stesser"
4742
        },
4743
        "authorAssociation": "CONTRIBUTOR",
4744
        "body": "While here, fix calculation of vm->nchars in 2 places ...",
4745
        "createdAt": "2019-06-06T08:27:09Z",
4746
        "includesCreatedEdit": false,
4747
        "isMinimized": false,
4748
        "minimizedReason": "",
4749
        "reactionGroups": [],
4750
        "url": "https://github.com/gavinhoward/bc/pull/21#issuecomment-499399557",
4751
        "viewerDidAuthor": false
4752
      },
4753
      {
4754
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTU0NzEzMA==",
4755
        "author": {
4756
          "login": "gavinhoward"
4757
        },
4758
        "authorAssociation": "OWNER",
4759
        "body": "Rejected for reasons stated in an email.",
4760
        "createdAt": "2019-06-06T15:34:13Z",
4761
        "includesCreatedEdit": false,
4762
        "isMinimized": false,
4763
        "minimizedReason": "",
4764
        "reactionGroups": [],
4765
        "url": "https://github.com/gavinhoward/bc/pull/21#issuecomment-499547130",
4766
        "viewerDidAuthor": true
4767
      }
4768
    ],
4769
    "commits": [
4770
      {
4771
        "authoredDate": "2019-06-06T05:13:40Z",
4772
        "authors": [
4773
          {
4774
            "email": "[email protected]",
4775
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4776
            "login": "stesser",
4777
            "name": "Stefan Esser"
4778
          }
4779
        ],
4780
        "committedDate": "2019-06-06T05:13:40Z",
4781
        "messageBody": "Since stdout is not affected by this debug print function, nchars\nshould not be modified, or printing of large numbers will be broken.",
4782
        "messageHeadline": "Resetting of nchars after printing to stderr corrupts the output",
4783
        "oid": "76794442357318437574ec8c0aa3f71903ec419a"
4784
      },
4785
      {
4786
        "authoredDate": "2019-06-06T06:14:43Z",
4787
        "authors": [
4788
          {
4789
            "email": "[email protected]",
4790
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4791
            "login": "stesser",
4792
            "name": "Stefan Esser"
4793
          }
4794
        ],
4795
        "committedDate": "2019-06-06T06:14:43Z",
4796
        "messageBody": "If the top-most BcDig contains a small value and there are lower\nnon-zero BcDigs, the integer divisor is incremented to prevent\ndivision results that do not fit into a BcDig (are > BC_BASE_POW).\n\nE.g. for 1000 / 1.1 the integer divisor will become 2 and the first\nestimate of the result will be 1000 / 2 = 500, giving a reminder of\n1000 - 500 * 1.1 = 450. The next estimate will be 700 = 500 + 450 / 2\nand so on with the reminder slowly decreasing in each iteration.\n\nSince the relative error due to the approximation of the full division\nby an integer division becomes significant for small integer divisors,\nit makes sense to extend the divisor if it i ssmall. In fact, it seems\nto pay off for all divisors that are < BC_BASE_POW / 10.",
4797
        "messageHeadline": "Fix pathological behavior in case integer is rounded up a lot",
4798
        "oid": "035ace7d24afd722ce9a3325c90213d36772e5bd"
4799
      },
4800
      {
4801
        "authoredDate": "2019-06-06T06:25:29Z",
4802
        "authors": [
4803
          {
4804
            "email": "[email protected]",
4805
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4806
            "login": "stesser",
4807
            "name": "Stefan Esser"
4808
          }
4809
        ],
4810
        "committedDate": "2019-06-06T06:25:29Z",
4811
        "messageBody": "",
4812
        "messageHeadline": "Merge branch 'div'",
4813
        "oid": "c1e655b2dd38ea27668b3a0c5b7c86ef06a8dd88"
4814
      },
4815
      {
4816
        "authoredDate": "2019-06-06T08:21:51Z",
4817
        "authors": [
4818
          {
4819
            "email": "[email protected]",
4820
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4821
            "login": "stesser",
4822
            "name": "Stefan Esser"
4823
          }
4824
        ],
4825
        "committedDate": "2019-06-06T08:21:51Z",
4826
        "messageBody": "If there was a new-line character in the string, then strrchr will\nreturn a pointer to that character. If the length of the string\nstarting at the new-line position is 1, then no text follows on the\nnew line and nchars should be set to 0,not 2.",
4827
        "messageHeadline": "Fix calculation of nchars",
4828
        "oid": "54e3cd86494fd1e2c817ea3fa49c357738da5f82"
4829
      },
4830
      {
4831
        "authoredDate": "2019-06-06T11:32:50Z",
4832
        "authors": [
4833
          {
4834
            "email": "[email protected]",
4835
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4836
            "login": "stesser",
4837
            "name": "Stefan Esser"
4838
          }
4839
        ],
4840
        "committedDate": "2019-06-06T11:32:50Z",
4841
        "messageBody": "This reverts commit 54e3cd86494fd1e2c817ea3fa49c357738da5f82.\n\nI had misread the code (thought the + 1 was outside the brackets).",
4842
        "messageHeadline": "Revert \"Fix calculation of nchars\"",
4843
        "oid": "210d9c5863215d0c371f0ec68a0fda2f601920f3"
4844
      }
4845
    ],
4846
    "createdAt": "2019-06-06T06:53:09Z",
4847
    "deletions": 8,
4848
    "files": [
4849
      {
4850
        "path": "src/num.c",
4851
        "additions": 30,
4852
        "deletions": 8
4853
      }
4854
    ],
4855
    "fullDatabaseId": "285665970",
4856
    "headRefName": "master",
4857
    "headRefOid": "210d9c5863215d0c371f0ec68a0fda2f601920f3",
4858
    "headRepository": {
4859
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
4860
      "name": "bc"
4861
    },
4862
    "headRepositoryOwner": {
4863
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4864
      "name": "Stefan Eßer",
4865
      "login": "stesser"
4866
    },
4867
    "id": "MDExOlB1bGxSZXF1ZXN0Mjg1NjY1OTcw",
4868
    "isCrossRepository": true,
4869
    "isDraft": false,
4870
    "labels": [],
4871
    "latestReviews": [],
4872
    "maintainerCanModify": false,
4873
    "mergeCommit": null,
4874
    "mergeStateStatus": "DIRTY",
4875
    "mergeable": "CONFLICTING",
4876
    "mergedAt": null,
4877
    "mergedBy": null,
4878
    "milestone": null,
4879
    "number": 21,
4880
    "potentialMergeCommit": null,
4881
    "projectCards": [],
4882
    "projectItems": [],
4883
    "reactionGroups": [],
4884
    "reviewDecision": "",
4885
    "reviewRequests": [],
4886
    "reviews": [],
4887
    "state": "CLOSED",
4888
    "statusCheckRollup": [],
4889
    "title": "Improve worst case behavior of the division",
4890
    "updatedAt": "2019-06-06T15:34:14Z",
4891
    "url": "https://github.com/gavinhoward/bc/pull/21"
4892
  },
4893
  {
4894
    "additions": 91,
4895
    "assignees": [],
4896
    "author": {
4897
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
4898
      "is_bot": false,
4899
      "login": "stesser",
4900
      "name": "Stefan Eßer"
4901
    },
4902
    "autoMergeRequest": null,
4903
    "baseRefName": "master",
4904
    "baseRefOid": "7be2294e3a91ae4f93bf4db1888d89a6c0d4537b",
4905
    "body": "I had not fully understood the current division algorithm when I suggested to \"overshoot\" subtractions and to attempt convergence from both sides.\r\n\r\nAfter analysis of the current implementation I have noticed that it can be significantly simplified and at the same time sped-up (by a factor of about 2 in my tests). The run-time of \"make test\" is reduced by some 15% on my system.",
4906
    "changedFiles": 1,
4907
    "closed": true,
4908
    "closedAt": "2019-06-06T00:26:39Z",
4909
    "comments": [
4910
      {
4911
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTIyMjQ0Mw==",
4912
        "author": {
4913
          "login": "codecov"
4914
        },
4915
        "authorAssociation": "NONE",
4916
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=h1) Report\n> Merging [#20](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/7be2294e3a91ae4f93bf4db1888d89a6c0d4537b?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/20/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #20   +/-   ##\n=======================================\n  Coverage   99.73%   99.73%           \n=======================================\n  Files          16       16           \n  Lines        3405     3405           \n=======================================\n  Hits         3396     3396           \n  Misses          9        9\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/20/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.8% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=footer). Last update [7be2294...45edd42](https://codecov.io/gh/gavinhoward/bc/pull/20?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
4917
        "createdAt": "2019-06-05T19:28:56Z",
4918
        "includesCreatedEdit": true,
4919
        "isMinimized": false,
4920
        "minimizedReason": "",
4921
        "reactionGroups": [],
4922
        "url": "https://github.com/gavinhoward/bc/pull/20#issuecomment-499222443",
4923
        "viewerDidAuthor": false
4924
      },
4925
      {
4926
        "id": "MDEyOklzc3VlQ29tbWVudDQ5OTIzNzA4NA==",
4927
        "author": {
4928
          "login": "gavinhoward"
4929
        },
4930
        "authorAssociation": "OWNER",
4931
        "body": "Can you send me your tests?",
4932
        "createdAt": "2019-06-05T20:12:45Z",
4933
        "includesCreatedEdit": false,
4934
        "isMinimized": false,
4935
        "minimizedReason": "",
4936
        "reactionGroups": [],
4937
        "url": "https://github.com/gavinhoward/bc/pull/20#issuecomment-499237084",
4938
        "viewerDidAuthor": true
4939
      }
4940
    ],
4941
    "commits": [
4942
      {
4943
        "authoredDate": "2019-05-20T11:00:48Z",
4944
        "authors": [
4945
          {
4946
            "email": "[email protected]",
4947
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4948
            "login": "stesser",
4949
            "name": "Stefan Esser"
4950
          }
4951
        ],
4952
        "committedDate": "2019-05-20T11:00:48Z",
4953
        "messageBody": "…mod per BcDig\n\nIn the last iteration of the per BcDig print loop, acc is known to be less than\npow, therefore the last div and mod operations can be skipped, resulting in a\nspeed-up of about 2% in my tests.",
4954
        "messageHeadline": "Slightly speed up printing for the obase!=10 case by skipping one div…",
4955
        "oid": "b2c2fe4f75bff27e183db6e8b4211e8f602b0e68"
4956
      },
4957
      {
4958
        "authoredDate": "2019-06-05T10:06:38Z",
4959
        "authors": [
4960
          {
4961
            "email": "[email protected]",
4962
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4963
            "login": "stesser",
4964
            "name": "Stefan Esser"
4965
          }
4966
        ],
4967
        "committedDate": "2019-06-05T10:06:38Z",
4968
        "messageBody": "",
4969
        "messageHeadline": "Merge branch 'master' of github.com:stesser/bc",
4970
        "oid": "caf977797a95fecc39e78b35ef964e69d7851e8a"
4971
      },
4972
      {
4973
        "authoredDate": "2019-06-05T19:04:42Z",
4974
        "authors": [
4975
          {
4976
            "email": "[email protected]",
4977
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
4978
            "login": "stesser",
4979
            "name": "Stefan Esser"
4980
          }
4981
        ],
4982
        "committedDate": "2019-06-05T19:04:42Z",
4983
        "messageBody": "The run-time of \"make test\" is reduced by some 15% on my system.",
4984
        "messageHeadline": "Implement faster and simpler division algorithm",
4985
        "oid": "45edd42ef28c52287e664e2d00b5b7de31a30e22"
4986
      }
4987
    ],
4988
    "createdAt": "2019-06-05T19:25:44Z",
4989
    "deletions": 99,
4990
    "files": [
4991
      {
4992
        "path": "src/num.c",
4993
        "additions": 91,
4994
        "deletions": 99
4995
      }
4996
    ],
4997
    "fullDatabaseId": "285517299",
4998
    "headRefName": "master",
4999
    "headRefOid": "45edd42ef28c52287e664e2d00b5b7de31a30e22",
5000
    "headRepository": {
5001
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
5002
      "name": "bc"
5003
    },
5004
    "headRepositoryOwner": {
5005
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
5006
      "name": "Stefan Eßer",
5007
      "login": "stesser"
5008
    },
5009
    "id": "MDExOlB1bGxSZXF1ZXN0Mjg1NTE3Mjk5",
5010
    "isCrossRepository": true,
5011
    "isDraft": false,
5012
    "labels": [],
5013
    "latestReviews": [],
5014
    "maintainerCanModify": false,
5015
    "mergeCommit": {
5016
      "oid": "8904602cd9be7d6433f9ed6c2caab0f9c745dd9c"
5017
    },
5018
    "mergeStateStatus": "UNKNOWN",
5019
    "mergeable": "UNKNOWN",
5020
    "mergedAt": "2019-06-06T00:26:39Z",
5021
    "mergedBy": {
5022
      "id": "MDQ6VXNlcjMxNzI2ODc=",
5023
      "is_bot": false,
5024
      "login": "gavinhoward",
5025
      "name": "Gavin D. Howard"
5026
    },
5027
    "milestone": null,
5028
    "number": 20,
5029
    "potentialMergeCommit": null,
5030
    "projectCards": [],
5031
    "projectItems": [],
5032
    "reactionGroups": [],
5033
    "reviewDecision": "",
5034
    "reviewRequests": [],
5035
    "reviews": [],
5036
    "state": "MERGED",
5037
    "statusCheckRollup": [],
5038
    "title": "Speed up and simplify division",
5039
    "updatedAt": "2019-06-06T00:26:40Z",
5040
    "url": "https://github.com/gavinhoward/bc/pull/20"
5041
  },
5042
  {
5043
    "additions": 10,
5044
    "assignees": [],
5045
    "author": {
5046
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
5047
      "is_bot": false,
5048
      "login": "stesser",
5049
      "name": "Stefan Eßer"
5050
    },
5051
    "autoMergeRequest": null,
5052
    "baseRefName": "master",
5053
    "baseRefOid": "e318529d852cee9ce40c06f1a91f0063d8e0bd62",
5054
    "body": "In the last iteration of the per BcDig print loop, \"acc\" is known to be less than \"pow\", therefore the last div and mod operations can be skipped, resulting in a speed-up of about 2% in my tests.",
5055
    "changedFiles": 1,
5056
    "closed": true,
5057
    "closedAt": "2019-05-20T14:08:11Z",
5058
    "comments": [
5059
      {
5060
        "id": "MDEyOklzc3VlQ29tbWVudDQ5Mzk1ODQwMw==",
5061
        "author": {
5062
          "login": "codecov"
5063
        },
5064
        "authorAssociation": "NONE",
5065
        "body": "# [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=h1) Report\n> Merging [#19](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=desc) into [master](https://codecov.io/gh/gavinhoward/bc/commit/e318529d852cee9ce40c06f1a91f0063d8e0bd62?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gavinhoward/bc/pull/19/graphs/tree.svg?width=650&token=7VDYTvCBQX&height=150&src=pr)](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #19      +/-   ##\n==========================================\n+ Coverage   99.88%   99.88%   +<.01%     \n==========================================\n  Files          16       16              \n  Lines        3409     3411       +2     \n==========================================\n+ Hits         3405     3407       +2     \n  Misses          4        4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/num.c](https://codecov.io/gh/gavinhoward/bc/pull/19/diff?src=pr&el=tree#diff-c3JjL251bS5j) | `99.8% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=footer). Last update [e318529...b2c2fe4](https://codecov.io/gh/gavinhoward/bc/pull/19?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
5066
        "createdAt": "2019-05-20T12:05:10Z",
5067
        "includesCreatedEdit": true,
5068
        "isMinimized": false,
5069
        "minimizedReason": "",
5070
        "reactionGroups": [],
5071
        "url": "https://github.com/gavinhoward/bc/pull/19#issuecomment-493958403",
5072
        "viewerDidAuthor": false
5073
      },
5074
      {
5075
        "id": "MDEyOklzc3VlQ29tbWVudDQ5NDAwMjk1MQ==",
5076
        "author": {
5077
          "login": "gavinhoward"
5078
        },
5079
        "authorAssociation": "OWNER",
5080
        "body": "Oh whoops. I did not notice this PR; I merged in the patch instead, though I did list you as the author of the commit. I hope that is okay.\r\n\r\nClosing since the code is already merged.",
5081
        "createdAt": "2019-05-20T14:08:11Z",
5082
        "includesCreatedEdit": false,
5083
        "isMinimized": false,
5084
        "minimizedReason": "",
5085
        "reactionGroups": [],
5086
        "url": "https://github.com/gavinhoward/bc/pull/19#issuecomment-494002951",
5087
        "viewerDidAuthor": true
5088
      }
5089
    ],
5090
    "commits": [
5091
      {
5092
        "authoredDate": "2019-05-20T11:00:48Z",
5093
        "authors": [
5094
          {
5095
            "email": "[email protected]",
5096
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5097
            "login": "stesser",
5098
            "name": "Stefan Esser"
5099
          }
5100
        ],
5101
        "committedDate": "2019-05-20T11:00:48Z",
5102
        "messageBody": "…mod per BcDig\n\nIn the last iteration of the per BcDig print loop, acc is known to be less than\npow, therefore the last div and mod operations can be skipped, resulting in a\nspeed-up of about 2% in my tests.",
5103
        "messageHeadline": "Slightly speed up printing for the obase!=10 case by skipping one div…",
5104
        "oid": "b2c2fe4f75bff27e183db6e8b4211e8f602b0e68"
5105
      }
5106
    ],
5107
    "createdAt": "2019-05-20T12:00:46Z",
5108
    "deletions": 4,
5109
    "files": [
5110
      {
5111
        "path": "src/num.c",
5112
        "additions": 10,
5113
        "deletions": 4
5114
      }
5115
    ],
5116
    "fullDatabaseId": "280360533",
5117
    "headRefName": "d9",
5118
    "headRefOid": "b2c2fe4f75bff27e183db6e8b4211e8f602b0e68",
5119
    "headRepository": {
5120
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
5121
      "name": "bc"
5122
    },
5123
    "headRepositoryOwner": {
5124
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
5125
      "name": "Stefan Eßer",
5126
      "login": "stesser"
5127
    },
5128
    "id": "MDExOlB1bGxSZXF1ZXN0MjgwMzYwNTMz",
5129
    "isCrossRepository": true,
5130
    "isDraft": false,
5131
    "labels": [],
5132
    "latestReviews": [],
5133
    "maintainerCanModify": false,
5134
    "mergeCommit": null,
5135
    "mergeStateStatus": "DIRTY",
5136
    "mergeable": "CONFLICTING",
5137
    "mergedAt": null,
5138
    "mergedBy": null,
5139
    "milestone": null,
5140
    "number": 19,
5141
    "potentialMergeCommit": null,
5142
    "projectCards": [],
5143
    "projectItems": [],
5144
    "reactionGroups": [],
5145
    "reviewDecision": "",
5146
    "reviewRequests": [],
5147
    "reviews": [],
5148
    "state": "CLOSED",
5149
    "statusCheckRollup": [],
5150
    "title": "Slightly speed up printing for the obase!=10 case",
5151
    "updatedAt": "2019-06-02T10:54:35Z",
5152
    "url": "https://github.com/gavinhoward/bc/pull/19"
5153
  },
5154
  {
5155
    "additions": 11813,
5156
    "assignees": [],
5157
    "author": {
5158
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
5159
      "is_bot": false,
5160
      "login": "stesser",
5161
      "name": "Stefan Eßer"
5162
    },
5163
    "autoMergeRequest": null,
5164
    "baseRefName": "master",
5165
    "baseRefOid": "b3ba59502ee5cc81e2019a724b94b648a35d7897",
5166
    "body": "All division and modulo test cases pass with this version.\r\n\r\nMaybe the scale could be reduced (for better performance) in parts of the algorithm, but for now the functionality is there. I have optimized the pow10 function by use of a look-up table. This table will be cached and the indexing faster than repetitive multiplication, IMHO. (Should be tested, but will not be significant in the overall picture, I guess.)\r\n\r\nI have introduced a function that rounds to a given precision. This was necessary to get the division match previous results to the last relevant digit. Just cutting off excess digits gives small errors in division and modulo results.\r\n\r\nAnother new function normalizes its argument to make len == rdx (i.e. to give a value strictly less than 1 but without 0 in the uppermost BcDig of num[]). This was required for the division, which operates on \"normalized\" values and adjusts the position of the decimal point as a final step.\r\n\r\nNeither of these functions has been added to num.h, since I was not sure about your policy with regard to having all static functions in num.c declared therein).",
5167
    "changedFiles": 17,
5168
    "closed": true,
5169
    "closedAt": "2019-05-06T13:42:00Z",
5170
    "comments": [
5171
      {
5172
        "id": "MDEyOklzc3VlQ29tbWVudDQ4NzU3MzUyNA==",
5173
        "author": {
5174
          "login": "stesser"
5175
        },
5176
        "authorAssociation": "CONTRIBUTOR",
5177
        "body": "The power has been fixed and passes all tests.\r\nThe sqrt operator gives results that do not pass the tests but differ only in the number of decimals or the precision of the calculation.",
5178
        "createdAt": "2019-04-29T13:11:00Z",
5179
        "includesCreatedEdit": false,
5180
        "isMinimized": false,
5181
        "minimizedReason": "",
5182
        "reactionGroups": [],
5183
        "url": "https://github.com/gavinhoward/bc/pull/18#issuecomment-487573524",
5184
        "viewerDidAuthor": false
5185
      }
5186
    ],
5187
    "commits": [
5188
      {
5189
        "authoredDate": "2019-04-19T08:06:46Z",
5190
        "authors": [
5191
          {
5192
            "email": "[email protected]",
5193
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5194
            "login": "stesser",
5195
            "name": "Stefan Esser"
5196
          }
5197
        ],
5198
        "committedDate": "2019-04-19T08:06:46Z",
5199
        "messageBody": "…ot found.",
5200
        "messageHeadline": "The test should use the same file name as is created if the file is n…",
5201
        "oid": "d9bda13740c6d4f67c1d69955a4ea8e3477bad4f"
5202
      },
5203
      {
5204
        "authoredDate": "2019-04-19T14:09:03Z",
5205
        "authors": [
5206
          {
5207
            "email": "[email protected]",
5208
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5209
            "login": "stesser",
5210
            "name": "Stefan Esser"
5211
          }
5212
        ],
5213
        "committedDate": "2019-04-19T14:09:03Z",
5214
        "messageBody": "The output has been verified to be identical to that of the C language\nversion for all files in this project by comparing the resulting .o files.",
5215
        "messageHeadline": "Provide shell version of strgen.c to allow use without compilation.",
5216
        "oid": "7d9fb3e6ffb7008afec4c7168498751366213b0f"
5217
      },
5218
      {
5219
        "authoredDate": "2019-04-19T14:11:23Z",
5220
        "authors": [
5221
          {
5222
            "email": "[email protected]",
5223
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5224
            "login": "stesser",
5225
            "name": "Stefan Esser"
5226
          }
5227
        ],
5228
        "committedDate": "2019-04-19T14:11:23Z",
5229
        "messageBody": "",
5230
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
5231
        "oid": "fddcd0f53021d8f3164f5618ba952ab36932d8fc"
5232
      },
5233
      {
5234
        "authoredDate": "2019-04-19T18:39:00Z",
5235
        "authors": [
5236
          {
5237
            "email": "[email protected]",
5238
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5239
            "login": "stesser",
5240
            "name": "Stefan Esser"
5241
          }
5242
        ],
5243
        "committedDate": "2019-04-19T18:39:00Z",
5244
        "messageBody": "…nature.",
5245
        "messageHeadline": "Change parameter from char* to char** as required by the function sig…",
5246
        "oid": "a010b3e82408024f12e34030591349c4a344465b"
5247
      },
5248
      {
5249
        "authoredDate": "2019-04-19T18:41:07Z",
5250
        "authors": [
5251
          {
5252
            "email": "[email protected]",
5253
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5254
            "login": "stesser",
5255
            "name": "Stefan Esser"
5256
          }
5257
        ],
5258
        "committedDate": "2019-04-19T18:41:07Z",
5259
        "messageBody": "",
5260
        "messageHeadline": "Fix test to work if empty or null string is passed.",
5261
        "oid": "22fd1e9277a34ead069e9dd64942ed3cd55c2ac6"
5262
      },
5263
      {
5264
        "authoredDate": "2019-04-20T08:34:13Z",
5265
        "authors": [
5266
          {
5267
            "email": "[email protected]",
5268
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5269
            "login": "stesser",
5270
            "name": "Stefan Esser"
5271
          }
5272
        ],
5273
        "committedDate": "2019-04-20T08:34:13Z",
5274
        "messageBody": "",
5275
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
5276
        "oid": "461c523fcbb8ff4c758ddb6ba2d9cfcf71a0a412"
5277
      },
5278
      {
5279
        "authoredDate": "2019-04-20T08:35:20Z",
5280
        "authors": [
5281
          {
5282
            "email": "[email protected]",
5283
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5284
            "login": "stesser",
5285
            "name": "Stefan Esser"
5286
          }
5287
        ],
5288
        "committedDate": "2019-04-20T08:35:20Z",
5289
        "messageBody": "…e was broken,",
5290
        "messageHeadline": "Change reference to v.v to use bc_vec_item(&v, 0) - my previous chang…",
5291
        "oid": "52b52a81ea9ea993d9835900398ee48d6e1dc1ad"
5292
      },
5293
      {
5294
        "authoredDate": "2019-04-20T08:37:07Z",
5295
        "authors": [
5296
          {
5297
            "email": "[email protected]",
5298
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5299
            "login": "stesser",
5300
            "name": "Stefan Esser"
5301
          }
5302
        ],
5303
        "committedDate": "2019-04-20T08:37:07Z",
5304
        "messageBody": "…nset",
5305
        "messageHeadline": "Split test into two parts to prevent parse error if the variable is u…",
5306
        "oid": "04ddff0bd1de2bde9c1af167cd59488a8fa3800c"
5307
      },
5308
      {
5309
        "authoredDate": "2019-04-20T15:11:30Z",
5310
        "authors": [
5311
          {
5312
            "email": "[email protected]",
5313
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5314
            "login": "stesser",
5315
            "name": "Stefan Esser"
5316
          }
5317
        ],
5318
        "committedDate": "2019-04-20T15:11:30Z",
5319
        "messageBody": "",
5320
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
5321
        "oid": "eb62a6521bcdaea48a8a69a346facf14a46604be"
5322
      },
5323
      {
5324
        "authoredDate": "2019-04-20T16:14:00Z",
5325
        "authors": [
5326
          {
5327
            "email": "[email protected]",
5328
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5329
            "login": "stesser",
5330
            "name": "Stefan Esser"
5331
          }
5332
        ],
5333
        "committedDate": "2019-04-20T16:14:00Z",
5334
        "messageBody": "",
5335
        "messageHeadline": "Add information about recently added message catalogs.",
5336
        "oid": "b2950329c49de32e8dccf39ad3a64c3d210c9a46"
5337
      },
5338
      {
5339
        "authoredDate": "2019-04-20T16:16:06Z",
5340
        "authors": [
5341
          {
5342
            "email": "[email protected]",
5343
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5344
            "login": "stesser",
5345
            "name": "Stefan Esser"
5346
          }
5347
        ],
5348
        "committedDate": "2019-04-20T16:16:06Z",
5349
        "messageBody": "",
5350
        "messageHeadline": "Add quotes around fr_CA and fr_CH.",
5351
        "oid": "eaf8bc5fa067eb2c55c96d14ad21ba952e83f6c5"
5352
      },
5353
      {
5354
        "authoredDate": "2019-04-20T16:17:04Z",
5355
        "authors": [
5356
          {
5357
            "email": "[email protected]",
5358
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5359
            "login": "stesser",
5360
            "name": "Stefan Esser"
5361
          }
5362
        ],
5363
        "committedDate": "2019-04-20T16:17:04Z",
5364
        "messageBody": "",
5365
        "messageHeadline": "Fix quotes around fr_CA and fr_CH.",
5366
        "oid": "7c87d5892205451fcabb38edf42ca4c948427dd7"
5367
      },
5368
      {
5369
        "authoredDate": "2019-04-20T16:18:07Z",
5370
        "authors": [
5371
          {
5372
            "email": "[email protected]",
5373
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5374
            "login": "stesser",
5375
            "name": "Stefan Esser"
5376
          }
5377
        ],
5378
        "committedDate": "2019-04-20T16:18:07Z",
5379
        "messageBody": "Anyway, I'm no native speaker of English and therefore the change is only\na crude example for what might be added ... ;-)",
5380
        "messageHeadline": "I think \"for\" is better than \"in\", here.",
5381
        "oid": "ecd6481f5aeabf178cc0fc7614840f08d74473b0"
5382
      },
5383
      {
5384
        "authoredDate": "2019-04-24T09:16:49Z",
5385
        "authors": [
5386
          {
5387
            "email": "[email protected]",
5388
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5389
            "login": "stesser",
5390
            "name": "Stefan Esser"
5391
          }
5392
        ],
5393
        "committedDate": "2019-04-24T09:16:49Z",
5394
        "messageBody": "",
5395
        "messageHeadline": "Merge branch 'master' of https://github.com/gavinhoward/bc",
5396
        "oid": "004ad884ed95213a1a14cc7a5b05353ff91fcceb"
5397
      },
5398
      {
5399
        "authoredDate": "2019-04-24T21:28:32Z",
5400
        "authors": [
5401
          {
5402
            "email": "[email protected]",
5403
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5404
            "login": "stesser",
5405
            "name": "Stefan Esser"
5406
          }
5407
        ],
5408
        "committedDate": "2019-04-24T21:28:32Z",
5409
        "messageBody": "…esent numbers\n\nThis code has been tested with add/sub, multiplicaton and power of integer values.\nNo tests have been performed for division and square root, yet.\n\nNumbers with fractional parts are not supported due to the missing scaling of the\n\"scale\" parameter.",
5410
        "messageHeadline": "Initial support for 32 bit integers instead of decimal digits to repr…",
5411
        "oid": "a299ffc466db2360d0cd21f8e872a4b9ccac8f0b"
5412
      },
5413
      {
5414
        "authoredDate": "2019-04-24T23:23:08Z",
5415
        "authors": [
5416
          {
5417
            "email": "[email protected]",
5418
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5419
            "login": "stesser",
5420
            "name": "Stefan Eßer"
5421
          }
5422
        ],
5423
        "committedDate": "2019-04-24T23:23:08Z",
5424
        "messageBody": "This patch starts a branch exploring the possibility of using a more\npacked representation of digits in BcNum's. I am not sure this will work\nout, but it can't hurt to try, especially since Stefan was so kind to\ncome up with a patch and send it.\n\nAs of right now, the things that are known to be broken:\n\n* Printing decimal numbers\n* Power (seg fault)",
5425
        "messageHeadline": "Commit an adjusted patch sent to me by Stefan Eßer",
5426
        "oid": "4b111c28c02ac4c999ad62de5a448eb21e01489b"
5427
      },
5428
      {
5429
        "authoredDate": "2019-04-24T23:31:23Z",
5430
        "authors": [
5431
          {
5432
            "email": "[email protected]",
5433
            "id": "",
5434
            "login": "",
5435
            "name": "Gavin Howard"
5436
          }
5437
        ],
5438
        "committedDate": "2019-04-24T23:31:23Z",
5439
        "messageBody": "",
5440
        "messageHeadline": "Attempt to make Stefan's work more portable",
5441
        "oid": "0700efc9bb2aad8921d035f18bb30e4e211e0115"
5442
      },
5443
      {
5444
        "authoredDate": "2019-04-24T23:33:48Z",
5445
        "authors": [
5446
          {
5447
            "email": "[email protected]",
5448
            "id": "",
5449
            "login": "",
5450
            "name": "Gavin Howard"
5451
          }
5452
        ],
5453
        "committedDate": "2019-04-24T23:33:48Z",
5454
        "messageBody": "",
5455
        "messageHeadline": "Fix a bit of code that is not portable to 8-bit arches",
5456
        "oid": "d7e4d6e8e6e0c46c3ab378c8066ceedf02fe2784"
5457
      },
5458
      {
5459
        "authoredDate": "2019-04-25T04:33:10Z",
5460
        "authors": [
5461
          {
5462
            "email": "[email protected]",
5463
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5464
            "login": "stesser",
5465
            "name": "Stefan Esser"
5466
          }
5467
        ],
5468
        "committedDate": "2019-04-25T04:33:10Z",
5469
        "messageBody": "… of BcDig",
5470
        "messageHeadline": "Introduce 3 function to perform memcpy, memmove, and memset on arrays…",
5471
        "oid": "394a516fb6d95a9314783e4b920f9078b8d6217b"
5472
      },
5473
      {
5474
        "authoredDate": "2019-04-25T05:05:24Z",
5475
        "authors": [
5476
          {
5477
            "email": "[email protected]",
5478
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5479
            "login": "stesser",
5480
            "name": "Stefan Esser"
5481
          }
5482
        ],
5483
        "committedDate": "2019-04-25T05:05:24Z",
5484
        "messageBody": "",
5485
        "messageHeadline": "Modify malloc and realloc functions to operate on BcDig arrays",
5486
        "oid": "5fd43a372b887cae774309dae0482410eaa64344"
5487
      },
5488
      {
5489
        "authoredDate": "2019-04-25T05:14:54Z",
5490
        "authors": [
5491
          {
5492
            "email": "[email protected]",
5493
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5494
            "login": "stesser",
5495
            "name": "Stefan Esser"
5496
          }
5497
        ],
5498
        "committedDate": "2019-04-25T05:14:54Z",
5499
        "messageBody": "…ctions for use in vector.c",
5500
        "messageHeadline": "Add BcDig alloc functions to header and re-enable the plain alloc fun…",
5501
        "oid": "ca5a74eedef9edea724f90c386cf13322a972511"
5502
      },
5503
      {
5504
        "authoredDate": "2019-04-25T05:42:03Z",
5505
        "authors": [
5506
          {
5507
            "email": "[email protected]",
5508
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5509
            "login": "stesser",
5510
            "name": "Stefan Esser"
5511
          }
5512
        ],
5513
        "committedDate": "2019-04-25T05:42:03Z",
5514
        "messageBody": "",
5515
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
5516
        "oid": "14eff4647371265957e125e44ca8666cc845b54f"
5517
      },
5518
      {
5519
        "authoredDate": "2019-04-25T05:56:10Z",
5520
        "authors": [
5521
          {
5522
            "email": "[email protected]",
5523
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5524
            "login": "stesser",
5525
            "name": "Stefan Esser"
5526
          }
5527
        ],
5528
        "committedDate": "2019-04-25T05:56:10Z",
5529
        "messageBody": "",
5530
        "messageHeadline": "Use bc_num_set instead of memset in merged code",
5531
        "oid": "887d6b9b2fb148490d373f60cc13f42fb3a47102"
5532
      },
5533
      {
5534
        "authoredDate": "2019-04-25T06:01:03Z",
5535
        "authors": [
5536
          {
5537
            "email": "[email protected]",
5538
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5539
            "login": "stesser",
5540
            "name": "Stefan Esser"
5541
          }
5542
        ],
5543
        "committedDate": "2019-04-25T06:01:03Z",
5544
        "messageBody": "",
5545
        "messageHeadline": "Allow passing of -DBC_DEBUG_CODE on the command line",
5546
        "oid": "010dd2a01af69462ee1c94053e9f82cde65f171d"
5547
      },
5548
      {
5549
        "authoredDate": "2019-04-25T06:09:13Z",
5550
        "authors": [
5551
          {
5552
            "email": "[email protected]",
5553
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5554
            "login": "stesser",
5555
            "name": "Stefan Esser"
5556
          }
5557
        ],
5558
        "committedDate": "2019-04-25T06:09:13Z",
5559
        "messageBody": "",
5560
        "messageHeadline": "Remove duplicate definitioon of DUMP_NUM",
5561
        "oid": "a3430556302146f917be5266b7c6021ecd2e1133"
5562
      },
5563
      {
5564
        "authoredDate": "2019-04-25T09:25:17Z",
5565
        "authors": [
5566
          {
5567
            "email": "[email protected]",
5568
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5569
            "login": "stesser",
5570
            "name": "Stefan Esser"
5571
          }
5572
        ],
5573
        "committedDate": "2019-04-25T09:25:17Z",
5574
        "messageBody": "",
5575
        "messageHeadline": "Remove obsolete local variables",
5576
        "oid": "bf3b1b206e6e6a88c7ffc6ca7e10388f3fb1eb4a"
5577
      },
5578
      {
5579
        "authoredDate": "2019-04-25T09:50:39Z",
5580
        "authors": [
5581
          {
5582
            "email": "[email protected]",
5583
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5584
            "login": "stesser",
5585
            "name": "Stefan Esser"
5586
          }
5587
        ],
5588
        "committedDate": "2019-04-25T09:50:39Z",
5589
        "messageBody": "",
5590
        "messageHeadline": "Fix printing of the decimal point (occured multiple times)",
5591
        "oid": "610a8ee9e89626f9789ba63a3e5692adc19a46ef"
5592
      },
5593
      {
5594
        "authoredDate": "2019-04-25T10:25:15Z",
5595
        "authors": [
5596
          {
5597
            "email": "[email protected]",
5598
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
5599
            "login": "stesser",
5600
            "name": "Stefan Esser"
5601
          }
5602
        ],
5603
        "committedDate": "2019-04-25T10:25:15Z",
5604
        "messageBody": "",
5605
        "messageHeadline": "Suppress printing of trailing zeroes of fractional parts of a result",
5606
        "oid": "0da1775703abdbd337f024a4b46208976b08508a"
5607
      },
5608
      {
5609
        "authoredDate": "2019-04-25T17:33:54Z",
5610
        "authors": [
5611
          {
5612
            "email": "[email protected]",
5613
            "id": "",
5614
            "login": "",
5615
            "name": "Gavin Howard"
5616
          }
5617
        ],
5618
        "committedDate": "2019-04-25T17:33:54Z",
5619
        "messageBody": "",
5620
        "messageHeadline": "Fix a problem I introduced",
5621
        "oid": "b53a994e74fd2f226bac7756063b557dfd03f172"
5622
      },
5623
      {
5624
        "authoredDate": "2019-04-25T21:18:49Z",
5625
        "authors": [
5626
          {
5627
            "email": "[email protected]",
5628
            "id": "",
5629
            "login": "",
5630
            "name": "Gavin D. Howard"
5631
          }
5632
        ],
5633
        "committedDate": "2019-04-25T21:18:49Z",
5634
        "messageBody": "A number of fixes and improvements ...",
5635
        "messageHeadline": "Merge pull request #15 from stesser/d9",
5636
        "oid": "7daf7e6cf26a6b3b11eeddd9d6bcc38bd52da3dc"
5637
      },
5638
      {
5639
        "authoredDate": "2019-04-26T01:35:41Z",
5640
        "authors": [
5641
          {
5642
            "email": "[email protected]",
5643
            "id": "",
5644
            "login": "",
5645
            "name": "Gavin Howard"
5646
          }
5647
        ],
5648
        "committedDate": "2019-04-26T01:35:41Z",
5649
        "messageBody": "",
5650
        "messageHeadline": "Fix some style",
5651
        "oid": "af107d94c9352b37d4bf31815663fd68effa55b6"
5652
      },
5653
      {
5654
        "authoredDate": "2019-04-26T01:43:49Z",
5655
        "authors": [
5656
          {
5657
            "email": "[email protected]",
5658
            "id": "",
5659
            "login": "",
5660
            "name": "Gavin Howard"
5661
          }
5662
        ],
5663
        "committedDate": "2019-04-26T01:43:49Z",
5664
        "messageBody": "",
5665
        "messageHeadline": "Fix some more style",
5666
        "oid": "f49fdaa396f2cda25379b056cf7ca9fffb0a68d6"
5667
      },
5668
      {
5669
        "authoredDate": "2019-04-26T02:12:19Z",
5670
        "authors": [
5671
          {
5672
            "email": "[email protected]",
5673
            "id": "",
5674
            "login": "",
5675
            "name": "Gavin Howard"
5676
          }
5677
        ],
5678
        "committedDate": "2019-04-26T02:12:19Z",
5679
        "messageBody": "",
5680
        "messageHeadline": "Make some changes and mark functions that need work",
5681
        "oid": "fcf290110df0d7b09b5f89798888f05b8b371484"
5682
      },
5683
      {
5684
        "authoredDate": "2019-04-26T03:13:54Z",
5685
        "authors": [
5686
          {
5687
            "email": "[email protected]",
5688
            "id": "",
5689
            "login": "",
5690
            "name": "Gavin Howard"
5691
          }
5692
        ],
5693
        "committedDate": "2019-04-26T03:13:54Z",
5694
        "messageBody": "There is still one bug: it allows in an extra 0 in the most significant\nspot if there is one, but it does produce the right numbers.",
5695
        "messageHeadline": "Make decimal parsing work",
5696
        "oid": "d43ec37d48c69660ba7098c88a8ef3002a49636d"
5697
      },
5698
      {
5699
        "authoredDate": "2019-04-26T14:48:19Z",
5700
        "authors": [
5701
          {
5702
            "email": "[email protected]",
5703
            "id": "",
5704
            "login": "",
5705
            "name": "Gavin Howard"
5706
          }
5707
        ],
5708
        "committedDate": "2019-04-26T14:48:19Z",
5709
        "messageBody": "",
5710
        "messageHeadline": "Fix the definitions for BcDig",
5711
        "oid": "2eaeebffdce7fcd52b3a62d1537002b3580b6e28"
5712
      },
5713
      {
5714
        "authoredDate": "2019-04-26T14:48:44Z",
5715
        "authors": [
5716
          {
5717
            "email": "[email protected]",
5718
            "id": "",
5719
            "login": "",
5720
            "name": "Gavin Howard"
5721
          }
5722
        ],
5723
        "committedDate": "2019-04-26T14:48:44Z",
5724
        "messageBody": "",
5725
        "messageHeadline": "Add more decimal tests",
5726
        "oid": "a0e90f3e79ef5b619b801753877d94992f6bdc95"
5727
      },
5728
      {
5729
        "authoredDate": "2019-04-26T14:49:05Z",
5730
        "authors": [
5731
          {
5732
            "email": "[email protected]",
5733
            "id": "",
5734
            "login": "",
5735
            "name": "Gavin Howard"
5736
          }
5737
        ],
5738
        "committedDate": "2019-04-26T14:49:05Z",
5739
        "messageBody": "",
5740
        "messageHeadline": "Fix a warning",
5741
        "oid": "f196fbe426ea69bcf4fb3046cc4fedffd7fc54b7"
5742
      },
5743
      {
5744
        "authoredDate": "2019-04-26T14:49:17Z",
5745
        "authors": [
5746
          {
5747
            "email": "[email protected]",
5748
            "id": "",
5749
            "login": "",
5750
            "name": "Gavin Howard"
5751
          }
5752
        ],
5753
        "committedDate": "2019-04-26T14:49:17Z",
5754
        "messageBody": "",
5755
        "messageHeadline": "Make parsing decimal work",
5756
        "oid": "3b60abb028266f4ff0e1aa3bdf42f440eae646c5"
5757
      },
5758
      {
5759
        "authoredDate": "2019-04-26T15:46:29Z",
5760
        "authors": [
5761
          {
5762
            "email": "[email protected]",
5763
            "id": "",
5764
            "login": "",
5765
            "name": "Gavin Howard"
5766
          }
5767
        ],
5768
        "committedDate": "2019-04-26T15:46:29Z",
5769
        "messageBody": "",
5770
        "messageHeadline": "Fix a test result file",
5771
        "oid": "de5fcf3618c6a9ca342ed749459f395783de28d7"
5772
      },
5773
      {
5774
        "authoredDate": "2019-04-26T15:47:50Z",
5775
        "authors": [
5776
          {
5777
            "email": "[email protected]",
5778
            "id": "",
5779
            "login": "",
5780
            "name": "Gavin Howard"
5781
          }
5782
        ],
5783
        "committedDate": "2019-04-26T15:47:50Z",
5784
        "messageBody": "",
5785
        "messageHeadline": "Fix another bug in the parse decimal procedure",
5786
        "oid": "6076dbb54bf4503abefeab22ee2a3edf6075e2e6"
5787
      },
5788
      {
5789
        "authoredDate": "2019-04-26T15:48:12Z",
5790
        "authors": [
5791
          {
5792
            "email": "[email protected]",
5793
            "id": "",
5794
            "login": "",
5795
            "name": "Gavin Howard"
5796
          }
5797
        ],
5798
        "committedDate": "2019-04-26T15:48:25Z",
5799
        "messageBody": "This still uses an idea from Stefan Eßer and some code, mainly the\nbuffer for calculating the numbers. Other than that, I did it my way.\n\nThe reason for this is because I *really* want to make sure the radix is\non a BcDig boundary.",
5800
        "messageHeadline": "Make printing decimal numbers work",
5801
        "oid": "51cd7ea27608359bf4298766cbf1579da9c35242"
5802
      },
5803
      {
5804
        "authoredDate": "2019-04-26T15:50:35Z",
5805
        "authors": [
5806
          {
5807
            "email": "[email protected]",
5808
            "id": "",
5809
            "login": "",
5810
            "name": "Gavin Howard"
5811
          }
5812
        ],
5813
        "committedDate": "2019-04-26T15:50:35Z",
5814
        "messageBody": "",
5815
        "messageHeadline": "Remove some TODO comments that are done",
5816
        "oid": "9cf865f8396f76015b63d5f719e1ba4f0504a629"
5817
      },
5818
      {
5819
        "authoredDate": "2019-04-26T16:07:21Z",
5820
        "authors": [
5821
          {
5822
            "email": "[email protected]",
5823
            "id": "",
5824
            "login": "",
5825
            "name": "Gavin Howard"
5826
          }
5827
        ],
5828
        "committedDate": "2019-04-26T16:07:21Z",
5829
        "messageBody": "",
5830
        "messageHeadline": "Make add work",
5831
        "oid": "fba50a2a7d78923ffc98e593bff06913f283b9af"
5832
      },
5833
      {
5834
        "authoredDate": "2019-04-26T16:07:45Z",
5835
        "authors": [
5836
          {
5837
            "email": "[email protected]",
5838
            "id": "",
5839
            "login": "",
5840
            "name": "Gavin Howard"
5841
          }
5842
        ],
5843
        "committedDate": "2019-04-26T16:07:45Z",
5844
        "messageBody": "",
5845
        "messageHeadline": "Add a useful #define",
5846
        "oid": "1c1697cdc5724c5e2a2969e59fb17059d84b2272"
5847
      },
5848
      {
5849
        "authoredDate": "2019-04-26T16:13:45Z",
5850
        "authors": [
5851
          {
5852
            "email": "[email protected]",
5853
            "id": "",
5854
            "login": "",
5855
            "name": "Gavin Howard"
5856
          }
5857
        ],
5858
        "committedDate": "2019-04-26T16:13:45Z",
5859
        "messageBody": "",
5860
        "messageHeadline": "Make subtract work",
5861
        "oid": "e6f326ed2d30c6814fed8a26d57ac6a5847587c6"
5862
      },
5863
      {
5864
        "authoredDate": "2019-04-26T16:17:02Z",
5865
        "authors": [
5866
          {
5867
            "email": "[email protected]",
5868
            "id": "",
5869
            "login": "",
5870
            "name": "Gavin Howard"
5871
          }
5872
        ],
5873
        "committedDate": "2019-04-26T16:17:02Z",
5874
        "messageBody": "",
5875
        "messageHeadline": "Get rid of some compiler warnings",
5876
        "oid": "6fccd22b21b7f8cbf7ab2b48af912dd1ffb8bf8c"
5877
      },
5878
      {
5879
        "authoredDate": "2019-04-26T16:17:57Z",
5880
        "authors": [
5881
          {
5882
            "email": "[email protected]",
5883
            "id": "",
5884
            "login": "",
5885
            "name": "Gavin Howard"
5886
          }
5887
        ],
5888
        "committedDate": "2019-04-26T16:17:57Z",
5889
        "messageBody": "",
5890
        "messageHeadline": "Remove some done TODO comments",
5891
        "oid": "e2e67ecbda93721e0820a01ce4e5ce660010f7bc"
5892
      },
5893
      {
5894
        "authoredDate": "2019-04-26T16:40:02Z",
5895
        "authors": [
5896
          {
5897
            "email": "[email protected]",
5898
            "id": "",
5899
            "login": "",
5900
            "name": "Gavin Howard"
5901
          }
5902
        ],
5903
        "committedDate": "2019-04-26T16:40:02Z",
5904
        "messageBody": "",
5905
        "messageHeadline": "Fix some compiler warnings",
5906
        "oid": "c4783ac369bf46f1fbc894979fee2040e29008eb"
5907
      },
5908
      {
5909
        "authoredDate": "2019-04-26T20:32:07Z",
5910
        "authors": [
5911
          {
5912
            "email": "[email protected]",
5913
            "id": "",
5914
            "login": "",
5915
            "name": "Gavin Howard"
5916
          }
5917
        ],
5918
        "committedDate": "2019-04-26T20:32:07Z",
5919
        "messageBody": "",
5920
        "messageHeadline": "Some general cleanup on math",
5921
        "oid": "971a26711ea6c03cbd23fd22bc93d03ead700f14"
5922
      },
5923
      {
5924
        "authoredDate": "2019-04-26T20:32:55Z",
5925
        "authors": [
5926
          {
5927
            "email": "[email protected]",
5928
            "id": "",
5929
            "login": "",
5930
            "name": "Gavin Howard"
5931
          }
5932
        ],
5933
        "committedDate": "2019-04-26T20:32:55Z",
5934
        "messageBody": "",
5935
        "messageHeadline": "Make shift work",
5936
        "oid": "b155866dbb923e50d104ec210d095e14083fa372"
5937
      },
5938
      {
5939
        "authoredDate": "2019-04-26T20:33:43Z",
5940
        "authors": [
5941
          {
5942
            "email": "[email protected]",
5943
            "id": "",
5944
            "login": "",
5945
            "name": "Gavin Howard"
5946
          }
5947
        ],
5948
        "committedDate": "2019-04-26T20:33:43Z",
5949
        "messageBody": "",
5950
        "messageHeadline": "Remove a compiler warning",
5951
        "oid": "da6b543c1501f01e4b781c7b24d16b950cbf0bd1"
5952
      },
5953
      {
5954
        "authoredDate": "2019-04-26T20:46:52Z",
5955
        "authors": [
5956
          {
5957
            "email": "[email protected]",
5958
            "id": "",
5959
            "login": "",
5960
            "name": "Gavin Howard"
5961
          }
5962
        ],
5963
        "committedDate": "2019-04-26T20:46:52Z",
5964
        "messageBody": "",
5965
        "messageHeadline": "Fix truncate and extend",
5966
        "oid": "c9bef2d421dda2b0796a9ccb6198fe98ff56dd34"
5967
      },
5968
      {
5969
        "authoredDate": "2019-04-26T21:39:46Z",
5970
        "authors": [
5971
          {
5972
            "email": "[email protected]",
5973
            "id": "",
5974
            "login": "",
5975
            "name": "Gavin Howard"
5976
          }
5977
        ],
5978
        "committedDate": "2019-04-26T21:39:46Z",
5979
        "messageBody": "I don't think it is done, however; power still needs to be tested.",
5980
        "messageHeadline": "Make multiply pass its tests",
5981
        "oid": "48a0e4793be1f58638be5c1b8820944f92afc498"
5982
      },
5983
      {
5984
        "authoredDate": "2019-04-26T21:41:15Z",
5985
        "authors": [
5986
          {
5987
            "email": "[email protected]",
5988
            "id": "",
5989
            "login": "",
5990
            "name": "Gavin Howard"
5991
          }
5992
        ],
5993
        "committedDate": "2019-04-26T21:41:15Z",
5994
        "messageBody": "",
5995
        "messageHeadline": "Remove some TODO comments that are done",
5996
        "oid": "74b16c3bc8ec25b8c1e562ce04d68045692e1864"
5997
      },
5998
      {
5999
        "authoredDate": "2019-04-26T21:47:25Z",
6000
        "authors": [
6001
          {
6002
            "email": "[email protected]",
6003
            "id": "",
6004
            "login": "",
6005
            "name": "Gavin Howard"
6006
          }
6007
        ],
6008
        "committedDate": "2019-04-26T21:47:25Z",
6009
        "messageBody": "",
6010
        "messageHeadline": "Remove more TODO comments that are done",
6011
        "oid": "a3f260c53adfcdd0fcd01404e08260b65c87e1e7"
6012
      },
6013
      {
6014
        "authoredDate": "2019-04-26T21:59:15Z",
6015
        "authors": [
6016
          {
6017
            "email": "[email protected]",
6018
            "id": "",
6019
            "login": "",
6020
            "name": "Gavin Howard"
6021
          }
6022
        ],
6023
        "committedDate": "2019-04-26T21:59:15Z",
6024
        "messageBody": "",
6025
        "messageHeadline": "Clean up some style",
6026
        "oid": "404ece77d2e3e5009511e77a5f9e56d4e1afb3f7"
6027
      },
6028
      {
6029
        "authoredDate": "2019-04-26T21:59:33Z",
6030
        "authors": [
6031
          {
6032
            "email": "[email protected]",
6033
            "id": "",
6034
            "login": "",
6035
            "name": "Gavin Howard"
6036
          }
6037
        ],
6038
        "committedDate": "2019-04-26T21:59:33Z",
6039
        "messageBody": "",
6040
        "messageHeadline": "Fix various small issues",
6041
        "oid": "774454354a9354023b6fb7e3aa396b269a5562f7"
6042
      },
6043
      {
6044
        "authoredDate": "2019-04-26T23:29:01Z",
6045
        "authors": [
6046
          {
6047
            "email": "[email protected]",
6048
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6049
            "login": "stesser",
6050
            "name": "Stefan Esser"
6051
          }
6052
        ],
6053
        "committedDate": "2019-04-26T23:29:01Z",
6054
        "messageBody": "",
6055
        "messageHeadline": "Iterative division based on Newton Raphson algorithm",
6056
        "oid": "193f8529ad93306e39914ca7a2aa877669383f6f"
6057
      },
6058
      {
6059
        "authoredDate": "2019-04-27T01:31:31Z",
6060
        "authors": [
6061
          {
6062
            "email": "[email protected]",
6063
            "id": "",
6064
            "login": "",
6065
            "name": "Gavin Howard"
6066
          }
6067
        ],
6068
        "committedDate": "2019-04-27T01:31:31Z",
6069
        "messageBody": "",
6070
        "messageHeadline": "Change some code back to what it was (with adjustments)",
6071
        "oid": "c25fd61637390cc993c91258dda2c01404b37147"
6072
      },
6073
      {
6074
        "authoredDate": "2019-04-27T07:16:26Z",
6075
        "authors": [
6076
          {
6077
            "email": "[email protected]",
6078
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6079
            "login": "stesser",
6080
            "name": "Stefan Esser"
6081
          }
6082
        ],
6083
        "committedDate": "2019-04-27T07:16:26Z",
6084
        "messageBody": "",
6085
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
6086
        "oid": "87c27b5715646eb4deec4a6795c17b4c5facc408"
6087
      },
6088
      {
6089
        "authoredDate": "2019-04-27T08:39:00Z",
6090
        "authors": [
6091
          {
6092
            "email": "[email protected]",
6093
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6094
            "login": "stesser",
6095
            "name": "Stefan Esser"
6096
          }
6097
        ],
6098
        "committedDate": "2019-04-27T08:39:00Z",
6099
        "messageBody": "",
6100
        "messageHeadline": "Fix mismerge regarding nBcDig vs. places",
6101
        "oid": "70f118574077b6e61cae08bd576ca7fccc167786"
6102
      },
6103
      {
6104
        "authoredDate": "2019-04-27T08:40:14Z",
6105
        "authors": [
6106
          {
6107
            "email": "[email protected]",
6108
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6109
            "login": "stesser",
6110
            "name": "Stefan Esser"
6111
          }
6112
        ],
6113
        "committedDate": "2019-04-27T08:40:14Z",
6114
        "messageBody": "…e current rdx",
6115
        "messageHeadline": "Fix segmentation fault that occurs if the target rdx is lower than th…",
6116
        "oid": "6189d95036f123d48d505bf4d4a49ba11ca30aee"
6117
      },
6118
      {
6119
        "authoredDate": "2019-04-27T08:42:00Z",
6120
        "authors": [
6121
          {
6122
            "email": "[email protected]",
6123
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6124
            "login": "stesser",
6125
            "name": "Stefan Esser"
6126
          }
6127
        ],
6128
        "committedDate": "2019-04-27T08:42:00Z",
6129
        "messageBody": "",
6130
        "messageHeadline": "Add simple debug print macro",
6131
        "oid": "cdda6e99974b8f9551ad1bc184b3c735afac6f4a"
6132
      },
6133
      {
6134
        "authoredDate": "2019-04-27T11:47:09Z",
6135
        "authors": [
6136
          {
6137
            "email": "[email protected]",
6138
            "id": "",
6139
            "login": "",
6140
            "name": "Charlie Root"
6141
          }
6142
        ],
6143
        "committedDate": "2019-04-27T11:47:09Z",
6144
        "messageBody": "",
6145
        "messageHeadline": "Fix calculation of scale in multiplications",
6146
        "oid": "ac244bdb3ebe6e6a2693f3d5c2ae13d7723b3517"
6147
      },
6148
      {
6149
        "authoredDate": "2019-04-27T12:36:28Z",
6150
        "authors": [
6151
          {
6152
            "email": "[email protected]",
6153
            "id": "",
6154
            "login": "",
6155
            "name": "Gavin Howard"
6156
          }
6157
        ],
6158
        "committedDate": "2019-04-27T12:36:28Z",
6159
        "messageBody": "",
6160
        "messageHeadline": "Fix seg fault in bc_num_shiftLeft()",
6161
        "oid": "b1d29c24cb4bfa07f3bc3e665811ab8b100b0b5e"
6162
      },
6163
      {
6164
        "authoredDate": "2019-04-27T12:40:58Z",
6165
        "authors": [
6166
          {
6167
            "email": "[email protected]",
6168
            "id": "",
6169
            "login": "",
6170
            "name": "Gavin D. Howard"
6171
          }
6172
        ],
6173
        "committedDate": "2019-04-27T12:40:58Z",
6174
        "messageBody": "Newton-Raphson based division",
6175
        "messageHeadline": "Merge pull request #16 from stesser/d9",
6176
        "oid": "769fcbed7a3a0005a60254c0ed5203406b533ae3"
6177
      },
6178
      {
6179
        "authoredDate": "2019-04-27T12:41:58Z",
6180
        "authors": [
6181
          {
6182
            "email": "[email protected]",
6183
            "id": "",
6184
            "login": "",
6185
            "name": "Gavin Howard"
6186
          }
6187
        ],
6188
        "committedDate": "2019-04-27T12:41:58Z",
6189
        "messageBody": "",
6190
        "messageHeadline": "Fix some style",
6191
        "oid": "2e736dee1ae4ddadbe4305296fc98ecc9a917e45"
6192
      },
6193
      {
6194
        "authoredDate": "2019-04-27T12:43:57Z",
6195
        "authors": [
6196
          {
6197
            "email": "[email protected]",
6198
            "id": "",
6199
            "login": "",
6200
            "name": "Gavin Howard"
6201
          }
6202
        ],
6203
        "committedDate": "2019-04-27T12:43:57Z",
6204
        "messageBody": "",
6205
        "messageHeadline": "Fix the multiplication scale back",
6206
        "oid": "cf9f246919f39e50c911c6552d9b16f05a0fc2cf"
6207
      },
6208
      {
6209
        "authoredDate": "2019-04-27T12:51:33Z",
6210
        "authors": [
6211
          {
6212
            "email": "[email protected]",
6213
            "id": "",
6214
            "login": "",
6215
            "name": "Gavin Howard"
6216
          }
6217
        ],
6218
        "committedDate": "2019-04-27T12:51:33Z",
6219
        "messageBody": "",
6220
        "messageHeadline": "Merge branch 'master' into base9",
6221
        "oid": "5de0bd695347a0ef5bde2d526472a2a3ba6d2a17"
6222
      },
6223
      {
6224
        "authoredDate": "2019-04-27T13:26:35Z",
6225
        "authors": [
6226
          {
6227
            "email": "[email protected]",
6228
            "id": "",
6229
            "login": "",
6230
            "name": "Gavin Howard"
6231
          }
6232
        ],
6233
        "committedDate": "2019-04-27T13:26:35Z",
6234
        "messageBody": "",
6235
        "messageHeadline": "Add another print debug function",
6236
        "oid": "5b40e402dc37897052129db14441695a25bd86f8"
6237
      },
6238
      {
6239
        "authoredDate": "2019-04-27T13:28:24Z",
6240
        "authors": [
6241
          {
6242
            "email": "[email protected]",
6243
            "id": "",
6244
            "login": "",
6245
            "name": "Gavin Howard"
6246
          }
6247
        ],
6248
        "committedDate": "2019-04-27T13:28:24Z",
6249
        "messageBody": "",
6250
        "messageHeadline": "Change bc_num_printDigs() a bit",
6251
        "oid": "37118f4c4f26f64bb4becb0caa55149659ca8ac3"
6252
      },
6253
      {
6254
        "authoredDate": "2019-04-27T13:28:45Z",
6255
        "authors": [
6256
          {
6257
            "email": "[email protected]",
6258
            "id": "",
6259
            "login": "",
6260
            "name": "Gavin Howard"
6261
          }
6262
        ],
6263
        "committedDate": "2019-04-27T13:28:45Z",
6264
        "messageBody": "",
6265
        "messageHeadline": "Fix a divide by 0",
6266
        "oid": "edd9d9dd1459746a4bb2012194a3d3c831414c68"
6267
      },
6268
      {
6269
        "authoredDate": "2019-04-27T13:28:56Z",
6270
        "authors": [
6271
          {
6272
            "email": "[email protected]",
6273
            "id": "",
6274
            "login": "",
6275
            "name": "Gavin Howard"
6276
          }
6277
        ],
6278
        "committedDate": "2019-04-27T13:28:56Z",
6279
        "messageBody": "",
6280
        "messageHeadline": "Fix some style",
6281
        "oid": "034b5b9e16e57becf5121ed60ae1dac8b8dc4ece"
6282
      },
6283
      {
6284
        "authoredDate": "2019-04-27T13:33:16Z",
6285
        "authors": [
6286
          {
6287
            "email": "[email protected]",
6288
            "id": "",
6289
            "login": "",
6290
            "name": "Gavin Howard"
6291
          }
6292
        ],
6293
        "committedDate": "2019-04-27T13:33:16Z",
6294
        "messageBody": "",
6295
        "messageHeadline": "Fix more style",
6296
        "oid": "c88e5231008923290d1ead34ff987fb2e17043c5"
6297
      },
6298
      {
6299
        "authoredDate": "2019-04-27T13:34:13Z",
6300
        "authors": [
6301
          {
6302
            "email": "[email protected]",
6303
            "id": "",
6304
            "login": "",
6305
            "name": "Gavin Howard"
6306
          }
6307
        ],
6308
        "committedDate": "2019-04-27T13:34:13Z",
6309
        "messageBody": "",
6310
        "messageHeadline": "Fix even more style",
6311
        "oid": "20afaeab2ffca9a32e1fa65feeb33050d9c4e204"
6312
      },
6313
      {
6314
        "authoredDate": "2019-04-27T13:53:23Z",
6315
        "authors": [
6316
          {
6317
            "email": "[email protected]",
6318
            "id": "",
6319
            "login": "",
6320
            "name": "Gavin Howard"
6321
          }
6322
        ],
6323
        "committedDate": "2019-04-27T13:53:23Z",
6324
        "messageBody": "",
6325
        "messageHeadline": "Move an item",
6326
        "oid": "948b639a0674f3ce836fe3ba843e2253ef798cd8"
6327
      },
6328
      {
6329
        "authoredDate": "2019-04-27T13:53:36Z",
6330
        "authors": [
6331
          {
6332
            "email": "[email protected]",
6333
            "id": "",
6334
            "login": "",
6335
            "name": "Gavin Howard"
6336
          }
6337
        ],
6338
        "committedDate": "2019-04-27T13:53:36Z",
6339
        "messageBody": "",
6340
        "messageHeadline": "Remove two unused functions",
6341
        "oid": "2316cb42fdff7b768debf3d9c65b73c9c8fc6137"
6342
      },
6343
      {
6344
        "authoredDate": "2019-04-27T14:09:32Z",
6345
        "authors": [
6346
          {
6347
            "email": "[email protected]",
6348
            "id": "",
6349
            "login": "",
6350
            "name": "Gavin Howard"
6351
          }
6352
        ],
6353
        "committedDate": "2019-04-27T14:09:32Z",
6354
        "messageBody": "",
6355
        "messageHeadline": "Add length and scale tests",
6356
        "oid": "805328cdb9342eb249dc398b4569190d7ca78747"
6357
      },
6358
      {
6359
        "authoredDate": "2019-04-27T14:30:10Z",
6360
        "authors": [
6361
          {
6362
            "email": "[email protected]",
6363
            "id": "",
6364
            "login": "",
6365
            "name": "Gavin Howard"
6366
          }
6367
        ],
6368
        "committedDate": "2019-04-27T14:30:10Z",
6369
        "messageBody": "",
6370
        "messageHeadline": "Make length work",
6371
        "oid": "b41483b364bf8fe8841e8875febeb4d58743e32f"
6372
      },
6373
      {
6374
        "authoredDate": "2019-04-27T21:33:08Z",
6375
        "authors": [
6376
          {
6377
            "email": "[email protected]",
6378
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6379
            "login": "stesser",
6380
            "name": "Stefan Esser"
6381
          }
6382
        ],
6383
        "committedDate": "2019-04-27T21:33:08Z",
6384
        "messageBody": "…upstream changes",
6385
        "messageHeadline": "Updated implementation of Newton-Raphson division algorithm to match …",
6386
        "oid": "b5aeb445a556de9d9b41a7b2d196b59bcaca90ae"
6387
      },
6388
      {
6389
        "authoredDate": "2019-04-27T21:41:21Z",
6390
        "authors": [
6391
          {
6392
            "email": "[email protected]",
6393
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6394
            "login": "stesser",
6395
            "name": "Stefan Esser"
6396
          }
6397
        ],
6398
        "committedDate": "2019-04-27T21:41:21Z",
6399
        "messageBody": "",
6400
        "messageHeadline": "Small optimization of the division function",
6401
        "oid": "6e129fc621b358d219036e6e4d01f572adb133ff"
6402
      },
6403
      {
6404
        "authoredDate": "2019-04-27T21:43:02Z",
6405
        "authors": [
6406
          {
6407
            "email": "[email protected]",
6408
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6409
            "login": "stesser",
6410
            "name": "Stefan Esser"
6411
          }
6412
        ],
6413
        "committedDate": "2019-04-27T21:43:02Z",
6414
        "messageBody": "",
6415
        "messageHeadline": "Small optimization of the division function",
6416
        "oid": "217379d6199e6bb8b586716b382731882c6096fe"
6417
      },
6418
      {
6419
        "authoredDate": "2019-04-27T21:45:48Z",
6420
        "authors": [
6421
          {
6422
            "email": "[email protected]",
6423
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6424
            "login": "stesser",
6425
            "name": "Stefan Esser"
6426
          }
6427
        ],
6428
        "committedDate": "2019-04-27T21:45:48Z",
6429
        "messageBody": "",
6430
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
6431
        "oid": "45a56123c3c6ede3cf157419e56427a01ff48e2a"
6432
      },
6433
      {
6434
        "authoredDate": "2019-04-28T00:04:02Z",
6435
        "authors": [
6436
          {
6437
            "email": "[email protected]",
6438
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6439
            "login": "stesser",
6440
            "name": "Stefan Eßer"
6441
          }
6442
        ],
6443
        "committedDate": "2019-04-28T00:04:02Z",
6444
        "messageBody": "He says that he made division work. Cool.",
6445
        "messageHeadline": "Import more code from Stefan",
6446
        "oid": "daaaaa795095115e813ad7c7afbae0937a046246"
6447
      },
6448
      {
6449
        "authoredDate": "2019-04-28T10:30:47Z",
6450
        "authors": [
6451
          {
6452
            "email": "[email protected]",
6453
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6454
            "login": "stesser",
6455
            "name": "Stefan Esser"
6456
          }
6457
        ],
6458
        "committedDate": "2019-04-28T10:30:47Z",
6459
        "messageBody": "I had missed to set scsale values in the parameters passed in by the divide\nfunction and thus got results that had 0 fractional digits.",
6460
        "messageHeadline": "Undo change to scale calculation in bc_num_m",
6461
        "oid": "d793fa5c3a03370627e45d5f03968039b10f34c6"
6462
      },
6463
      {
6464
        "authoredDate": "2019-04-28T12:58:58Z",
6465
        "authors": [
6466
          {
6467
            "email": "[email protected]",
6468
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6469
            "login": "stesser",
6470
            "name": "Stefan Esser"
6471
          }
6472
        ],
6473
        "committedDate": "2019-04-28T12:58:58Z",
6474
        "messageBody": "This function will be used in the division algorithm.",
6475
        "messageHeadline": "Add function to round number to a given number of decimal places",
6476
        "oid": "db970636e68f62f41c17c6053e5ccc242161e5a0"
6477
      },
6478
      {
6479
        "authoredDate": "2019-04-28T13:50:14Z",
6480
        "authors": [
6481
          {
6482
            "email": "[email protected]",
6483
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6484
            "login": "stesser",
6485
            "name": "Stefan Esser"
6486
          }
6487
        ],
6488
        "committedDate": "2019-04-28T13:50:14Z",
6489
        "messageBody": "I had a local change that made bc_num_invert implicily extend this variable,\nbut noticed with that change reverted that the precision of the calculation\nwas reduced to BC_BASE_POWER decimals, leading to imprecise division results.",
6490
        "messageHeadline": "Fix division: Extend variable to required number of decimal places",
6491
        "oid": "70997150a28b4df49639924431cb0706a403207f"
6492
      },
6493
      {
6494
        "authoredDate": "2019-04-28T15:21:34Z",
6495
        "authors": [
6496
          {
6497
            "email": "[email protected]",
6498
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6499
            "login": "stesser",
6500
            "name": "Stefan Esser"
6501
          }
6502
        ],
6503
        "committedDate": "2019-04-28T15:21:34Z",
6504
        "messageBody": "For now, keep the Newton-Raphson algorithm in an #if 0 block for reference and to\nallow to compare them in further tests.\n\nI have noticed segmentation faults when dividing very large numbers, which probably\nare due to missing calls of bc_num_extend() for destination variables of arithmetic\noperations. I'll try to fix the length calculations, but I do not know the exact\nsemantics of a number of low level calls.",
6505
        "messageHeadline": "Replace Newton-Raphson algorithm by Goldschmidt algorithm.",
6506
        "oid": "154b473a9c65f081d673556ce163c50754cf75de"
6507
      },
6508
      {
6509
        "authoredDate": "2019-04-28T18:19:51Z",
6510
        "authors": [
6511
          {
6512
            "email": "[email protected]",
6513
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6514
            "login": "stesser",
6515
            "name": "Stefan Esser"
6516
          }
6517
        ],
6518
        "committedDate": "2019-04-28T18:19:51Z",
6519
        "messageBody": "",
6520
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
6521
        "oid": "307ce024f26a0433460a84ad5ad22bd3ac6f094f"
6522
      },
6523
      {
6524
        "authoredDate": "2019-04-28T19:32:13Z",
6525
        "authors": [
6526
          {
6527
            "email": "[email protected]",
6528
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6529
            "login": "stesser",
6530
            "name": "Stefan Esser"
6531
          }
6532
        ],
6533
        "committedDate": "2019-04-28T19:32:13Z",
6534
        "messageBody": "",
6535
        "messageHeadline": "Optimize bc_num_pow10",
6536
        "oid": "72109f49b8cd1e877c4b4252652d73f21d0ad689"
6537
      },
6538
      {
6539
        "authoredDate": "2019-04-28T22:59:32Z",
6540
        "authors": [
6541
          {
6542
            "email": "[email protected]",
6543
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6544
            "login": "stesser",
6545
            "name": "Stefan Esser"
6546
          }
6547
        ],
6548
        "committedDate": "2019-04-28T22:59:32Z",
6549
        "messageBody": "This makes bc complete the tests without crash, but with a result that\nhas too few digits printed. This will need to be debugged next ...",
6550
        "messageHeadline": "Fix scale parameters and remove bogus bc_num_extend calls",
6551
        "oid": "4c1e43af931618094a761dff7d1e4b0374e7576d"
6552
      },
6553
      {
6554
        "authoredDate": "2019-04-29T10:56:32Z",
6555
        "authors": [
6556
          {
6557
            "email": "[email protected]",
6558
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6559
            "login": "stesser",
6560
            "name": "Stefan Esser"
6561
          }
6562
        ],
6563
        "committedDate": "2019-04-29T10:56:32Z",
6564
        "messageBody": "Now all division and multiplication tests pass.",
6565
        "messageHeadline": "Fix position of decimal point when dividing by a very small number.",
6566
        "oid": "40b53d23eb92b69a9d079ead59def298cb089370"
6567
      },
6568
      {
6569
        "authoredDate": "2019-04-29T11:00:23Z",
6570
        "authors": [
6571
          {
6572
            "email": "[email protected]",
6573
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6574
            "login": "stesser",
6575
            "name": "Stefan Esser"
6576
          }
6577
        ],
6578
        "committedDate": "2019-04-29T11:00:23Z",
6579
        "messageBody": "",
6580
        "messageHeadline": "Improve format of dumped BcNum values in debug traces",
6581
        "oid": "33a1c689f4d5cf2026c92a954c36a50f6e772c8e"
6582
      },
6583
      {
6584
        "authoredDate": "2019-04-29T12:24:31Z",
6585
        "authors": [
6586
          {
6587
            "email": "[email protected]",
6588
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6589
            "login": "stesser",
6590
            "name": "Stefan Esser"
6591
          }
6592
        ],
6593
        "committedDate": "2019-04-29T12:24:31Z",
6594
        "messageBody": "There were 4 places where \"rdx\" had to be replaced by \"scale\".\nThis version passes all tests.",
6595
        "messageHeadline": "Fix \"power\" operator (bc_num_p).",
6596
        "oid": "c66e44871c84fc81a3595d21d9174082b62da1d3"
6597
      },
6598
      {
6599
        "authoredDate": "2019-04-29T13:06:00Z",
6600
        "authors": [
6601
          {
6602
            "email": "[email protected]",
6603
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6604
            "login": "stesser",
6605
            "name": "Stefan Esser"
6606
          }
6607
        ],
6608
        "committedDate": "2019-04-29T13:06:00Z",
6609
        "messageBody": "Results seem to be correct except for the number of decimals calculated and returned.\nThe tests still fail for that reason, but show results that are near to what is expected.",
6610
        "messageHeadline": "Mostly fix the sqrt operation.",
6611
        "oid": "627693667ff6b0bc70f4a636bd282423af74df62"
6612
      },
6613
      {
6614
        "authoredDate": "2019-04-29T13:36:46Z",
6615
        "authors": [
6616
          {
6617
            "email": "[email protected]",
6618
            "id": "",
6619
            "login": "",
6620
            "name": "Gavin Howard"
6621
          }
6622
        ],
6623
        "committedDate": "2019-04-29T13:36:46Z",
6624
        "messageBody": "",
6625
        "messageHeadline": "Start building Goldschmidt",
6626
        "oid": "fdbcd063e2eab65ca07be9f62bdd10cc965a220d"
6627
      },
6628
      {
6629
        "authoredDate": "2019-04-29T13:56:04Z",
6630
        "authors": [
6631
          {
6632
            "email": "[email protected]",
6633
            "id": "",
6634
            "login": "",
6635
            "name": "Gavin Howard"
6636
          }
6637
        ],
6638
        "committedDate": "2019-04-29T13:56:04Z",
6639
        "messageBody": "",
6640
        "messageHeadline": "Add a useful function",
6641
        "oid": "08f7856b38ca730b120e450dea482d0e18fd2232"
6642
      },
6643
      {
6644
        "authoredDate": "2019-04-29T15:10:43Z",
6645
        "authors": [
6646
          {
6647
            "email": "[email protected]",
6648
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6649
            "login": "stesser",
6650
            "name": "Stefan Esser"
6651
          }
6652
        ],
6653
        "committedDate": "2019-04-29T15:10:43Z",
6654
        "messageBody": "…orithm\n\nIntroduce and use a function bc_num_int_digits() that counts the number of digits\nto the left of the decimalpoint.",
6655
        "messageHeadline": "Fix and improve the calculation of the initial value for the sqrt alg…",
6656
        "oid": "cc7cd938dadfd8ecbaf61e79f7fba8060ff7194c"
6657
      },
6658
      {
6659
        "authoredDate": "2019-04-29T16:14:21Z",
6660
        "authors": [
6661
          {
6662
            "email": "[email protected]",
6663
            "id": "",
6664
            "login": "",
6665
            "name": "Gavin Howard"
6666
          }
6667
        ],
6668
        "committedDate": "2019-04-29T16:14:21Z",
6669
        "messageBody": "There are still some cases that fail, but this is mostly working, and I\nwould like to save my progress.",
6670
        "messageHeadline": "Make most of divide work",
6671
        "oid": "36ec987c22af5d7ccc3b8aef0fe9758ce85c56a0"
6672
      },
6673
      {
6674
        "authoredDate": "2019-04-29T16:28:33Z",
6675
        "authors": [
6676
          {
6677
            "email": "[email protected]",
6678
            "id": "",
6679
            "login": "",
6680
            "name": "Gavin Howard"
6681
          }
6682
        ],
6683
        "committedDate": "2019-04-29T16:28:33Z",
6684
        "messageBody": "",
6685
        "messageHeadline": "Make divide work",
6686
        "oid": "cef0397c810152aed4116fdc56dcf920d20eda32"
6687
      }
6688
    ],
6689
    "createdAt": "2019-04-29T11:21:03Z",
6690
    "deletions": 234,
6691
    "files": [
6692
      {
6693
        "path": "include/num.h",
6694
        "additions": 71,
6695
        "deletions": 4
6696
      },
6697
      {
6698
        "path": "include/status.h",
6699
        "additions": 2,
6700
        "deletions": 0
6701
      },
6702
      {
6703
        "path": "include/vm.h",
6704
        "additions": 0,
6705
        "deletions": 2
6706
      },
6707
      {
6708
        "path": "src/num.c",
6709
        "additions": 838,
6710
        "deletions": 223
6711
      },
6712
      {
6713
        "path": "src/program.c",
6714
        "additions": 2,
6715
        "deletions": 2
6716
      },
6717
      {
6718
        "path": "tests/all.sh",
6719
        "additions": 1,
6720
        "deletions": 1
6721
      },
6722
      {
6723
        "path": "tests/bc/all.txt",
6724
        "additions": 4,
6725
        "deletions": 2
6726
      },
6727
      {
6728
        "path": "tests/bc/decimal.txt",
6729
        "additions": 23,
6730
        "deletions": 0
6731
      },
6732
      {
6733
        "path": "tests/bc/decimal_results.txt",
6734
        "additions": 23,
6735
        "deletions": 0
6736
      },
6737
      {
6738
        "path": "tests/bc/divide.txt",
6739
        "additions": 31,
6740
        "deletions": 0
6741
      },
6742
      {
6743
        "path": "tests/bc/divide_results.txt",
6744
        "additions": 30,
6745
        "deletions": 0
6746
      },
6747
      {
6748
        "path": "tests/bc/length.txt",
6749
        "additions": 59,
6750
        "deletions": 0
6751
      },
6752
      {
6753
        "path": "tests/bc/length_results.txt",
6754
        "additions": 57,
6755
        "deletions": 0
6756
      },
6757
      {
6758
        "path": "tests/bc/scale.txt",
6759
        "additions": 56,
6760
        "deletions": 0
6761
      },
6762
      {
6763
        "path": "tests/bc/scale_results.txt",
6764
        "additions": 56,
6765
        "deletions": 0
6766
      },
6767
      {
6768
        "path": "tests/bc/shift.txt",
6769
        "additions": 5280,
6770
        "deletions": 0
6771
      },
6772
      {
6773
        "path": "tests/bc/shift_results.txt",
6774
        "additions": 5280,
6775
        "deletions": 0
6776
      }
6777
    ],
6778
    "fullDatabaseId": "274334078",
6779
    "headRefName": "d9",
6780
    "headRefOid": "914a7f66807b3567fa438c8d668a040e9d2bcc4a",
6781
    "headRepository": {
6782
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
6783
      "name": "bc"
6784
    },
6785
    "headRepositoryOwner": {
6786
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
6787
      "name": "Stefan Eßer",
6788
      "login": "stesser"
6789
    },
6790
    "id": "MDExOlB1bGxSZXF1ZXN0Mjc0MzM0MDc4",
6791
    "isCrossRepository": true,
6792
    "isDraft": false,
6793
    "labels": [],
6794
    "latestReviews": [],
6795
    "maintainerCanModify": false,
6796
    "mergeCommit": {
6797
      "oid": "914a7f66807b3567fa438c8d668a040e9d2bcc4a"
6798
    },
6799
    "mergeStateStatus": "UNKNOWN",
6800
    "mergeable": "UNKNOWN",
6801
    "mergedAt": "2019-05-06T13:42:00Z",
6802
    "mergedBy": {
6803
      "id": "MDQ6VXNlcjMxNzI2ODc=",
6804
      "is_bot": false,
6805
      "login": "gavinhoward",
6806
      "name": "Gavin D. Howard"
6807
    },
6808
    "milestone": null,
6809
    "number": 18,
6810
    "potentialMergeCommit": null,
6811
    "projectCards": [],
6812
    "projectItems": [],
6813
    "reactionGroups": [],
6814
    "reviewDecision": "",
6815
    "reviewRequests": [],
6816
    "reviews": [],
6817
    "state": "MERGED",
6818
    "statusCheckRollup": [],
6819
    "title": "Division and modulo pass all tests",
6820
    "updatedAt": "2019-05-06T13:42:00Z",
6821
    "url": "https://github.com/gavinhoward/bc/pull/18"
6822
  },
6823
  {
6824
    "additions": 295,
6825
    "assignees": [],
6826
    "author": {
6827
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
6828
      "is_bot": false,
6829
      "login": "stesser",
6830
      "name": "Stefan Eßer"
6831
    },
6832
    "autoMergeRequest": null,
6833
    "baseRefName": "base9",
6834
    "baseRefOid": "e396dff5929071da830a84b64405f7a7c8e0113e",
6835
    "body": "I'm still not sure about correct scale values and situations in which bc_num_extend must be called to prepare a BcNum that is to receive the result of an arithmetic operation. This leads to overflow for large values (the algorithm is essentially correct, but variables need to be extended in some cases).",
6836
    "changedFiles": 4,
6837
    "closed": true,
6838
    "closedAt": "2019-05-06T13:42:50Z",
6839
    "comments": [
6840
      {
6841
        "id": "MDEyOklzc3VlQ29tbWVudDQ4NzM5MDI1OA==",
6842
        "author": {
6843
          "login": "gavinhoward"
6844
        },
6845
        "authorAssociation": "OWNER",
6846
        "body": "How does this new algorithm compare to Newton-Raphson performance-wise?",
6847
        "createdAt": "2019-04-28T15:38:21Z",
6848
        "includesCreatedEdit": false,
6849
        "isMinimized": false,
6850
        "minimizedReason": "",
6851
        "reactionGroups": [],
6852
        "url": "https://github.com/gavinhoward/bc/pull/17#issuecomment-487390258",
6853
        "viewerDidAuthor": true
6854
      },
6855
      {
6856
        "id": "MDEyOklzc3VlQ29tbWVudDQ4NzQwNzQ5NA==",
6857
        "author": {
6858
          "login": "gavinhoward"
6859
        },
6860
        "authorAssociation": "OWNER",
6861
        "body": "Also, would it be possible for you to fix the crashes on both algorithms? The test suite crashes on both. It would also be nice if you could put them in a #if 0 #else #endif set so I can test the changes and see which one is faster. Thank you.",
6862
        "createdAt": "2019-04-28T19:14:59Z",
6863
        "includesCreatedEdit": false,
6864
        "isMinimized": false,
6865
        "minimizedReason": "",
6866
        "reactionGroups": [],
6867
        "url": "https://github.com/gavinhoward/bc/pull/17#issuecomment-487407494",
6868
        "viewerDidAuthor": true
6869
      },
6870
      {
6871
        "id": "MDEyOklzc3VlQ29tbWVudDQ4OTYyNTA2NA==",
6872
        "author": {
6873
          "login": "gavinhoward"
6874
        },
6875
        "authorAssociation": "OWNER",
6876
        "body": "Closed by manually merging.",
6877
        "createdAt": "2019-05-06T13:42:50Z",
6878
        "includesCreatedEdit": false,
6879
        "isMinimized": false,
6880
        "minimizedReason": "",
6881
        "reactionGroups": [],
6882
        "url": "https://github.com/gavinhoward/bc/pull/17#issuecomment-489625064",
6883
        "viewerDidAuthor": true
6884
      }
6885
    ],
6886
    "commits": [
6887
      {
6888
        "authoredDate": "2019-04-27T21:33:08Z",
6889
        "authors": [
6890
          {
6891
            "email": "[email protected]",
6892
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6893
            "login": "stesser",
6894
            "name": "Stefan Esser"
6895
          }
6896
        ],
6897
        "committedDate": "2019-04-27T21:33:08Z",
6898
        "messageBody": "…upstream changes",
6899
        "messageHeadline": "Updated implementation of Newton-Raphson division algorithm to match …",
6900
        "oid": "b5aeb445a556de9d9b41a7b2d196b59bcaca90ae"
6901
      },
6902
      {
6903
        "authoredDate": "2019-04-27T21:41:21Z",
6904
        "authors": [
6905
          {
6906
            "email": "[email protected]",
6907
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6908
            "login": "stesser",
6909
            "name": "Stefan Esser"
6910
          }
6911
        ],
6912
        "committedDate": "2019-04-27T21:41:21Z",
6913
        "messageBody": "",
6914
        "messageHeadline": "Small optimization of the division function",
6915
        "oid": "6e129fc621b358d219036e6e4d01f572adb133ff"
6916
      },
6917
      {
6918
        "authoredDate": "2019-04-27T21:43:02Z",
6919
        "authors": [
6920
          {
6921
            "email": "[email protected]",
6922
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6923
            "login": "stesser",
6924
            "name": "Stefan Esser"
6925
          }
6926
        ],
6927
        "committedDate": "2019-04-27T21:43:02Z",
6928
        "messageBody": "",
6929
        "messageHeadline": "Small optimization of the division function",
6930
        "oid": "217379d6199e6bb8b586716b382731882c6096fe"
6931
      },
6932
      {
6933
        "authoredDate": "2019-04-27T21:45:48Z",
6934
        "authors": [
6935
          {
6936
            "email": "[email protected]",
6937
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6938
            "login": "stesser",
6939
            "name": "Stefan Esser"
6940
          }
6941
        ],
6942
        "committedDate": "2019-04-27T21:45:48Z",
6943
        "messageBody": "",
6944
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
6945
        "oid": "45a56123c3c6ede3cf157419e56427a01ff48e2a"
6946
      },
6947
      {
6948
        "authoredDate": "2019-04-28T10:30:47Z",
6949
        "authors": [
6950
          {
6951
            "email": "[email protected]",
6952
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6953
            "login": "stesser",
6954
            "name": "Stefan Esser"
6955
          }
6956
        ],
6957
        "committedDate": "2019-04-28T10:30:47Z",
6958
        "messageBody": "I had missed to set scsale values in the parameters passed in by the divide\nfunction and thus got results that had 0 fractional digits.",
6959
        "messageHeadline": "Undo change to scale calculation in bc_num_m",
6960
        "oid": "d793fa5c3a03370627e45d5f03968039b10f34c6"
6961
      },
6962
      {
6963
        "authoredDate": "2019-04-28T12:58:58Z",
6964
        "authors": [
6965
          {
6966
            "email": "[email protected]",
6967
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6968
            "login": "stesser",
6969
            "name": "Stefan Esser"
6970
          }
6971
        ],
6972
        "committedDate": "2019-04-28T12:58:58Z",
6973
        "messageBody": "This function will be used in the division algorithm.",
6974
        "messageHeadline": "Add function to round number to a given number of decimal places",
6975
        "oid": "db970636e68f62f41c17c6053e5ccc242161e5a0"
6976
      },
6977
      {
6978
        "authoredDate": "2019-04-28T13:50:14Z",
6979
        "authors": [
6980
          {
6981
            "email": "[email protected]",
6982
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6983
            "login": "stesser",
6984
            "name": "Stefan Esser"
6985
          }
6986
        ],
6987
        "committedDate": "2019-04-28T13:50:14Z",
6988
        "messageBody": "I had a local change that made bc_num_invert implicily extend this variable,\nbut noticed with that change reverted that the precision of the calculation\nwas reduced to BC_BASE_POWER decimals, leading to imprecise division results.",
6989
        "messageHeadline": "Fix division: Extend variable to required number of decimal places",
6990
        "oid": "70997150a28b4df49639924431cb0706a403207f"
6991
      },
6992
      {
6993
        "authoredDate": "2019-04-28T15:21:34Z",
6994
        "authors": [
6995
          {
6996
            "email": "[email protected]",
6997
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
6998
            "login": "stesser",
6999
            "name": "Stefan Esser"
7000
          }
7001
        ],
7002
        "committedDate": "2019-04-28T15:21:34Z",
7003
        "messageBody": "For now, keep the Newton-Raphson algorithm in an #if 0 block for reference and to\nallow to compare them in further tests.\n\nI have noticed segmentation faults when dividing very large numbers, which probably\nare due to missing calls of bc_num_extend() for destination variables of arithmetic\noperations. I'll try to fix the length calculations, but I do not know the exact\nsemantics of a number of low level calls.",
7004
        "messageHeadline": "Replace Newton-Raphson algorithm by Goldschmidt algorithm.",
7005
        "oid": "154b473a9c65f081d673556ce163c50754cf75de"
7006
      },
7007
      {
7008
        "authoredDate": "2019-04-28T18:19:51Z",
7009
        "authors": [
7010
          {
7011
            "email": "[email protected]",
7012
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7013
            "login": "stesser",
7014
            "name": "Stefan Esser"
7015
          }
7016
        ],
7017
        "committedDate": "2019-04-28T18:19:51Z",
7018
        "messageBody": "",
7019
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
7020
        "oid": "307ce024f26a0433460a84ad5ad22bd3ac6f094f"
7021
      },
7022
      {
7023
        "authoredDate": "2019-04-28T19:32:13Z",
7024
        "authors": [
7025
          {
7026
            "email": "[email protected]",
7027
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7028
            "login": "stesser",
7029
            "name": "Stefan Esser"
7030
          }
7031
        ],
7032
        "committedDate": "2019-04-28T19:32:13Z",
7033
        "messageBody": "",
7034
        "messageHeadline": "Optimize bc_num_pow10",
7035
        "oid": "72109f49b8cd1e877c4b4252652d73f21d0ad689"
7036
      },
7037
      {
7038
        "authoredDate": "2019-04-28T22:59:32Z",
7039
        "authors": [
7040
          {
7041
            "email": "[email protected]",
7042
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7043
            "login": "stesser",
7044
            "name": "Stefan Esser"
7045
          }
7046
        ],
7047
        "committedDate": "2019-04-28T22:59:32Z",
7048
        "messageBody": "This makes bc complete the tests without crash, but with a result that\nhas too few digits printed. This will need to be debugged next ...",
7049
        "messageHeadline": "Fix scale parameters and remove bogus bc_num_extend calls",
7050
        "oid": "4c1e43af931618094a761dff7d1e4b0374e7576d"
7051
      },
7052
      {
7053
        "authoredDate": "2019-04-29T10:56:32Z",
7054
        "authors": [
7055
          {
7056
            "email": "[email protected]",
7057
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7058
            "login": "stesser",
7059
            "name": "Stefan Esser"
7060
          }
7061
        ],
7062
        "committedDate": "2019-04-29T10:56:32Z",
7063
        "messageBody": "Now all division and multiplication tests pass.",
7064
        "messageHeadline": "Fix position of decimal point when dividing by a very small number.",
7065
        "oid": "40b53d23eb92b69a9d079ead59def298cb089370"
7066
      },
7067
      {
7068
        "authoredDate": "2019-04-29T11:00:23Z",
7069
        "authors": [
7070
          {
7071
            "email": "[email protected]",
7072
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7073
            "login": "stesser",
7074
            "name": "Stefan Esser"
7075
          }
7076
        ],
7077
        "committedDate": "2019-04-29T11:00:23Z",
7078
        "messageBody": "",
7079
        "messageHeadline": "Improve format of dumped BcNum values in debug traces",
7080
        "oid": "33a1c689f4d5cf2026c92a954c36a50f6e772c8e"
7081
      },
7082
      {
7083
        "authoredDate": "2019-04-29T12:24:31Z",
7084
        "authors": [
7085
          {
7086
            "email": "[email protected]",
7087
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7088
            "login": "stesser",
7089
            "name": "Stefan Esser"
7090
          }
7091
        ],
7092
        "committedDate": "2019-04-29T12:24:31Z",
7093
        "messageBody": "There were 4 places where \"rdx\" had to be replaced by \"scale\".\nThis version passes all tests.",
7094
        "messageHeadline": "Fix \"power\" operator (bc_num_p).",
7095
        "oid": "c66e44871c84fc81a3595d21d9174082b62da1d3"
7096
      },
7097
      {
7098
        "authoredDate": "2019-04-29T13:06:00Z",
7099
        "authors": [
7100
          {
7101
            "email": "[email protected]",
7102
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7103
            "login": "stesser",
7104
            "name": "Stefan Esser"
7105
          }
7106
        ],
7107
        "committedDate": "2019-04-29T13:06:00Z",
7108
        "messageBody": "Results seem to be correct except for the number of decimals calculated and returned.\nThe tests still fail for that reason, but show results that are near to what is expected.",
7109
        "messageHeadline": "Mostly fix the sqrt operation.",
7110
        "oid": "627693667ff6b0bc70f4a636bd282423af74df62"
7111
      },
7112
      {
7113
        "authoredDate": "2019-04-29T15:10:43Z",
7114
        "authors": [
7115
          {
7116
            "email": "[email protected]",
7117
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7118
            "login": "stesser",
7119
            "name": "Stefan Esser"
7120
          }
7121
        ],
7122
        "committedDate": "2019-04-29T15:10:43Z",
7123
        "messageBody": "…orithm\n\nIntroduce and use a function bc_num_int_digits() that counts the number of digits\nto the left of the decimalpoint.",
7124
        "messageHeadline": "Fix and improve the calculation of the initial value for the sqrt alg…",
7125
        "oid": "cc7cd938dadfd8ecbaf61e79f7fba8060ff7194c"
7126
      },
7127
      {
7128
        "authoredDate": "2019-04-29T18:13:51Z",
7129
        "authors": [
7130
          {
7131
            "email": "[email protected]",
7132
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7133
            "login": "stesser",
7134
            "name": "Stefan Esser"
7135
          }
7136
        ],
7137
        "committedDate": "2019-04-29T18:13:51Z",
7138
        "messageBody": "",
7139
        "messageHeadline": "Make more Sqrt tests work",
7140
        "oid": "8f7c5a565c0c8cb4f674982c6fbb3174d6eaeee9"
7141
      },
7142
      {
7143
        "authoredDate": "2019-04-29T18:49:15Z",
7144
        "authors": [
7145
          {
7146
            "email": "[email protected]",
7147
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7148
            "login": "stesser",
7149
            "name": "Stefan Esser"
7150
          }
7151
        ],
7152
        "committedDate": "2019-04-29T18:49:15Z",
7153
        "messageBody": "",
7154
        "messageHeadline": "Make all Sqrt tests work",
7155
        "oid": "1f0f69f0d249d14270fe14a993405926a536ce05"
7156
      },
7157
      {
7158
        "authoredDate": "2019-04-29T19:28:52Z",
7159
        "authors": [
7160
          {
7161
            "email": "[email protected]",
7162
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7163
            "login": "stesser",
7164
            "name": "Stefan Esser"
7165
          }
7166
        ],
7167
        "committedDate": "2019-04-29T19:28:52Z",
7168
        "messageBody": "",
7169
        "messageHeadline": "Apply existing style to my changes - no functional change",
7170
        "oid": "f76f0365e272d675c73fb62dcfa09653960106fc"
7171
      },
7172
      {
7173
        "authoredDate": "2019-04-29T20:10:41Z",
7174
        "authors": [
7175
          {
7176
            "email": "[email protected]",
7177
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7178
            "login": "stesser",
7179
            "name": "Stefan Esser"
7180
          }
7181
        ],
7182
        "committedDate": "2019-04-29T20:10:41Z",
7183
        "messageBody": "",
7184
        "messageHeadline": "Fix debug printing of BcNum variables",
7185
        "oid": "0dea79ffb116b3395b949b18d80473af9e969ced"
7186
      },
7187
      {
7188
        "authoredDate": "2019-04-30T08:47:06Z",
7189
        "authors": [
7190
          {
7191
            "email": "[email protected]",
7192
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7193
            "login": "stesser",
7194
            "name": "Stefan Esser"
7195
          }
7196
        ],
7197
        "committedDate": "2019-04-30T08:47:06Z",
7198
        "messageBody": "…uns easier to decode",
7199
        "messageHeadline": "Make debug printing of BcNum variables use signed values to make over…",
7200
        "oid": "f8610b15aeed384d520d83ba66c964abd828d096"
7201
      },
7202
      {
7203
        "authoredDate": "2019-04-30T09:24:44Z",
7204
        "authors": [
7205
          {
7206
            "email": "[email protected]",
7207
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7208
            "login": "stesser",
7209
            "name": "Stefan Esser"
7210
          }
7211
        ],
7212
        "committedDate": "2019-04-30T09:24:44Z",
7213
        "messageBody": "",
7214
        "messageHeadline": "Fix printing of numbers with obase != 10 (length of fractional part)",
7215
        "oid": "36220832c7341fd267fdfb4010c579c5bc840a60"
7216
      },
7217
      {
7218
        "authoredDate": "2019-05-02T08:43:02Z",
7219
        "authors": [
7220
          {
7221
            "email": "[email protected]",
7222
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7223
            "login": "stesser",
7224
            "name": "Stefan Esser"
7225
          }
7226
        ],
7227
        "committedDate": "2019-05-02T08:43:02Z",
7228
        "messageBody": "",
7229
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
7230
        "oid": "4534283defbcd20faf921666b0b32693633c3ec2"
7231
      },
7232
      {
7233
        "authoredDate": "2019-05-02T08:43:21Z",
7234
        "authors": [
7235
          {
7236
            "email": "[email protected]",
7237
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7238
            "login": "stesser",
7239
            "name": "Stefan Esser"
7240
          }
7241
        ],
7242
        "committedDate": "2019-05-02T08:43:21Z",
7243
        "messageBody": "…results.\n\nThe implementation can be changed back to a macro that accesses the array\nwithout any further computation, if the function should take non-negligible\ntime. But the function will be inlined or optimized away in most cases and\nthus should not have a significant impact on the run-time ...",
7244
        "messageHeadline": "Revert bc_num_pow10 to a function instead of an array that holds the …",
7245
        "oid": "6167e2231df4f606278ca414931612a0e7d595e1"
7246
      },
7247
      {
7248
        "authoredDate": "2019-05-02T08:56:01Z",
7249
        "authors": [
7250
          {
7251
            "email": "[email protected]",
7252
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7253
            "login": "stesser",
7254
            "name": "Stefan Esser"
7255
          }
7256
        ],
7257
        "committedDate": "2019-05-02T08:56:01Z",
7258
        "messageBody": "",
7259
        "messageHeadline": "Add back the forward declaration of bc_num_pow10.",
7260
        "oid": "5b2af58b477230aea07d7f69d401390d500b5a75"
7261
      },
7262
      {
7263
        "authoredDate": "2019-05-02T11:38:00Z",
7264
        "authors": [
7265
          {
7266
            "email": "[email protected]",
7267
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7268
            "login": "stesser",
7269
            "name": "Stefan Esser"
7270
          }
7271
        ],
7272
        "committedDate": "2019-05-02T11:38:00Z",
7273
        "messageBody": "",
7274
        "messageHeadline": "Allow to pass BC_BASE_POWER on the compiler command line",
7275
        "oid": "4d90ccff6ac554b33b5832d79bca935cb8d03fc3"
7276
      },
7277
      {
7278
        "authoredDate": "2019-05-04T07:12:09Z",
7279
        "authors": [
7280
          {
7281
            "email": "[email protected]",
7282
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7283
            "login": "stesser",
7284
            "name": "Stefan Esser"
7285
          }
7286
        ],
7287
        "committedDate": "2019-05-04T07:12:09Z",
7288
        "messageBody": "",
7289
        "messageHeadline": "Fix decoding of BcNum in debug print function",
7290
        "oid": "f28be31518134f169a64d4a8104414c335b5c947"
7291
      },
7292
      {
7293
        "authoredDate": "2019-05-04T07:14:02Z",
7294
        "authors": [
7295
          {
7296
            "email": "[email protected]",
7297
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7298
            "login": "stesser",
7299
            "name": "Stefan Esser"
7300
          }
7301
        ],
7302
        "committedDate": "2019-05-04T07:14:02Z",
7303
        "messageBody": "",
7304
        "messageHeadline": "Fix merge errors in idivision based on Goldschmidt algorithm",
7305
        "oid": "10bca1171455d813a70b60a6bb05538b40831c1a"
7306
      },
7307
      {
7308
        "authoredDate": "2019-05-04T07:24:27Z",
7309
        "authors": [
7310
          {
7311
            "email": "[email protected]",
7312
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7313
            "login": "stesser",
7314
            "name": "Stefan Esser"
7315
          }
7316
        ],
7317
        "committedDate": "2019-05-04T07:24:27Z",
7318
        "messageBody": "\"shift\" operations are used within all arithmetic operations\n\"print\" is a pre-requisite of generating the results file for the \"parse\" test",
7319
        "messageHeadline": "Change order of tests to first test features that later tests depend on",
7320
        "oid": "f213e28e1a70e1ca581f9d137a1498dedcf97095"
7321
      },
7322
      {
7323
        "authoredDate": "2019-05-04T13:58:41Z",
7324
        "authors": [
7325
          {
7326
            "email": "[email protected]",
7327
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7328
            "login": "stesser",
7329
            "name": "Stefan Esser"
7330
          }
7331
        ],
7332
        "committedDate": "2019-05-04T13:58:41Z",
7333
        "messageBody": "…compiler warning",
7334
        "messageHeadline": "Change type of variables in debug print function to int to silence a …",
7335
        "oid": "013aeffa913df9dd96eec9c2dacfb64c9e766868"
7336
      },
7337
      {
7338
        "authoredDate": "2019-05-04T14:19:12Z",
7339
        "authors": [
7340
          {
7341
            "email": "[email protected]",
7342
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7343
            "login": "stesser",
7344
            "name": "Stefan Esser"
7345
          }
7346
        ],
7347
        "committedDate": "2019-05-04T14:19:12Z",
7348
        "messageBody": "The correction is derived from the difference of the input parameter times it inverse.\nThis value could be used for a final Newton-Raphson step (at the cost of an additional\nmultiplication), but since we can assume that the input\tparameter was very near\tto 1.0,\nthe multiplication would only add non-zero digits beyond the current scale range.\n\nThe Goldschmidt\talgorithm is an\tinfinite series\tof ever smaller positive values\tand\nif the series is cut off at some point,\tthe result is known to be exact\tor smaller\nthan the exact value.\n\nThe correction applied is meant\tto compensate for the neglected\tseries elements.\nIf it is found that there are boundary cases where we over-compensate, then the\nNewton-Raphson step could be used to apply a slightly smaller correction.",
7349
        "messageHeadline": "Add correction to result of Goldschmidt\talgorithm",
7350
        "oid": "85f59a665e6b20380accdb7c9f5fbca0d39d693b"
7351
      },
7352
      {
7353
        "authoredDate": "2019-05-04T14:24:40Z",
7354
        "authors": [
7355
          {
7356
            "email": "[email protected]",
7357
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7358
            "login": "stesser",
7359
            "name": "Stefan Esser"
7360
          }
7361
        ],
7362
        "committedDate": "2019-05-04T14:24:40Z",
7363
        "messageBody": "After a correction is applied to the returned reciprocal to account for the finite\nnumber of elements used in teh Goldschmidt algorithm, the result should be correct\nwithout the final rounding step.\n\nWhile here also remove the assignment of 1 to a variable that is not used for the\nspecific case anymore, anyway ...",
7364
        "messageHeadline": "Adapt division algorithm to use the updated bc_num_invert()",
7365
        "oid": "7e21b3cca2b93e7d5509e05dbf3d2076dcffa74d"
7366
      },
7367
      {
7368
        "authoredDate": "2019-05-04T15:01:21Z",
7369
        "authors": [
7370
          {
7371
            "email": "[email protected]",
7372
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7373
            "login": "stesser",
7374
            "name": "Stefan Esser"
7375
          }
7376
        ],
7377
        "committedDate": "2019-05-04T15:01:21Z",
7378
        "messageBody": "",
7379
        "messageHeadline": "Fix width of value printed for base > 17",
7380
        "oid": "017f0c843a3439651ce310cdb6ffc90cc09f6203"
7381
      },
7382
      {
7383
        "authoredDate": "2019-05-04T15:05:12Z",
7384
        "authors": [
7385
          {
7386
            "email": "[email protected]",
7387
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7388
            "login": "stesser",
7389
            "name": "Stefan Esser"
7390
          }
7391
        ],
7392
        "committedDate": "2019-05-04T15:05:12Z",
7393
        "messageBody": "",
7394
        "messageHeadline": "Fix printing of fractional parts for obase > 10",
7395
        "oid": "1a503e62ff9e642740577f8df68e439a1b9e1d10"
7396
      },
7397
      {
7398
        "authoredDate": "2019-05-04T16:02:15Z",
7399
        "authors": [
7400
          {
7401
            "email": "[email protected]",
7402
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7403
            "login": "stesser",
7404
            "name": "Stefan Esser"
7405
          }
7406
        ],
7407
        "committedDate": "2019-05-04T16:02:15Z",
7408
        "messageBody": "It has been found to be too low e.g. when calculating l(256)/l(16) with scale=40.\nThe result is exact with this increased correction applied.",
7409
        "messageHeadline": "Double correction value applied in bc_num_invert()",
7410
        "oid": "b9db23ba3b452798cc5b4ded0125565e5940f3e3"
7411
      },
7412
      {
7413
        "authoredDate": "2019-05-04T18:12:43Z",
7414
        "authors": [
7415
          {
7416
            "email": "[email protected]",
7417
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7418
            "login": "stesser",
7419
            "name": "Stefan Esser"
7420
          }
7421
        ],
7422
        "committedDate": "2019-05-04T18:12:43Z",
7423
        "messageBody": "The locations with these markers should be checked, although the tests seem to\nsucceed wíthiut them.\n\nCurrently test succeed until \"reference.bc2\", which returns zeroes for some of\nthe test arrays. But these marked locations are probably not related to that\ntest failing.",
7424
        "messageHeadline": "Mark a few places where changes might be required with // <se>",
7425
        "oid": "276de8c876ba72f1357dd0ce7cc1ef403902cedf"
7426
      },
7427
      {
7428
        "authoredDate": "2019-05-04T21:48:51Z",
7429
        "authors": [
7430
          {
7431
            "email": "[email protected]",
7432
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7433
            "login": "stesser",
7434
            "name": "Stefan Esser"
7435
          }
7436
        ],
7437
        "committedDate": "2019-05-04T21:48:51Z",
7438
        "messageBody": "This change has been performed due to a source code analysis.\nNo tests failed with the old code (i.e., no test covered this case).",
7439
        "messageHeadline": "Fix length parameter which obviously should be scale not rdx",
7440
        "oid": "e6bd86bdb390d0a74b31aabdde56d5824f38741c"
7441
      },
7442
      {
7443
        "authoredDate": "2019-05-04T21:50:38Z",
7444
        "authors": [
7445
          {
7446
            "email": "[email protected]",
7447
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7448
            "login": "stesser",
7449
            "name": "Stefan Esser"
7450
          }
7451
        ],
7452
        "committedDate": "2019-05-04T21:50:38Z",
7453
        "messageBody": "",
7454
        "messageHeadline": "Add comments to the division based on the Goldschmidt algorithm",
7455
        "oid": "28ffb91991cb5ca2c8687de2ff355161088d5997"
7456
      },
7457
      {
7458
        "authoredDate": "2019-05-05T19:54:54Z",
7459
        "authors": [
7460
          {
7461
            "email": "[email protected]",
7462
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7463
            "login": "stesser",
7464
            "name": "Stefan Esser"
7465
          }
7466
        ],
7467
        "committedDate": "2019-05-05T19:54:54Z",
7468
        "messageBody": "… crashing\n\nThe cut-off value is arbitrary, a significantly lower limit could be applied.",
7469
        "messageHeadline": "Make shiftLeft return an error for too large shift amounts instead of…",
7470
        "oid": "e274dbe523657c7bfc4228ddbf2e6dfbbca36059"
7471
      },
7472
      {
7473
        "authoredDate": "2019-05-05T20:00:21Z",
7474
        "authors": [
7475
          {
7476
            "email": "[email protected]",
7477
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7478
            "login": "stesser",
7479
            "name": "Stefan Esser"
7480
          }
7481
        ],
7482
        "committedDate": "2019-05-05T20:00:21Z",
7483
        "messageBody": "The Goldschmidt algorithm needs larger arguments than supported by the\narray.\n\nA larger array could be used, but a disassembly showed, that the array\naccess was converted to an inlined and rolled out chain of comparisons\nand assignments.",
7484
        "messageHeadline": "Optimize bc_num_pow10() and remove the unused bc_num_pow10 array",
7485
        "oid": "914a7f66807b3567fa438c8d668a040e9d2bcc4a"
7486
      }
7487
    ],
7488
    "createdAt": "2019-04-28T15:29:42Z",
7489
    "deletions": 63,
7490
    "files": [
7491
      {
7492
        "path": "include/num.h",
7493
        "additions": 33,
7494
        "deletions": 13
7495
      },
7496
      {
7497
        "path": "src/data.c",
7498
        "additions": 0,
7499
        "deletions": 19
7500
      },
7501
      {
7502
        "path": "src/num.c",
7503
        "additions": 260,
7504
        "deletions": 29
7505
      },
7506
      {
7507
        "path": "tests/bc/all.txt",
7508
        "additions": 2,
7509
        "deletions": 2
7510
      }
7511
    ],
7512
    "fullDatabaseId": "274187961",
7513
    "headRefName": "d9",
7514
    "headRefOid": "914a7f66807b3567fa438c8d668a040e9d2bcc4a",
7515
    "headRepository": {
7516
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
7517
      "name": "bc"
7518
    },
7519
    "headRepositoryOwner": {
7520
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
7521
      "name": "Stefan Eßer",
7522
      "login": "stesser"
7523
    },
7524
    "id": "MDExOlB1bGxSZXF1ZXN0Mjc0MTg3OTYx",
7525
    "isCrossRepository": true,
7526
    "isDraft": false,
7527
    "labels": [],
7528
    "latestReviews": [],
7529
    "maintainerCanModify": false,
7530
    "mergeCommit": null,
7531
    "mergeStateStatus": "DIRTY",
7532
    "mergeable": "CONFLICTING",
7533
    "mergedAt": null,
7534
    "mergedBy": null,
7535
    "milestone": null,
7536
    "number": 17,
7537
    "potentialMergeCommit": null,
7538
    "projectCards": [],
7539
    "projectItems": [],
7540
    "reactionGroups": [],
7541
    "reviewDecision": "",
7542
    "reviewRequests": [],
7543
    "reviews": [],
7544
    "state": "CLOSED",
7545
    "statusCheckRollup": [],
7546
    "title": "Implementation of an alternate algorithm for reciprocal values",
7547
    "updatedAt": "2019-05-06T13:42:51Z",
7548
    "url": "https://github.com/gavinhoward/bc/pull/17"
7549
  },
7550
  {
7551
    "additions": 147,
7552
    "assignees": [],
7553
    "author": {
7554
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
7555
      "is_bot": false,
7556
      "login": "stesser",
7557
      "name": "Stefan Eßer"
7558
    },
7559
    "autoMergeRequest": null,
7560
    "baseRefName": "base9",
7561
    "baseRefOid": "c25fd61637390cc993c91258dda2c01404b37147",
7562
    "body": "The code is not cleaned up, but since you said your are waiting for it ...",
7563
    "changedFiles": 1,
7564
    "closed": true,
7565
    "closedAt": "2019-04-27T12:40:59Z",
7566
    "comments": [
7567
      {
7568
        "id": "MDEyOklzc3VlQ29tbWVudDQ4NzI4Mjk1Ng==",
7569
        "author": {
7570
          "login": "gavinhoward"
7571
        },
7572
        "authorAssociation": "OWNER",
7573
        "body": "Merged. Will get to work on it now.",
7574
        "createdAt": "2019-04-27T12:41:09Z",
7575
        "includesCreatedEdit": false,
7576
        "isMinimized": false,
7577
        "minimizedReason": "",
7578
        "reactionGroups": [],
7579
        "url": "https://github.com/gavinhoward/bc/pull/16#issuecomment-487282956",
7580
        "viewerDidAuthor": true
7581
      }
7582
    ],
7583
    "commits": [
7584
      {
7585
        "authoredDate": "2019-04-26T23:29:01Z",
7586
        "authors": [
7587
          {
7588
            "email": "[email protected]",
7589
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7590
            "login": "stesser",
7591
            "name": "Stefan Esser"
7592
          }
7593
        ],
7594
        "committedDate": "2019-04-26T23:29:01Z",
7595
        "messageBody": "",
7596
        "messageHeadline": "Iterative division based on Newton Raphson algorithm",
7597
        "oid": "193f8529ad93306e39914ca7a2aa877669383f6f"
7598
      },
7599
      {
7600
        "authoredDate": "2019-04-27T07:16:26Z",
7601
        "authors": [
7602
          {
7603
            "email": "[email protected]",
7604
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7605
            "login": "stesser",
7606
            "name": "Stefan Esser"
7607
          }
7608
        ],
7609
        "committedDate": "2019-04-27T07:16:26Z",
7610
        "messageBody": "",
7611
        "messageHeadline": "Merge branch 'base9' of https://github.com/gavinhoward/bc into d9",
7612
        "oid": "87c27b5715646eb4deec4a6795c17b4c5facc408"
7613
      },
7614
      {
7615
        "authoredDate": "2019-04-27T08:39:00Z",
7616
        "authors": [
7617
          {
7618
            "email": "[email protected]",
7619
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7620
            "login": "stesser",
7621
            "name": "Stefan Esser"
7622
          }
7623
        ],
7624
        "committedDate": "2019-04-27T08:39:00Z",
7625
        "messageBody": "",
7626
        "messageHeadline": "Fix mismerge regarding nBcDig vs. places",
7627
        "oid": "70f118574077b6e61cae08bd576ca7fccc167786"
7628
      },
7629
      {
7630
        "authoredDate": "2019-04-27T08:40:14Z",
7631
        "authors": [
7632
          {
7633
            "email": "[email protected]",
7634
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7635
            "login": "stesser",
7636
            "name": "Stefan Esser"
7637
          }
7638
        ],
7639
        "committedDate": "2019-04-27T08:40:14Z",
7640
        "messageBody": "…e current rdx",
7641
        "messageHeadline": "Fix segmentation fault that occurs if the target rdx is lower than th…",
7642
        "oid": "6189d95036f123d48d505bf4d4a49ba11ca30aee"
7643
      },
7644
      {
7645
        "authoredDate": "2019-04-27T08:42:00Z",
7646
        "authors": [
7647
          {
7648
            "email": "[email protected]",
7649
            "id": "MDQ6VXNlcjYyNjQ1NDY=",
7650
            "login": "stesser",
7651
            "name": "Stefan Esser"
7652
          }
7653
        ],
7654
        "committedDate": "2019-04-27T08:42:00Z",
7655
        "messageBody": "",
7656
        "messageHeadline": "Add simple debug print macro",
7657
        "oid": "cdda6e99974b8f9551ad1bc184b3c735afac6f4a"
7658
      },
7659
      {
7660
        "authoredDate": "2019-04-27T11:47:09Z",
7661
        "authors": [
7662
          {
7663
            "email": "[email protected]",
7664
            "id": "",
7665
            "login": "",
7666
            "name": "Charlie Root"
7667
          }
7668
        ],
7669
        "committedDate": "2019-04-27T11:47:09Z",
7670
        "messageBody": "",
7671
        "messageHeadline": "Fix calculation of scale in multiplications",
7672
        "oid": "ac244bdb3ebe6e6a2693f3d5c2ae13d7723b3517"
7673
      }
7674
    ],
7675
    "createdAt": "2019-04-26T23:33:21Z",
7676
    "deletions": 63,
7677
    "files": [
7678
      {
7679
        "path": "src/num.c",
7680
        "additions": 147,
7681
        "deletions": 63
7682
      }
7683
    ],
7684
    "fullDatabaseId": "274063201",
7685
    "headRefName": "d9",
7686
    "headRefOid": "ac244bdb3ebe6e6a2693f3d5c2ae13d7723b3517",
7687
    "headRepository": {
7688
      "id": "MDEwOlJlcG9zaXRvcnkxODAzNzI3NzY=",
7689
      "name": "bc"
7690
    },
7691
    "headRepositoryOwner": {
7692
      "id": "MDQ6VXNlcjYyNjQ1NDY=",
7693
      "name": "Stefan Eßer",
7694
      "login": "stesser"
7695
    },
7696
    "id": "MDExOlB1bGxSZXF1ZXN0Mjc0MDYzMjAx",
7697
    "isCrossRepository": true,
7698
    "isDraft": false,
7699
    "labels": [],
7700
    "latestReviews": [],
7701
    "maintainerCanModify": false,
7702
    "mergeCommit": {
7703
      "oid": "769fcbed7a3a0005a60254c0ed5203406b533ae3"
7704
    },
7705
    "mergeStateStatus": "DIRTY",
7706
    "mergeable": "CONFLICTING",
7707
    "mergedAt": "2019-04-27T12:40:59Z",
7708
    "mergedBy": {
7709
      "id": "MDQ6VXNlcjMxNzI2ODc=",
7710
      "is_bot": false,
7711
      "login": "gavinhoward",
7712
      "name": "Gavin D. Howard"
7713
    },
7714
    "milestone": null,
7715
    "number": 16,
7716
    "potentialMergeCommit": null,
7717
    "projectCards": [],
7718
    "projectItems": [],
7719
    "reactionGroups": [],
7720
    "reviewDecision": "",
7721
    "reviewRequests": [],
7722
    "reviews": [],
7723
    "state": "MERGED",
7724
    "statusCheckRollup": [],
7725
    "title": "Newton-Raphson based division",
7726
    "updatedAt": "2019-04-27T12:41:09Z",
7727
    "url": "https://github.com/gavinhoward/bc/pull/16"
7728
  }
7729
]
7730

7731
Product

Resources

Company
